Use RID-layout for OS configurations in libraries

@Anipik

We should switch to the well defined RID system away from our current defined OS configurations. This allows us to share the OS configuration matrix with installer and have just one central point where this is defined.

See

runtime/src/installer/Directory.Build.props

Lines 227 to 308 in 9704493

    
           <Choose> 
        
             <When Condition="$(OutputRid.StartsWith('win'))"> 
        
               <PropertyGroup> 
        
                 <TargetsWindows>true</TargetsWindows> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('osx'))"> 
        
               <PropertyGroup> 
        
                 <TargetsOSX>true</TargetsOSX> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('debian'))"> 
        
               <PropertyGroup> 
        
                 <TargetsDebian>true</TargetsDebian> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('ubuntu'))"> 
        
               <PropertyGroup> 
        
                 <TargetsUbuntu>true</TargetsUbuntu> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('linuxmint'))"> 
        
               <PropertyGroup> 
        
                 <TargetsLinuxMint>true</TargetsLinuxMint> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('rhel'))"> 
        
               <PropertyGroup> 
        
                 <TargetsRhel>true</TargetsRhel> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('centos'))"> 
        
               <PropertyGroup> 
        
                 <TargetsCentos>true</TargetsCentos> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('opensuse'))"> 
        
               <PropertyGroup> 
        
                 <TargetsOpensuse>true</TargetsOpensuse> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('fedora'))"> 
        
               <PropertyGroup> 
        
                 <TargetsFedora>true</TargetsFedora> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('oracle'))"> 
        
               <PropertyGroup> 
        
                 <TargetsOracle>true</TargetsOracle> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <When Condition="$(OutputRid.StartsWith('sles'))"> 
        
               <PropertyGroup> 
        
                 <TargetsSles>true</TargetsSles> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </When> 
        
             <Otherwise> 
        
               <PropertyGroup> 
        
                 <TargetsLinux>true</TargetsLinux> 
        
                 <TargetsUnix>true</TargetsUnix> 
        
               </PropertyGroup> 
        
             </Otherwise> 
        
           </Choose>

for how this is currently implemented in installers.

cc @Anipik @ericstj

@Anipik

Yep, @Anipik and I talked about this and agreed this would be good, to avoid the custom runtime.json. We didn't do it in initial pass because it would churn all the projects. Now is a good time to do it.

@jkotas

Things that need to get done here. Taken from @jkotas comment #33315 (comment)

Changes that affect developer workflow should be synchronized using Infrastructure - Rollout (April 2020) #33821
For anything that gets renamed to use RIDs, make it follow RIDs 100%: i.e.: Debug\win-x64 instead of win.x64.Debug, linux-arm instead linux_arm, etc.
Renaming of the build output directories to use RIDs sounds reasonable. I agree with Eric that the .NET SDK uses RID based directory names, and so it sounds reasonable for consistency.
Can this be broken into multiple changes? E.g. Would it make sense to rename the output directories as the step 1, without changing the other stuff? Or can the renames in the CI config be separate change?
The non-RID names are used in number of places, and we won't be able to change all of them and achive 100% consistency. I do not think it makes sense to try to change as much as possible to use RID OS names. I think we should rather strike the right ballance, e.g. switch to use RIDs where there is a clear prior art (e.g. where the .NET SDK is using them) and leave the rest alone. For example, I do not think it makes sense to be changing the CMakeFiles to use RID OS names.

@Anipik

@Anipik sounds like we can make incremental progress. Do you want to work on this and if yes, can you break down the necessary changes into individual tasks with a rough estimation? Would like to better understand the size of this task.

The Benefits vs cost scenario is not that great for this issue, so we put it on hold. But u can summarize the steps in detail

Lowercase TargetOS (#80164)

Navigation Menu

Repository navigation

Use RID-layout for OS configurations in libraries #32451

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Choose>
	<When Condition="$(OutputRid.StartsWith('win'))">
	<PropertyGroup>
	<TargetsWindows>true</TargetsWindows>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('osx'))">
	<PropertyGroup>
	<TargetsOSX>true</TargetsOSX>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('debian'))">
	<PropertyGroup>
	<TargetsDebian>true</TargetsDebian>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('ubuntu'))">
	<PropertyGroup>
	<TargetsUbuntu>true</TargetsUbuntu>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('linuxmint'))">
	<PropertyGroup>
	<TargetsLinuxMint>true</TargetsLinuxMint>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('rhel'))">
	<PropertyGroup>
	<TargetsRhel>true</TargetsRhel>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('centos'))">
	<PropertyGroup>
	<TargetsCentos>true</TargetsCentos>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('opensuse'))">
	<PropertyGroup>
	<TargetsOpensuse>true</TargetsOpensuse>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('fedora'))">
	<PropertyGroup>
	<TargetsFedora>true</TargetsFedora>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('oracle'))">
	<PropertyGroup>
	<TargetsOracle>true</TargetsOracle>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<When Condition="$(OutputRid.StartsWith('sles'))">
	<PropertyGroup>
	<TargetsSles>true</TargetsSles>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</When>
	<Otherwise>
	<PropertyGroup>
	<TargetsLinux>true</TargetsLinux>
	<TargetsUnix>true</TargetsUnix>
	</PropertyGroup>
	</Otherwise>
	</Choose>

Use RID-layout for OS configurations in libraries #32451

Description

Activity

ericstj commented on Feb 18, 2020

Anipik commented on May 27, 2020

ViktorHofer commented on Jun 9, 2020

Anipik commented on Jun 30, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions