Repository navigation
Regression in SortedSet::Max #20474
Description
introduced in dotnet/corefx#11968
using System;
using System.Collections.Generic;
class X
{
public static void Main ()
{
var set = new SortedSet<int> { 1, 3, 5, 7, 9 };
var view = set.GetViewBetween (4, 8);
Console.WriteLine (view.Max); // Prints 9 instead of 7
}
}
Activity
stephentoub commentedon Mar 6, 2017
cc: @mjp41, @ianhays
mjp41 commentedon Mar 6, 2017
Sorry. So the previous code for
MinandMaxwas usingInOrderTreeWalk, which got overridden byTreeSubset.There look like there are three possible fixes,
Can/should subclasses depend on
MinandMaxcallingInOrderTreeWalk? It isinternal, so as long as we find all subclasses in CoreFX then it should be okay to do 1 or 2. I am happy to do 1 or 2.2 is the simplest, 1 would be the most optimal. What is the time line for needing the fix?
stephentoub commentedon Mar 6, 2017
Relatively soon :)
Let's do whichever strikes a decent balance between not being too much worse on perf and minimizing the chance of further regression. Sounds like that's 2?