Skip to content

Potential Issues with Deserializing ISerializable Types #1414

Closed
Woodpile37/runtime
#47

Description

@shmao

There's a couple of potential issues with deserializing ISerializable types,

  1. An ISerializable type's OnDeserializing callback is not called on the actual deserialized object.
  2. The object added to XmlObjectSerializerReadContext is not the actual deserialized, which may cause wrong behavior in "IsReference=true" scenarios.

The issues occur with both ILGen based and reflection only based serialization. To investigate the issue, we need to look into the following methods,

ReflectionReader.ReflectionReadClass
XmlFormatReaderGeneratorCriticalHelper.GenerateClassReader
JsonFormatReaderGenerator.CriticalHelper.GenerateClassReader

Activity

  1. added this to the Future milestone on Jan 7, 2020
  2. added
    help wanted[up-for-grabs] Good issue for external contributors
    and removed
    untriagedNew issue has not been triaged by the area owner
    on Jan 7, 2020
  3. StephenBonikowsky commented on Feb 28, 2020

    @StephenBonikowsky
    Contributor

    No customer asks for this.

  4. ghost locked as resolved and limited conversation to collaborators on Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-Serializationhelp wanted[up-for-grabs] Good issue for external contributorsuntriagedNew issue has not been triaged by the area owner

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions