Split the big jit files to allow better GitHub experience. #13359

Activity

1. danmoseley commented on Sep 15, 2019

   

   danmoseley

   on Sep 15, 2019

   Contributor

   More actions

   Browser issue? I see all 25K lines at https://github.com/dotnet/coreclr/blob/master/src/jit/flowgraph.cpp. It takes time though and that doesn't mean smaller isn't better.
2. Joe4evr commented on Sep 15, 2019

   

   Joe4evr

   on Sep 15, 2019

   Contributor

   More actions

   There was a discussion somewhat similar to this back when this repo was still new: https://github.com/dotnet/coreclr/issues/408#issuecomment-77922359
3. sandreenko commented on Oct 25, 2019

   

   sandreenko

   on Oct 25, 2019

   ContributorAuthor

   More actions

   I got the answer from the GitHub support:

   We currently limit blob displaying to around 500kb of data, anything more we truncate in the UI. You can view the raw by clicking through.

   So I think it would be rational to make a 400kb limit for all files that we have, it means we need to split 9 files:

   10/14/2019  05:29 PM           413,140 emitarm64.cpp
   10/14/2019  05:29 PM           435,201 lsra.cpp
   10/24/2019  03:32 PM           447,708 compiler.h <- header!
   10/14/2019  05:29 PM           451,531 codegencommon.cpp
   10/24/2019  03:32 PM           462,582 emitxarch.cpp
   10/24/2019  03:32 PM           637,322 gentree.cpp
   10/24/2019  03:32 PM           734,066 morph.cpp
   10/24/2019  03:32 PM           823,537 importer.cpp
   10/24/2019  03:32 PM           920,170 flowgraph.cpp
   
4. mikedn commented on Oct 25, 2019

   

   mikedn

   on Oct 25, 2019

   Contributor

   More actions

   Any idea how they can be split in a rational manner (e.g. not by cutting it in half and having something like importer1.cpp and importer2.cpp 😁)?

   For flowgraph.cpp I'm sure we can find code in it that's not actually flowgraph related and perhaps that there's enough of it to move it somewhere else and matter. Not sure about the rest.
5. sandreenko commented on Oct 25, 2019

   

   sandreenko

   on Oct 25, 2019

   ContributorAuthor

   More actions

   Any idea how they can be split in a rational manner (e.g. not by cutting it in half and having something like importer1.cpp and importer2.cpp 😁)?

   For flowgraph.cpp I'm sure we can find code in it that's not actually flowgraph related and perhaps that there's enough of it to move it somewhere else and matter. Not sure about the rest.

   I think it should be individual in each case, and I think compiler.h is the biggest problem.

   For example, for importer, it is probably enough to extract impImportBlockCode to solve that (it is 5000+ lines function).

   Also, we can extract Compiler::verification logic or intrinsic functions.
6. msftgits

   transferred this issue fromdotnet/coreclron Jan 31, 2020
7. msftgits

   added this to the Future milestone on Jan 31, 2020
8. BruceForstall

   added

   JitUntriagedCLR JIT issues needing additional triageCLR JIT issues needing additional triage

   on Oct 28, 2020
9. sandreenko

   removed

   JitUntriagedCLR JIT issues needing additional triageCLR JIT issues needing additional triage

   on Jan 4, 2021