Add a JsonObject.TryAdd method. #110244

Activity

1. eiriktsarpalis

   transferred this issue frommicrosoft/aspireon Nov 28, 2024
2. ghost added

   needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area ownersAn area label is needed to ensure this gets routed to the appropriate area owners

   on Nov 28, 2024
3. dotnet-policy-service

   added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Nov 28, 2024
4. eiriktsarpalis

   added

   area-System.Text.Json

   and removed

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area ownersAn area label is needed to ensure this gets routed to the appropriate area owners

   on Nov 28, 2024
5. eiriktsarpalis

   changed the title [-]This workaround requires dual lookup if the key is missing, which suggests to me that a `JsonObject.TryAdd`method similar to the one in https://github.com/dotnet/runtime/issues/107947 might be necessary.[/-] [+]Add a `JsonObject.TryAdd` method.[/+] on Nov 28, 2024
6. eiriktsarpalis

   added

   api-suggestionEarly API idea and discussion, it is NOT ready for implementationEarly API idea and discussion, it is NOT ready for implementation

   on Nov 28, 2024
7. dotnet-policy-service commented on Nov 28, 2024

   

   dotnet-policy-serviceBot

   on Nov 28, 2024 – with Dotnet Policy Service

   Contributor

   More actions

   Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
   See info in area-owners.md if you want to be subscribed.
8. eiriktsarpalis

   self-assigned this

   on Nov 28, 2024
9. eiriktsarpalis

   added

   api-ready-for-reviewAPI is ready for review, it is NOT ready for implementationAPI is ready for review, it is NOT ready for implementation

   and removed

   api-suggestionEarly API idea and discussion, it is NOT ready for implementationEarly API idea and discussion, it is NOT ready for implementation

   on Nov 28, 2024
10. terrajobst commented on Dec 3, 2024

    

    terrajobst

    on Dec 3, 2024

    Last edited by terrajobst

    Contributor

    More actions

    Video

    • Looks good as proposed but we should add an overload of TryAdd without the index for consistency and ergonomics
    • The behavior of what we return for the index should match OrderedDictionary<TKey, TValue>

    namespace System.Text.Json.Nodes;
    
    public partial class JsonObject
    {
        public bool TryAdd(string propertyName, JsonNode? value);
        public bool TryAdd(string propertyName, JsonNode? value, out int index);
        public bool TryGetPropertyValue(string propertyName, out JsonNode? jsonNode, out int index);
    }
11. terrajobst

    added

    api-approvedAPI was approved in API review, it can be implementedAPI was approved in API review, it can be implemented

    on Dec 3, 2024
12. eiriktsarpalis

    added this to the 10.0.0 milestone on Dec 3, 2024
13. terrajobst

    removed

    api-ready-for-reviewAPI is ready for review, it is NOT ready for implementationAPI is ready for review, it is NOT ready for implementation

    on Dec 6, 2024
14. Flu commented on Jan 8, 2025

    

    Flu

    on Jan 8, 2025

    Contributor

    More actions

    Is there anybody working on this? If not, I can take a stab at it.
15. eiriktsarpalis commented on Jan 8, 2025

    

    eiriktsarpalis

    on Jan 8, 2025

    MemberAuthor

    More actions

    @Flu go for it, thanks!
16. eiriktsarpalis

    assigned

    Flu

    and unassigned

    eiriktsarpalis

    on Jan 8, 2025
17. dotnet-policy-service

    added

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Jan 9, 2025
18. eiriktsarpalis

    closed this as completedin #111229on Jul 1, 2025
19. github-actions

    locked and limited conversation to collaborators on Aug 1, 2025