Skip to content

Order of attributes matters to the platform analyzer? #105423

Open
Open
Order of attributes matters to the platform analyzer?#105423
Labels
area-System.Runtimebugcode-analyzerMarks an issue that suggests a Roslyn analyzer
Milestone
Future

Description

@ericstj
ericstj
opened on Jul 24, 2024

In #105409 @akoeplinger needed to reorder platform attributes to fix an issue. I'm surprised our analyzer depends on the ordering of attributes. It's not a common characteristic of our API for order of attributes to matter. Is this intentional @buyaa-n @jeffhandley?

Reference: dotnet/roslyn-analyzers#5266

Activity

  1. ghost added
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Jul 24, 2024
  2. dotnet-policy-service
    added
    untriagedNew issue has not been triaged by the area owner
    on Jul 24, 2024
  3. ericstj
    added
    code-analyzerMarks an issue that suggests a Roslyn analyzer
    area-System.Runtime
    untriagedNew issue has not been triaged by the area owner
    and removed
    untriagedNew issue has not been triaged by the area owner
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Jul 24, 2024

  4. dotnet-policy-service commented on Jul 24, 2024

    @dotnet-policy-service
    dotnet-policy-serviceBot
    on Jul 24, 2024 – with Dotnet Policy Service
    Contributor

    Tagging subscribers to this area: @dotnet/area-system-runtime
    See info in area-owners.md if you want to be subscribed.

  5. jeffhandley
    added this to the Future milestone on Jul 27, 2024
  6. jeffhandley
    added
    bug
    and removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 27, 2024

  7. buyaa-n commented on Aug 2, 2024

    @buyaa-n
    buyaa-n
    on Aug 2, 2024
    Contributor

    In general order doesn't matter, it probably because of related platforms handling, as there is workaround @akoeplinger I assume this is not required for 9.0

  8. buyaa-n
    self-assigned this
    on Aug 2, 2024

  9. akoeplinger commented on Aug 2, 2024

    @akoeplinger
    akoeplinger
    on Aug 2, 2024
    Member

    correct, this is not needed for 9

  10. jeffhandley
    unassigned
    buyaa-n
    on Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-System.Runtimebugcode-analyzerMarks an issue that suggests a Roslyn analyzer

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions