Skip to content

[cdac-build-tool] Take baseline as a command line argument #101257

Closed
Closed
[cdac-build-tool] Take baseline as a command line argument#101257
Assignees
copilot-swe-agent
Labels
area-Diagnostics-coreclrenhancementProduct code improvement that does NOT require public API changes/additions
Milestone
11.0.0

Description

@lambdageek
lambdageek
opened on Apr 18, 2024

Follow-up work item for #100650. In the above PR we made cdac-build-tool take a CDAC_BASELINE("name") preprocessor macro to encode the baseline into the data blob in the object file that we scrape.

There's no need to do that, and it also introduces complications in future scenarios when there's multiple object files (produced by a C/C++ compiler and the NativeAOT compiler, for example): we now need all of them to agree about the baseline.

Instead we should take the baseline name as an optional command line argument and update CMakeLists.txt to pass in an appropriate (possibly platform-specific) one.

This is relatively low-priority because the initial workflow is using an empty baseline.

Activity

  1. ghost added
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Apr 18, 2024
  2. dotnet-policy-service
    added
    untriagedNew issue has not been triaged by the area owner
    on Apr 18, 2024
  3. jeffschwMSFT
    added
    area-Diagnostics-coreclr
    on Apr 19, 2024

  4. dotnet-policy-service commented on Apr 19, 2024

    @dotnet-policy-service
    dotnet-policy-serviceBot
    on Apr 19, 2024 – with Dotnet Policy Service
    Contributor

    Tagging subscribers to this area: @tommcdon
    See info in area-owners.md if you want to be subscribed.

  5. vcsjones
    removed
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Apr 19, 2024
  6. tommcdon
    added
    enhancementProduct code improvement that does NOT require public API changes/additions
    on Apr 23, 2024
  7. tommcdon
    added this to the 9.0.0 milestone on Apr 23, 2024
  8. dotnet-policy-service
    removed
    untriagedNew issue has not been triaged by the area owner
    on Apr 23, 2024
  9. tommcdon
    assigned
    lambdageek
    on Apr 23, 2024
  10. tommcdon
    modified the milestones: 9.0.0, 10.0.0 on Jul 23, 2024
  11. lambdageek
    assigned
    steveisok
    and unassigned
    lambdageek
    on Nov 1, 2024
  12. steveisok
    modified the milestones: 10.0.0, 11.0.0 on Jul 7, 2025
  13. steveisok
    removed their assignment
    on Nov 4, 2025
  14. max-charlamb
    assigned
    Copilot
    on Nov 4, 2025

  15. noahfalk commented on Jul 29, 2026

    @noahfalk
    noahfalk
    on Jul 29, 2026
    Member

    We've never started using non-empty baselines so closing this.

  16. noahfalk
    closed this as completedon Jul 29, 2026
  17. github-actions
    locked and limited conversation to collaborators on Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-Diagnostics-coreclrenhancementProduct code improvement that does NOT require public API changes/additions

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions