Skip to content

[android] trimmer warning for System.Private.CoreLib.dll #100256

Closed
#100263
Closed
[android] trimmer warning for System.Private.CoreLib.dll#100256
#100263
Assignees
sbomer
Labels
area-Tools-ILLink.NET linker development as well as trimming analyzerslinkable-frameworkIssues associated with delivering a linker friendly framework

Description

@jonathanpeppers
jonathanpeppers
opened on Mar 25, 2024

Description

This appeared here:

dotnet\packs\Microsoft.NETCore.App.Runtime.Mono.android-x86\9.0.0-preview.4.24173.6\runtimes\android-x86\native\System.Private.CoreLib.dll : warning IL2104: Assembly 'System.Private.CoreLib' produced trim warnings. For more information see https://aka.ms/dotnet-illink/libraries

-p:TrimmerSingleWarn=false yields additional information:

ILLink warning IL2045: System.Runtime.CompilerServices.RuntimeFeature.IsDynamicCodeCompiled: Attribute 'System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute' is being referenced in code but the trimmer was instructed to remove all instances of this attribute. If the attribute instances are necessary make sure to either remove the trimmer attribute XML portion which removes the attribute instances, or override the removal by using the trimmer XML descriptor to keep the attribute type (which in turn keeps all of its instances).

Reproduction Steps

  • dotnet new android
  • dotnet build -c Release

Add -p:TrimmerSingleWarn=false to get a more detailed warning.

Expected behavior

No trimmer warnings.

Actual behavior

Trimmer warning about System.Private.CoreLib.dll.

Regression?

Yes

Known Workarounds

I suppose you could set -p:SuppressTrimAnalysisWarnings=true, but that is not ideal.

Configuration

.NET SDK: 9.0.100-preview.4.24175.5
.NET Runtime 9.0.0-preview.4.24173.6: 596a1f7...17f8138

Other information

Build logs: android-trimmer.zip

Activity

  1. ghost added
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Mar 25, 2024
  2. dotnet-policy-service
    added
    untriagedNew issue has not been triaged by the area owner
    on Mar 25, 2024
  3. akoeplinger
    added
    area-Tools-ILLink.NET linker development as well as trimming analyzers
    and removed
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Mar 25, 2024
  4. github-project-automation
    added this to AppModelon Mar 25, 2024
  5. akoeplinger
    added
    linkable-frameworkIssues associated with delivering a linker friendly framework
    on Mar 25, 2024

  6. filipnavara commented on Mar 25, 2024

    @filipnavara
    filipnavara
    on Mar 25, 2024
    Member

    Introduced by #99641. /cc @sbomer

  7. sbomer
    self-assigned this
    on Mar 25, 2024

  8. jonathanpeppers commented on Mar 27, 2024

    @jonathanpeppers
    jonathanpeppers
    on Mar 27, 2024
    MemberAuthor

    This is happening here (.NET 9 Preview 3) as well: dotnet/android#8838

  9. jonathanpeppers
    added 2 commits that reference this issue on Mar 27, 2024

    FIXME: dotnet/runtime#100256

    663249b

    FIXME: dotnet/runtime#100256

    c49fd64
  10. dalexsoto
    added 2 commits that reference this issue on Mar 28, 2024

    FIXME: dotnet/runtime#100256

    5be5dea

    FIXME: dotnet/runtime#100256

    e75d5bf
  11. jonathanpeppers
    added 2 commits that reference this issue on Mar 28, 2024

    Bump to dotnet/installer@09d6f381e6 9.0.100-preview.3.24175.24 (#8838)

    9c1e2ef

    Bump to dotnet/installer@dc43d363d2 9.0.100-preview.4.24175.5 (#8828)

    378b492
  12. sbomer
    closed this as completedin #100263on Mar 28, 2024
  13. sbomer
    added a commit that references this issue on Mar 28, 2024

    Allow trimming FeatureGuard and FeatureSwitchDefinition attributes (#…

    e753712
  14. dotnet-policy-service
    removed
    untriagedNew issue has not been triaged by the area owner
    on Mar 28, 2024
  15. jonathanpeppers
    added 2 commits that reference this issue on Apr 8, 2024

    [tests] we can assert 0 trimmer warnings again

    26fff7a

    Bump to dotnet/installer@0bfd2dd757 9.0.100-preview.4.24208.2 (#8862)

    138701b
  16. github-actions
    locked and limited conversation to collaborators on Apr 28, 2024
  17. matouskozak
    added a commit that references this issue on Apr 30, 2024

    Allow trimming FeatureGuard and FeatureSwitchDefinition attributes (d…

    2dd58e7
  18. Ruihan-Yin
    added a commit that references this issue on May 30, 2024

    Allow trimming FeatureGuard and FeatureSwitchDefinition attributes (d…

    5742197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-Tools-ILLink.NET linker development as well as trimming analyzerslinkable-frameworkIssues associated with delivering a linker friendly framework

Type

No type

Projects

  • AppModel
    Status
    No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions