Skip to content

TaskAnalyzer: check false positives in real task implementations #15285

Open

Description

@VolPlita

Work kind

Delivery

Outcome

Check the task-authoring analyzer for false positives in representative task code. Turn confirmed findings into small reproductions and regression tests.

Use the behavior after #14777 as the baseline. Distinguish an incorrect diagnostic from a valid diagnostic that is noisy or has the wrong scope.

Completion criteria

  • Run the packaged analyzer on representative regular tasks, MT-scoped tasks, and source helpers used by those tasks.
  • Record the analyzer version, rule ID, source location, expected behavior, and a minimal reproduction for each confirmed false positive.
  • Check safe path forms, including AbsolutePath.Value, implicit conversions, FileInfo.FullName, DirectoryInfo.FullName, and task-item FullPath metadata.
  • Check null-conditional access and safe path values passed through locals and helper parameters. Verify the actual path semantics before classifying a finding.
  • Check scope boundaries: direct versus inherited MT interfaces, analyzed helpers, contributing base classes, and explicit migration analysis.
  • Check call-chain locations and duplicate reports, including an MT task calling a regular task used as a helper.
  • Verify call-site pragmas, suppression attributes, explicit severity settings, and warnings-as-errors behavior in real consumer builds.
  • Add regression tests for confirmed findings. Keep paired unsafe cases to ensure that fixes do not hide real problems.
  • Fix confirmed findings or create linked implementation issues. Publish a summary of the checked scenarios and remaining limitations.

Scope and non-goals

Focus first on MSBuildTask0002, MSBuildTask0003, MSBuildTask0004, and the current transitive rule MSBuildTask0005. Record findings in other task-analyzer rules when encountered.

Do not resolve false positives through blanket suppression or by lowering every rule's severity.

This issue tracks the check and its results. It does not replace the separate design work to retire MSBuildTask0005.

Dependencies and handoff

Baseline: #14777.

Known reports to include:

Related analyzer follow-up epic: #14772.

Use existing issues for known findings rather than creating duplicate bug reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions