Skip to content

Reduce allocations on AnimationManager - #35612

Merged
kubaflo merged 8 commits into
dotnet:inflight/currentfrom
pictos:pj/reduce-animation-allocations
Jun 1, 2026
Merged

kubaflo merged 8 commits into
dotnet:inflight/currentfrom
pictos:pj/reduce-animation-allocations

Conversation

@pictos

@pictos pictos commented May 25, 2026 •

Copy link
Copy Markdown
Contributor

Description of Change

In order to provide a good reference, I repeated the flow twice and collect the results. With the main, we do have this memory footprint:

image

Those System.Action and DisplayClass allocations are caused by the usage of ForEach method, they fancy but they come with a cost. Since they're inside a loop the compiler couldn't cache them (my theory) which causes a lot of allocations.

To remove all those allocations I rewrite the code using the boring foreach loop. And you can see the memory footprint below:

image

Where the only allocation now is related with the List that is created inside the method and I wasn't able to remove on this PR. I'll let it for the future me or contributors.

Issues Fixed

Fixes #35654

From IA review:

image

The 19 → 26 difference is just sampling noise. GCAllocationTick fires every ~100 KB of allocations, not on every individual allocation. The improved run had 2,017 sampled events vs 2,000 in the baseline (17 more), which means a slightly different sampling window was captured. That's enough to shift counts on any type by a few ticks.

What actually changed:

✅ Action (30 → 0): gone — the ForEach(delegate) no longer creates a delegate on each call
✅ <>c__DisplayClass20_0 (? → 0): the compiler-generated closure class is gone too
➡️ Animation[] (19 → 26): same root cause (new List backing array), just sampling variance

PureWeen and others added 4 commits May 21, 2026 16:04
<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

## What
Restrict the agentic-labeler to apply **exactly one `area-*` label** per
item, while still allowing multiple `platform/*` labels.

## Why
Backfilling the 26 items affected by the `max:1` bug (fixed in dotnet#35540)
revealed that the labeler occasionally applies multiple `area-*` labels
for ambiguous cases:

- **dotnet#35501** got both `area-layout` and `area-safearea`
- **dotnet#35490** got both `area-navigation` and `area-controls-tabbedpage`

The intended behavior is exactly one best-fit `area-*` per item (a
label-quota distinction not expressible via
`safe-outputs.add-labels.max:` — that field counts total labels, not
labels per prefix). The fix has to live in the agent's instructions.

## Changes

### `.github/skills/agentic-labeler/SKILL.md`
- Scope section: "Exactly one `area-*`" / "One or more `platform/*`".
- Area rules section: renamed heading, changed "pick one or more" →
"apply exactly one".
- New **tie-breaking heuristics** for the area-* selection:
- Specific control beats generic area (`area-controls-tabbedpage` over
`area-navigation`)
  - Sub-area beats parent area (`area-safearea` over `area-layout`)
  - Subject-matter focus beats incidental touch
  - When genuinely tied, prefer the user-visible feature
- Mixed-PR rule clarified: infra-primary PRs get only
`area-infrastructure` (no second product area).

### `.github/workflows/agentic-labeler.md`
- Added explicit reinforcement in the workflow prompt: "Apply exactly
one `area-*` label … and one or more `platform/*` labels".
- Fixed two stale `max: 1` comments left over from dotnet#35540 (the cap is
now `max: 10`).

### `.github/workflows/agentic-labeler.lock.yml`
- Regenerated via `gh aw compile`. Diff is frontmatter-hash + heredoc
rotations only — no semantic change to the compiled config.

## Validation
- Reviewed all 21 existing eval scenarios in `tests/eval.yaml` — none
assert multiple `area-*` labels, so no test updates needed.
- The `max: 10` cap in `safe-outputs` is preserved as a blast-radius
safeguard (one area + several platforms still fit comfortably).

## Follow-ups (not in this PR)
If accuracy of the "one area" rule drops below ~95% in eval runs,
consider adding a deterministic post-step that strips extra `area-*`
labels per a known precedence list (Option B from the design
discussion).

Co-authored-by: bot <bot@test>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
## Description

Extends the `maui-copilot` DevDiv pipeline (pipeline 27723) with a
3-stage architecture that runs real UI tests on platform-pool agents and
reports results directly in the AI summary PR comment.

### Pipeline Workflow

```
┌─────────────────────────────────────────────────────────┐
│  Stage 1: ReviewPR                                      │
│                                                         │
│  STEP 1: Branch Setup (checkout + cherry-pick PR)       │
│  STEP 2: Detect UI Test Categories                      │
│  STEP 3: Run Detected UI Tests (in-process, fast)       │
│  STEP 4: Regression Cross-Reference                     │
│  STEP 5: Gate — verify tests fail/pass before/after fix │
│  STEP 6: Code Review — deep analysis via Copilot agent  │
│                                                         │
│  Outputs → CopilotLogs artifact + detectedCategories    │
└──────────────────────┬──────────────────────────────────┘
                       │
┌──────────────────────▼──────────────────────────────────┐
│  Stage 2: RunDeepUITests (platform-pool agent)          │
│                                                         │
│  iOS: AcesShared Tahoe + iOS 26.4                       │
│  Android: ubuntu-22.04 + KVM + AVD                      │
│                                                         │
│  Runs BuildAndRunHostApp.ps1 per detected category      │
│  Outputs → drop-deep-uitests artifact (TRX + diffs)     │
└──────────────────────┬──────────────────────────────────┘
                       │
┌──────────────────────▼──────────────────────────────────┐
│  Stage 3: PostResults                                   │
│                                                         │
│  1. Download CopilotLogs (review content files)         │
│  2. Download drop-deep-uitests (TRX results)            │
│  3. Merge deep results into uitests/content.md          │
│  4. Post full AI Summary comment on PR                  │
│  5. Apply labels (s/agent-reviewed, etc.)               │
│                                                         │
│  One comment with everything — no patching needed       │
└─────────────────────────────────────────────────────────┘
```

### What's New

**Deep UI Test Execution (Stage 2)**
- Runs detected UI test categories on proper platform-pool agents (not
in-process on Linux)
- **iOS**: AcesShared Tahoe agents with iOS 26.4 simulator, iPhone 11
Pro (matching `ios-26` baselines from PR dotnet#35061)
- **Android**: ubuntu-22.04 with KVM, AVD boot with `-partition-size
2048`, `ignoreHiddenApiPolicyError` capability
- TRX results + snapshot-diff PNGs published as `drop-deep-uitests`
artifact

**Unified Comment Posting (Stage 3)**
- Comment posting and label application deferred to Stage 3 (after deep
tests complete)
- Single AI summary comment includes ALL results: code review + deep
test results
- Nested collapsible `<details>` for failed tests with full error +
stack trace
- Dynamic section title: `🧪 UI Tests — CollectionView, TabbedPage`
- Artifact download link for snapshot-diff PNGs

**Android Emulator Improvements**
- AVD boot step with proper partition size, ADB key pre-authorization,
boot wait
- `DEVICE_UDID` pass-through prevents double emulator boot
- Disk cleanup on hosted ubuntu agents (frees ~22GB)
- KVM enablement + `appium:ignoreHiddenApiPolicyError` for API 30

**iOS Simulator Improvements**
- Tahoe pool demand ensures macOS 26.x agents
- Explicit iOS 26.4 download via latest Xcode
- Auto-creates iPhone 11 Pro for baseline resolution match

### Validation

Tested across 30+ pipeline iterations on 6 PRs:

| PR | iOS | Android |
|---|---|---|
| 35358 (ViewBaseTests) | **112/112 ALL PASS** ✅ | **118/119 PASS** ✅ |
| 35359 (TabbedPage) | 44/50 (1 real failure) | 74/75 (1 real failure) |
| 35356 (CollectionView) | **415/417 PASS** ✅ | 593/619 (26 real
failures) |

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…35589)

> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

Backport of dotnet#35460 to `main`.

/cc @PureWeen

Co-authored-by: HarishKumarSF4517 <harish.kumar@syncfusion.com>
@github-actions

github-actions Bot commented May 25, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35612

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35612"

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label May 25, 2026
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo

kubaflo commented May 27, 2026

Copy link
Copy Markdown
Contributor

/review -b feature/refactor-copilot-yml

@MauiBot MauiBot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expert Review — 3 findings

See inline comments for details.

@MauiBot MauiBot added s/agent-fix-win AI found a better alternative fix than the PR s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels May 27, 2026
@pictos
pictos force-pushed the pj/reduce-animation-allocations branch from 300a2cb to 7418c16 Compare May 27, 2026 19:27
@kubaflo

kubaflo commented May 28, 2026

Copy link
Copy Markdown
Contributor

/review -b feature/refactor-copilot-yml

@@ -130,7 +136,13 @@ public void Dispose()
void ForceFinishAnimations()
{
var animations = new List<Animation>(_animations);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the _animations were an immutable object:

-readonly List<Animation> _animations = new();
+ImmutableArray<Animation> _animations = [];

the allocations would move from "iterations" to "modifications" (adding/removing elements). Not sure if possible, perhaps it's worth a try.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion, I'll not do it on this PR. The main goal was to remove the lambdas allocations. Removing the List allocation would be a bonus, but looks like it's needed, all my attempts to remove resulted in IndexOutOfRangeExceptions. To improve would need a deeper look inside the animation engine.

MauiBot

This comment was marked as outdated.

@pictos

pictos commented May 29, 2026

Copy link
Copy Markdown
Contributor Author

@kubaflo this one is ready for review now

### Description of Change


https://github.com/GitOps-microsoft/GitOps.PullRequestIssueManagement/pull/262
(internal Microsoft link) changed the `${issueAuthor}` placeholder to
include the `@` character.

Remove the one we added so we don't duplicate it.

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kubaflo kubaflo changed the title [WiP] Reduce allocations on AnimationManager Reduce allocations on AnimationManager May 29, 2026

@kubaflo kubaflo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the ai's suggestions?

@pictos
pictos force-pushed the pj/reduce-animation-allocations branch from 6ccab60 to cf8a3f0 Compare May 30, 2026 16:21
@kubaflo

kubaflo commented May 30, 2026

Copy link
Copy Markdown
Contributor

/review -b feature/refactor-copilot-yml

MauiBot

This comment was marked as outdated.

@pictos

pictos commented May 30, 2026

Copy link
Copy Markdown
Contributor Author

I don't like the try-fix-1 suggestion, I believe the trade-off isn't worth (use lock to avoid collection copy)

@MauiBot

This comment has been minimized.

@kubaflo
kubaflo dismissed stale reviews from MauiBot, MauiBot, and MauiBot May 31, 2026 14:16

Superseded by a newer MauiBot review run.

@kubaflo kubaflo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI Review Summary

@pictos — new AI review results are available based on this last commit: cf8a3f0.
create array instead of list

Gate Skipped Code Review Needs Changes Confidence Medium Platform Android

Review Sessions — click to expand
Gate — Test Before & After Fix

Gate Result: ⚠️ SKIPPED

No tests were detected in this PR.

Recommendation: Add tests to verify the fix using the write-tests-agent.


UI Tests

Full UI test matrix will run (no specific categories detected from PR changes).


Pre-Flight — Context & Validation

Issue: Unknown - GitHub API unavailable; no linked issue could be fetched
PR: #35612 - Unknown title (local branch: pr-review-35612)
Platforms Affected: android (per prompt); also shared Core animation behavior
Files Changed: 12 implementation/pipeline files, 0 test files

Key Findings

  • GitHub PR metadata/comments could not be fetched because gh is unauthenticated in this environment; analysis used the checked-out PR branch and origin/main...HEAD diff.
  • Functional MAUI change is in src/Core/src/Animations/AnimationManager.cs: replace new List<Animation>(_animations).ForEach(...) with array snapshot + foreach in normal ticks and force-finish path.
  • Gate was already skipped: no tests detected in this PR. Nearby targeted coverage exists in TickerSystemEnabledTests and was used for try-fix regression checks.
  • Expert review found the PR fix is small and plausible but may only mitigate the symptom; _animations remains an unsynchronized mutable list.

Code Review Summary

Verdict: NEEDS_DISCUSSION
Confidence: medium
Errors: 1 | Warnings: 1 | Suggestions: 1

Key code review findings:

  • ❌ No regression test coverage for the mutation/concurrency scenario; gate was skipped.
  • ⚠️ src/Core/src/Animations/AnimationManager.cs: array snapshot avoids List<T>.ForEach checks but does not make _animations access atomic under concurrent mutation.
  • 💡 Minor extra blank line in ForceFinishAnimations in the PR diff.

Fix Candidates

# Source Approach Test Result Files Changed Notes
PR PR #35612 Array snapshot + foreach in AnimationManager ⚠️ Gate skipped src/Core/src/Animations/AnimationManager.cs Original PR; no detected tests

Code Review — Deep Analysis

Code Review — PR #35612

Independent Assessment

What this changes: The functional MAUI change updates AnimationManager to snapshot _animations into an array and iterate with foreach instead of constructing a List<Animation> snapshot and invoking List<T>.ForEach in OnFire and ForceFinishAnimations.

Inferred motivation: Avoid mutation/version-check failures or allocation overhead while animations are removed or force-finished during ticker callbacks, especially around Android animation-disable paths.

Reconciliation with PR Narrative

Author claims: GitHub API access was unavailable in this environment, so PR title/body/comments and linked issue could not be fetched. Local commit history indicates this PR also contains Copilot CI pipeline hardening/refactoring and one functional animation manager change.

Agreement/disagreement: Local code review agrees the array snapshot is a tactical improvement over List<T>.ForEach, but the MAUI expert review found it may not address all concurrent access scenarios for _animations.

Findings

❌ Error — No regression test coverage

Gate was already skipped because no tests were detected in the PR. The animation-manager change has existing nearby coverage in src/Controls/tests/Core.UnitTests/TickerSystemEnabledTests.cs, but the PR does not add a targeted regression for the mutation/concurrency scenario.

⚠️ Warning — Snapshot change may mask, not fix, concurrent list access

src/Core/src/Animations/AnimationManager.cs still uses a mutable List<Animation> without synchronization. Replacing a List<T> snapshot with an array snapshot avoids List<T>.ForEach version checks and reduces overhead, but snapshot construction is still not atomic if _animations is concurrently mutated.

💡 Suggestion — Minor formatting cleanup

The PR version of ForceFinishAnimations contains an extra blank line before End().

Devil's Advocate

The platform-specific Android callbacks likely run on the main thread in normal cases, so the immediate crash may be fully mitigated by avoiding List<T>.ForEach. Existing animation-disable tests pass with multiple alternative approaches. However, the base Ticker uses System.Timers.Timer, and AnimationManager itself does not enforce single-threaded access.

Verdict: NEEDS_DISCUSSION

Confidence: medium
Summary: The PR's functional fix is plausible and small, but it lacks a regression test and may be a symptom-level mitigation rather than a root-cause fix for unsynchronized _animations access. Alternative candidates show a lock-based approach is more robust, while allocation-free approaches pass existing tests but are narrower.


Fix — Analysis & Comparison

Fix Candidates

# Source Approach Test Result Files Changed Notes
1 try-fix Lock-protected _animations list; snapshot under lock and invoke callbacks outside lock ✅ PASS 1 file Most robust; addresses concurrent access window instead of only snapshot iteration
2 try-fix Reverse in-place iteration without snapshot allocation ✅ PASS 1 file Simpler/faster for single-threaded mutation; does not address cross-thread access
3 try-fix Two-phase tick then backward remove ✅ PASS 1 file Clear algorithm but changes cleanup timing and does not address cross-thread access
PR PR #35612 Array snapshot + foreach replacing List<T>.ForEach ⚠️ Gate skipped 1 functional file Small tactical original PR fix; no detected tests

Cross-Pollination

Model Round New Ideas? Details
maui-expert-reviewer 1 Yes Suggested lock, reverse iteration, two-phase remove, and source dispatch/thread-affinity ideas.
maui-expert-reviewer 2 No NO NEW IDEAS. Immutable-array and ticker reentrancy variants were considered not worth implementing because they are either more complex than locking or narrower than Candidate 1.

Exhausted: Yes
Selected Fix: Candidate #1 — Lock-protected animation list. It is larger than the PR's array snapshot but is the only tested candidate that closes the non-atomic snapshot/concurrent mutation window. Candidate #2 and #3 pass the existing regression tests but are not demonstrably better for Android/threading robustness.

Test Summary

All implemented candidates were tested with the targeted existing regression suite:

dotnet test src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj --filter FullyQualifiedName~TickerSystemEnabledTests --verbosity minimal

The first candidate's initial --no-restore run failed because assets were missing; the retry with restore passed. Subsequent candidates used --no-restore and passed.


Report — Final Recommendation

Comparative Candidate Report

Inputs

  • PR: pr — array snapshot plus foreach in AnimationManager.
  • Reviewer-enhanced PR: pr-plus-reviewer — identical to pr; expert review produced no actionable inline findings.
  • try-fix-1: lock-protected _animations list; snapshots are taken under a private lock and callbacks run outside the lock.
  • try-fix-2: reverse in-place iteration without a snapshot.
  • try-fix-3: two-phase tick then cleanup/removal.

Gate verification for the PR was skipped because no tests were detected. The try-fix candidates were evaluated with the targeted existing TickerSystemEnabledTests suite; all three try-fix candidates passed. No candidate failed regression tests, so no candidate is demoted under the failed-regression rule.

Ranking

  1. try-fix-1 — Winner. This is the only tested candidate that addresses the likely Android race at the shared mutable _animations list instead of only changing iteration mechanics. It preserves snapshot callback semantics by copying under lock and invokes animation callbacks outside the lock to avoid deadlocks/reentrant callback hazards.
  2. pr / pr-plus-reviewer. The submitted PR is small, plausible, and low-risk. It preserves existing behavior and improves the snapshot implementation, but it does not make _animations access atomic and had no detected regression tests in the PR. pr-plus-reviewer ties with pr because expert review had no actionable changes.
  3. try-fix-2. Reverse iteration is allocation-efficient and passed the targeted suite, but it changes iteration semantics and still leaves cross-thread access unsynchronized.
  4. try-fix-3. The two-phase algorithm is clear and passed the targeted suite, but it changes same-frame cleanup timing and still does not address concurrent access.

Decision

Select try-fix-1. It has the strongest correctness story for Android because it fixes the shared-list synchronization gap while preserving the PR's snapshot-style callback isolation. The PR fix remains acceptable as a narrow tactical improvement, but it is less complete for the suspected root cause.


Future Action — alternative fix proposed (try-fix-1)

Automated review — alternative fix proposed

The expert-reviewer evaluation compared the PR fix against automatically generated candidates and selected try-fix-1 as the strongest fix.

Why: try-fix-1 won because it passed the targeted regression suite and is the only candidate that addresses the shared _animations concurrency window while preserving snapshot callback semantics. The PR and pr-plus-reviewer are lower-risk but narrower; try-fix-2 and try-fix-3 pass tests but do not address cross-thread access.

Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.

Candidate diff (try-fix-1)
diff --git a/src/Core/src/Animations/AnimationManager.cs b/src/Core/src/Animations/AnimationManager.cs
index 2de13b3294..9bf205ef5d 100644
--- a/src/Core/src/Animations/AnimationManager.cs
+++ b/src/Core/src/Animations/AnimationManager.cs
@@ -7,6 +7,7 @@ namespace Microsoft.Maui.Animations
 	public class AnimationManager : IAnimationManager, IDisposable
 	{
 		readonly List<Animation> _animations = new();
+		readonly object _animationsLock = new();
 		long _lastUpdate;
 		bool _disposedValue;
 
@@ -40,8 +41,12 @@ namespace Microsoft.Maui.Animations
 				return;
 			}
 
-			if (!_animations.Contains(animation))
-				_animations.Add(animation);
+			lock (_animationsLock)
+			{
+				if (!_animations.Contains(animation))
+					_animations.Add(animation);
+			}
+
 			if (!Ticker.IsRunning && AutoStartTicker)
 				Start();
 		}
@@ -49,12 +54,22 @@ namespace Microsoft.Maui.Animations
 		/// <inheritdoc/>
 		public void Remove(Animation animation)
 		{
-			_animations.TryRemove(animation);
+			lock (_animationsLock)
+				_animations.TryRemove(animation);
 
-			if (_animations.Count == 0)
+			if (AnimationsCount == 0)
 				End();
 		}
 
+		int AnimationsCount
+		{
+			get
+			{
+				lock (_animationsLock)
+					return _animations.Count;
+			}
+		}
+
 		void Start()
 		{
 			_lastUpdate = GetCurrentTick();
@@ -84,17 +99,22 @@ namespace Microsoft.Maui.Animations
 			var milliseconds = TimeSpan.FromMilliseconds(now - _lastUpdate).TotalMilliseconds;
 			_lastUpdate = now;
 
-			var animations = new List<Animation>(_animations);
-			animations.ForEach(OnAnimationTick);
+			Animation[] animations;
+			lock (_animationsLock)
+				animations = _animations.ToArray();
+
+			foreach (var animation in animations)
+				OnAnimationTick(animation);
 
-			if (_animations.Count == 0)
+			if (AnimationsCount == 0)
 				End();
 
 			void OnAnimationTick(Animation animation)
 			{
 				if (animation.HasFinished)
 				{
-					_animations.TryRemove(animation);
+					lock (_animationsLock)
+						_animations.TryRemove(animation);
 					animation.RemoveFromParent();
 					return;
 				}
@@ -103,7 +123,8 @@ namespace Microsoft.Maui.Animations
 
 				if (animation.HasFinished)
 				{
-					_animations.TryRemove(animation);
+					lock (_animationsLock)
+						_animations.TryRemove(animation);
 					animation.RemoveFromParent();
 				}
 			}
@@ -129,14 +150,20 @@ namespace Microsoft.Maui.Animations
 
 		void ForceFinishAnimations()
 		{
-			var animations = new List<Animation>(_animations);
-			animations.ForEach(ForceFinish);
+			Animation[] animations;
+			lock (_animationsLock)
+				animations = _animations.ToArray();
+
+			foreach (var animation in animations)
+				ForceFinish(animation);
+
 			End();
 
 			void ForceFinish(Animation animation)
 			{
 				animation.ForceFinish();
-				_animations.TryRemove(animation);
+				lock (_animationsLock)
+					_animations.TryRemove(animation);
 				animation.RemoveFromParent();
 			}
 		}

@albyrock87 albyrock87 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is clearly not thread safe.
Therefore I don't see a reason to copy _animations into a temporary array.

We can simply use our dear old for(var i = 0; i < _animations.Count; i++ and when the internal invocation removes the element, we can simply i--.

This also gives us the opportunity of providing the current i to the action inside the loop so that instead of TryRemove we can remove directly the element at the given index.

Take this AI

@kubaflo

kubaflo commented May 31, 2026

Copy link
Copy Markdown
Contributor

/review -b feature/enhanced-reviewer

@kubaflo
kubaflo changed the base branch from main to inflight/current June 1, 2026 11:45
@kubaflo
kubaflo merged commit 8c69e69 into dotnet:inflight/current Jun 1, 2026
31 checks passed
@github-actions github-actions Bot added this to the .NET 10.0 SR8 milestone Jun 1, 2026
@pictos
pictos deleted the pj/reduce-animation-allocations branch June 2, 2026 11:21
PureWeen pushed a commit that referenced this pull request Jun 2, 2026
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->


### Description of Change

In order to provide a good reference, I repeated the flow twice and
collect the results. With the `main`, we do have this memory footprint:

<img width="1436" height="138" alt="image"
src="https://github.com/user-attachments/assets/f0b57463-7a8f-4767-9f55-301d5696d4bf"
/>


Those `System.Action` and `DisplayClass` allocations are caused by the
usage of `ForEach` method, they fancy but they come with a cost. Since
they're inside a loop the compiler couldn't cache them (my theory) which
causes a lot of allocations.

To remove all those allocations I rewrite the code using the boring
`foreach` loop. And you can see the memory footprint below:

<img width="1440" height="113" alt="image"
src="https://github.com/user-attachments/assets/e9ab701b-29c6-42cc-9e86-906df4cc503e"
/>

Where the only allocation now is related with the `List` that is created
inside the method and I wasn't able to remove on this PR. I'll let it
for the future me or contributors.

### Issues Fixed

<!-- Please make sure that there is a bug logged for the issue being
fixed. The bug should describe the problem and how to reproduce it. -->

Fixes #35654

<!--
Are you targeting main? All PRs should target the main branch unless
otherwise noted.
-->

From IA review:

<img width="658" height="198" alt="image"
src="https://github.com/user-attachments/assets/44b9be3a-c6ee-4ae9-a5d0-2bb5d9bcd603"
/>


The 19 → 26 difference is just sampling noise. GCAllocationTick fires
every ~100 KB of allocations, not on every individual allocation. The
improved run had 2,017 sampled events vs 2,000 in the baseline (17
more), which means a slightly different sampling window was captured.
That's enough to shift counts on any type by a few ticks.

What actually changed:

✅ Action<Animation> (30 → 0): gone — the ForEach(delegate) no longer
creates a delegate on each call
✅ <>c__DisplayClass20_0 (? → 0): the compiler-generated closure class is
gone too
➡️ Animation[] (19 → 26): same root cause (new List<Animation> backing
array), just sampling variance

---------
PureWeen pushed a commit that referenced this pull request Jun 11, 2026
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->


### Description of Change

In order to provide a good reference, I repeated the flow twice and
collect the results. With the `main`, we do have this memory footprint:

<img width="1436" height="138" alt="image"
src="https://github.com/user-attachments/assets/f0b57463-7a8f-4767-9f55-301d5696d4bf"
/>


Those `System.Action` and `DisplayClass` allocations are caused by the
usage of `ForEach` method, they fancy but they come with a cost. Since
they're inside a loop the compiler couldn't cache them (my theory) which
causes a lot of allocations.

To remove all those allocations I rewrite the code using the boring
`foreach` loop. And you can see the memory footprint below:

<img width="1440" height="113" alt="image"
src="https://github.com/user-attachments/assets/e9ab701b-29c6-42cc-9e86-906df4cc503e"
/>

Where the only allocation now is related with the `List` that is created
inside the method and I wasn't able to remove on this PR. I'll let it
for the future me or contributors.

### Issues Fixed

<!-- Please make sure that there is a bug logged for the issue being
fixed. The bug should describe the problem and how to reproduce it. -->

Fixes #35654

<!--
Are you targeting main? All PRs should target the main branch unless
otherwise noted.
-->

From IA review:

<img width="658" height="198" alt="image"
src="https://github.com/user-attachments/assets/44b9be3a-c6ee-4ae9-a5d0-2bb5d9bcd603"
/>


The 19 → 26 difference is just sampling noise. GCAllocationTick fires
every ~100 KB of allocations, not on every individual allocation. The
improved run had 2,017 sampled events vs 2,000 in the baseline (17
more), which means a slightly different sampling window was captured.
That's enough to shift counts on any type by a few ticks.

What actually changed:

✅ Action<Animation> (30 → 0): gone — the ForEach(delegate) no longer
creates a delegate on each call
✅ <>c__DisplayClass20_0 (? → 0): the compiler-generated closure class is
gone too
➡️ Animation[] (19 → 26): same root cause (new List<Animation> backing
array), just sampling variance

---------
@sheiksyedm sheiksyedm modified the milestones: .NET 10 SR8, .NET 10 SR9 Jun 18, 2026
PureWeen pushed a commit that referenced this pull request Jun 22, 2026
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->


### Description of Change

In order to provide a good reference, I repeated the flow twice and
collect the results. With the `main`, we do have this memory footprint:

<img width="1436" height="138" alt="image"
src="https://github.com/user-attachments/assets/f0b57463-7a8f-4767-9f55-301d5696d4bf"
/>


Those `System.Action` and `DisplayClass` allocations are caused by the
usage of `ForEach` method, they fancy but they come with a cost. Since
they're inside a loop the compiler couldn't cache them (my theory) which
causes a lot of allocations.

To remove all those allocations I rewrite the code using the boring
`foreach` loop. And you can see the memory footprint below:

<img width="1440" height="113" alt="image"
src="https://github.com/user-attachments/assets/e9ab701b-29c6-42cc-9e86-906df4cc503e"
/>

Where the only allocation now is related with the `List` that is created
inside the method and I wasn't able to remove on this PR. I'll let it
for the future me or contributors.

### Issues Fixed

<!-- Please make sure that there is a bug logged for the issue being
fixed. The bug should describe the problem and how to reproduce it. -->

Fixes #35654

<!--
Are you targeting main? All PRs should target the main branch unless
otherwise noted.
-->

From IA review:

<img width="658" height="198" alt="image"
src="https://github.com/user-attachments/assets/44b9be3a-c6ee-4ae9-a5d0-2bb5d9bcd603"
/>


The 19 → 26 difference is just sampling noise. GCAllocationTick fires
every ~100 KB of allocations, not on every individual allocation. The
improved run had 2,017 sampled events vs 2,000 in the baseline (17
more), which means a slightly different sampling window was captured.
That's enough to shift counts on any type by a few ticks.

What actually changed:

✅ Action<Animation> (30 → 0): gone — the ForEach(delegate) no longer
creates a delegate on each call
✅ <>c__DisplayClass20_0 (? → 0): the compiler-generated closure class is
gone too
➡️ Animation[] (19 → 26): same root cause (new List<Animation> backing
array), just sampling variance

---------
kubaflo pushed a commit that referenced this pull request Jun 25, 2026
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->


### Description of Change

In order to provide a good reference, I repeated the flow twice and
collect the results. With the `main`, we do have this memory footprint:

<img width="1436" height="138" alt="image"
src="https://github.com/user-attachments/assets/f0b57463-7a8f-4767-9f55-301d5696d4bf"
/>


Those `System.Action` and `DisplayClass` allocations are caused by the
usage of `ForEach` method, they fancy but they come with a cost. Since
they're inside a loop the compiler couldn't cache them (my theory) which
causes a lot of allocations.

To remove all those allocations I rewrite the code using the boring
`foreach` loop. And you can see the memory footprint below:

<img width="1440" height="113" alt="image"
src="https://github.com/user-attachments/assets/e9ab701b-29c6-42cc-9e86-906df4cc503e"
/>

Where the only allocation now is related with the `List` that is created
inside the method and I wasn't able to remove on this PR. I'll let it
for the future me or contributors.

### Issues Fixed

<!-- Please make sure that there is a bug logged for the issue being
fixed. The bug should describe the problem and how to reproduce it. -->

Fixes #35654

<!--
Are you targeting main? All PRs should target the main branch unless
otherwise noted.
-->

From IA review:

<img width="658" height="198" alt="image"
src="https://github.com/user-attachments/assets/44b9be3a-c6ee-4ae9-a5d0-2bb5d9bcd603"
/>


The 19 → 26 difference is just sampling noise. GCAllocationTick fires
every ~100 KB of allocations, not on every individual allocation. The
improved run had 2,017 sampled events vs 2,000 in the baseline (17
more), which means a slightly different sampling window was captured.
That's enough to shift counts on any type by a few ticks.

What actually changed:

✅ Action<Animation> (30 → 0): gone — the ForEach(delegate) no longer
creates a delegate on each call
✅ <>c__DisplayClass20_0 (? → 0): the compiler-generated closure class is
gone too
➡️ Animation[] (19 → 26): same root cause (new List<Animation> backing
array), just sampling variance

---------
kubaflo pushed a commit that referenced this pull request Jul 3, 2026
<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->


### Description of Change

In order to provide a good reference, I repeated the flow twice and
collect the results. With the `main`, we do have this memory footprint:

<img width="1436" height="138" alt="image"
src="https://github.com/user-attachments/assets/f0b57463-7a8f-4767-9f55-301d5696d4bf"
/>


Those `System.Action` and `DisplayClass` allocations are caused by the
usage of `ForEach` method, they fancy but they come with a cost. Since
they're inside a loop the compiler couldn't cache them (my theory) which
causes a lot of allocations.

To remove all those allocations I rewrite the code using the boring
`foreach` loop. And you can see the memory footprint below:

<img width="1440" height="113" alt="image"
src="https://github.com/user-attachments/assets/e9ab701b-29c6-42cc-9e86-906df4cc503e"
/>

Where the only allocation now is related with the `List` that is created
inside the method and I wasn't able to remove on this PR. I'll let it
for the future me or contributors.

### Issues Fixed

<!-- Please make sure that there is a bug logged for the issue being
fixed. The bug should describe the problem and how to reproduce it. -->

Fixes #35654

<!--
Are you targeting main? All PRs should target the main branch unless
otherwise noted.
-->

From IA review:

<img width="658" height="198" alt="image"
src="https://github.com/user-attachments/assets/44b9be3a-c6ee-4ae9-a5d0-2bb5d9bcd603"
/>


The 19 → 26 difference is just sampling noise. GCAllocationTick fires
every ~100 KB of allocations, not on every individual allocation. The
improved run had 2,017 sampled events vs 2,000 in the baseline (17
more), which means a slightly different sampling window was captured.
That's enough to shift counts on any type by a few ticks.

What actually changed:

✅ Action<Animation> (30 → 0): gone — the ForEach(delegate) no longer
creates a delegate on each call
✅ <>c__DisplayClass20_0 (? → 0): the compiler-generated closure class is
gone too
➡️ Animation[] (19 → 26): same root cause (new List<Animation> backing
array), just sampling variance

---------
@PureWeen PureWeen mentioned this pull request Jul 6, 2026
PureWeen added a commit that referenced this pull request Jul 6, 2026
## What's Coming

.NET MAUI inflight/candidate introduces significant improvements across
all platforms with focus on quality, performance, and developer
experience. This release includes 153 commits with various improvements,
bug fixes, and enhancements.


## Activityindicator
- [Android] Fix CollectionView ActivityIndicator not animating after
header height change by @Vignesh-SF3580 in
#35358
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView items fail to update ActivityIndicator state after
header height change](#33780)
  </details>

## Animation
- [Android] Fix Shadow property affecting transform matrix. by
@Shalini-Ashokan in #32962
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Applying Shadow property affects the properties in Visual
Transform Matrix](#32731)
  </details>

## API
- Add delegate-based alert dialog extensibility convention (no public
API changes) by @Redth in #35095
  <details>
  <summary>🔧 Fixes</summary>

- [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`,
`DisplayPromptAsync`) needs a public extensibility
point](#34104)
  </details>

## Blazor
- [Android] Fix for BlazorWebView predictive back callback blocks
Android back-to-home animation by @BagavathiPerumal in
#35538
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] BlazorWebView predictive back callback blocks Android
back-to-home animation](#35397)
  </details>

- [Android] Fix BlazorWebView back callback can swallow the first Back
press when its callback is stale-enabled by @devanathan-vaithiyanathan
in #35611
  <details>
  <summary>🔧 Fixes</summary>

- [[inflight regression] Android BlazorWebView back callback can swallow
the first Back press when its callback is
stale-enabled](#35573)
  </details>

## Border
- [Windows] Fixed the ContentView clip is not updated when wrapping
inside the Border by @Ahamed-Ali in
#30408
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] ContentView clip is not updated when wrapping inside the
Border](#30404)
  </details>

- Fix Border.StrokeDashArray leaks dashed Borders when using a shared
Application resource by @devanathan-vaithiyanathan in
#35544
  <details>
  <summary>🔧 Fixes</summary>

- [`Border.StrokeDashArray` leaks dashed Borders when using a shared
Application resource](#35492)
  </details>

- [Windows] Border: Add AutomationPeer support by @Vignesh-SF3580 in
#35577
  <details>
  <summary>🔧 Fixes</summary>

- [Adding AutomationPeers to Windows
Borders](#27627)
  </details>

- [Windows] Fixed BoxView improper rendering inside Border by
@Dhivya-SF4094 in #28465
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Issues with BoxView Placement Inside
Border](#19668)
  </details>

## Button
- Prevent NullReferenceException in LayoutButton by @GamesAgeddon in
#35284
  <details>
  <summary>🔧 Fixes</summary>

- [NullReferenceException on iOS in Button.LayoutButton from
WrapperView.LayoutSubviews](#31048)
  </details>

- Fix TextColor null reset to restore platform defaults on iOS and
Android by @Shalini-Ashokan in #35563
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Android, iOS & Mac]Button TextColor does not restore to
platform default when reset to null after dynamic
update](#35513)
  </details>

## CollectionView
- Fix CollectionView grid spacing updates for first row and column by
@KarthikRajaKalaimani in #34527
  <details>
  <summary>🔧 Fixes</summary>

- [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item
Spacing - horizontally updating the spacing only applies to the second
column](#34257)
  </details>

- [MacCatalyst] Fix CollectionView Header/Footer Not Expanding to
Content Width by @KarthikRajaKalaimani in
#35213
  <details>
  <summary>🔧 Fixes</summary>

- [[MacOS][CV2] I8_View header and footer_Horizontal_View - Footer on
the right doesn't adapt when resizing the
window](#35113)
  </details>

- [iOS/MacCatalyst] Fix IndicatorView not updating when IndicatorSize is
changed to default value by @Shalini-Ashokan in
#35215
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS/MacCatalyst] IndicatorView does not update when IndicatorSize is
dynamically changed to the default
value](#35214)
  </details>

- CollectionView selecteditem background lost if collectionview (or
parent) IsEnabled changed. by @KarthikRajaKalaimani in
#31540
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView selecteditem background lost if collectionview (or
parent) IsEnabled changed.](#20615)
  </details>

- [iOS/macOS] CollectionView: Fix FlowDirection not working on EmptyView
by @Dhivya-SF4094 in #32674
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, MacOS] FlowDirection not working on EmptyView in
CollectionView](#32404)
- [[iOS, Mac] CollectionView EmptyViewTemplate content text is mirrored
when FlowDirection is
RightToLeft](#34522)
  </details>

- Fix iOS CollectionView stale layout invalidations by @filipnavara in
#35245
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] CollectionView tries to invalidate cells with invalid
indexes](#35244)
  </details>

- Fix Android grouped CollectionView header/footer rebind leak by
@AdamEssenmacher in #35368
  <details>
  <summary>🔧 Fixes</summary>

- [Memory leak when scrolling a CollectionView with
IsGrouped=true](#17698)
  </details>

- [Windows] Fix for Item should scrolled based on the
GroupHeaderTemplate by @SuthiYuvaraj in
#28074
  <details>
  <summary>🔧 Fixes</summary>

- [I9_Scroll by object for grouped data - The group name is always pined
at the top after clicking 'Scroll to Proboscis Monkey'
button](#27922)
  </details>

- [Android] Fix ScrollTo regression when IsGrouped true on
CollectionView by @SubhikshaSf4851 in
#35356
  <details>
  <summary>🔧 Fixes</summary>

- [[10.0.60] ScrollTo(0) not working anymore on CollectionView when
IsGrouped="True"](#35313)
  </details>

- [Android] Fix CollectionView scrolling performance regression by
@devanathan-vaithiyanathan in #35379
  <details>
  <summary>🔧 Fixes</summary>

- [[10.0.60] CollectionView scrolling performance
regression](#35344)
  </details>

- Optimize parent dynamic resource refresh by @AdamEssenmacher in
#35408
  <details>
  <summary>🔧 Fixes</summary>

- [Memory usage increases when scrolling collectionview if resources
count is more than 191](#22053)
  </details>

- Fix CI failure for CollectionView Scrolling Feature Tests due to PR
#35379 by @devanathan-vaithiyanathan in
#35536

- [iOS & Mac] CarouselViewController2 leaks on iOS/MacCatalyst due to
unremoved orientation notification observer by @SubhikshaSf4851 in
#35532
  <details>
  <summary>🔧 Fixes</summary>

- [CarouselViewController2 leaks on iOS/MacCatalyst due to unremoved
orientation notification
observer](#35472)
  </details>

- Fix CollectionView.SelectedItems leaks popped views when bound to a
retained ObservableCollection by @HarishwaranVijayakumar in
#35558
  <details>
  <summary>🔧 Fixes</summary>

- [`CollectionView.SelectedItems` leaks popped views when bound to a
retained
`ObservableCollection`](#35497)
  </details>

- Fix for Android - Dynamic Updates to CollectionView Header/Footer and
Templates Are Not Displayed by @SuthiYuvaraj in
#28904
  <details>
  <summary>🔧 Fixes</summary>

- [Android - Dynamic Updates to CollectionView Header/Footer and
Templates Are Not
Displayed](#28676)
  </details>

- [Windows] Fix CarouselView EmptyView display when filtering to zero
items by @Shalini-Ashokan in #29247
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] [Scenario Day] EmptyView using Template displayed at the
same time as the content](#7150)
  </details>

- [Android/iOS] Fix IsEnabled=False on CollectionView not working by
@devanathan-vaithiyanathan in #27749
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS/Android] CollectionView IsEnabled Not
Working](#27770)
  </details>

- Fix CarouselView.Loop property does not update dynamically and fails
to maintain the scroll position when the loop value is changed at
runtime by @devanathan-vaithiyanathan in
#29527
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] CarouselView.Loop = false causes crash on Android when
changed at runtime](#29411)
- [Loop Binding in CarouselView Not Updating Dynamically at
Runtime](#29449)
  </details>

- [iOS / Mac] Fix CollectionView.ScrollTo(index) silently failing
whenIsGrouped="True" by @Dhivya-SF4094 in
#35609
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView.ScrollTo(index) doesn't work correctly when
IsGrouped="True" on iOS, MacCatalyst, and
Windows](#35326)
  </details>

- Fix Android nested carousel scrolling by @AdamEssenmacher in
#35656
  <details>
  <summary>🔧 Fixes</summary>

- [Vertical scrolling not working for CarouselView and
CustomLayouts](#7814)
  </details>

- [Inflight regression] Fixed Test failures
ModalTabbedPagePushAsyncShouldOverlayBottomNavigationView and
GroupedCollectionViewScrollToIndexScrollsToCorrectItem by @Dhivya-SF4094
in #35823

- Fix CarouselView tests fail in June 8 Candidate by
@devanathan-vaithiyanathan in #35825

## Core
- Reduce allocations on AnimationManager by @pictos in
#35612
  <details>
  <summary>🔧 Fixes</summary>

- [AnimationManager is allocating a
lot](#35654)
  </details>

## Core Lifecycle
- Fix device test memory by @pictos in
#35487
  <details>
  <summary>🔧 Fixes</summary>

- [Memory leak Device.Test pass with false
positive](#35485)
  </details>

## Datepicker
- Fix MacCatalyst DatePicker focus handling by @AdamEssenmacher in
#35553
  <details>
  <summary>🔧 Fixes</summary>

- [[mauipalooza] DatePicker focus only works first
time](#5947)
  </details>

## DateTimePicker
- [Android] Fix DatePicker dialog dismisses after the device is rotated
by @HarishwaranVijayakumar in #34980
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] [Regression] DatePicker dialog dismisses after the device
is rotated](#34973)
  </details>

## Docs
- doc: Add paragraph to README.md explaining how to fetch the `maui`
project templates by @durandt in
#34561

## Drawing
- [Android] Fix LinearGradientBrush rendering as opaque black box by
@SubhikshaSf4851 in #35299
  <details>
  <summary>🔧 Fixes</summary>

- [[Regression] LinearGradientBrush broken on Android in
10.0.60](#35280)
- [10.0.60 breaks transparency on Brushes (on
Android?)](#35354)
  </details>

- Fix polygon points collection handler leak by @AdamEssenmacher in
#35526
  <details>
  <summary>🔧 Fixes</summary>

- [PolygonHandler and PolylineHandler leak when Points is replaced
before disconnect](#35387)
  </details>

## Editor
- [iOS] Fix Editor losing scrollability after rotation when
CharacterSpacing is applied by @Vignesh-SF3580 in
#35309
  <details>
  <summary>🔧 Fixes</summary>

- [[.NET 10][iOS] D2 - Editor can't be scrolled after rotating
simulator.](#35114)
  </details>

- [Inflight/Candidate][iOS & Mac] Fix for Editor height inconsistency
when VerticalTextAlignment is Center or End on iOS and MacCatalyst by
@BagavathiPerumal in #35662
  <details>
  <summary>🔧 Fixes</summary>

- [[MAUI] D13_Customize_Text_Alignment - Text Editor Height is not
consistent](#35615)
  </details>

## Entry
- [iOS/Mac] Fix Entry clear button retaining tint color after TextColor
is reset to null by @SyedAbdulAzeemSF4852 in
#35177
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS/Mac]Entry ClearButtonVisibility color does not reset when
TextColor is set to null](#35076)
  </details>

- [iOS/MacCatalyst] Fix Entry clear button appearing dimmed compared to
TextColor by @SyedAbdulAzeemSF4852 in
#35541
  <details>
  <summary>🔧 Fixes</summary>

- [[MacCatalyst] [Entry] ClearButtonVisibility color appears dimmed
compared to TextColor](#35517)
  </details>

- Fix pill-shaped focus ring on macOS 26 by @Dhivya-SF4094 in
#35393
  <details>
  <summary>🔧 Fixes</summary>

- [.Net 10 Picker item not centered and wrong focus outline of Entry on
Mac](#34899)
  </details>

- Fix Entry select all text on refocus not working on WinUI by @kubaflo
in #35383

## Essentials
- [Android] Fix Capture video crashes after stopping recording on
Android 12 by @HarishwaranVijayakumar in
#35638
  <details>
  <summary>🔧 Fixes</summary>

- [Capture video crashes after stopping recording on Android
12](#28891)
  </details>

- [Essentials] Browser.OpenAsync(External): drop visibility-filtered
ResolveActivity pre-check by @Kebechet in
#35652
  <details>
  <summary>🔧 Fixes</summary>

- [Browser.OpenAsync(External) on Android throws
FeatureNotSupportedException for verified App Link owner URLs even with
documented <queries> fix
applied](#35651)
  </details>

## Essentials Texttospeech
- [Mac, iOS, Windows] Fix for inconsistent Text-to-Speech rate behavior
by @HarishwaranVijayakumar in #32850
  <details>
  <summary>🔧 Fixes</summary>

  - [[Essentials] TTS rate](#32492)
  </details>

## Flyoutpage
- [iOS/Mac] Fix FlyoutPage RTL FlowDirection is not working by
@devanathan-vaithiyanathan in #34831
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS/Mac] FlyoutPage RTL FlowDirection is not working
properly](#34830)
  </details>

- [Android] Fix for Android 16 Back button is not working after command
from FlyoutPage by @BagavathiPerumal in
#35196
  <details>
  <summary>🔧 Fixes</summary>

- [Android: BackButton on Android 16 not working after command from
FlyOutPage](#33508)
  </details>

## Gestures
- Fix DragGestureRecognizer.DropCompleted event not firing in Android
platform by @KarthikRajaKalaimani in
#35179
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] DragGestureRecognizer.DropCompleted event not
firing](#17554)
  </details>

- Windows: Ensure layouts without background participate in hit testing
by @jpd21122012 in #34364
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] TapGestureRecognizer does NOT work on a ContentView without
Background](#32279)
  </details>

- [iOS] Fix VoiceOver dropping child labels on layouts with
SemanticProperties.Hint or TapGestureRecognizer by @Vignesh-SF3580 in
#35590
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] VoiceOver does not correctly describe View with
GestureRecognizers](#34380)
  </details>

## Hybridwebview
- Fix RemovePossibleQueryString to also strip URL fragments by @kubaflo
in #35551
  <details>
  <summary>🔧 Fixes</summary>

- [HybridWebViewQueryStringHelper.RemovePossibleQueryString removes '?'
but not other special characters e.g.
'#'](#31472)
  </details>

- [Revert] - [Windows] Fix WebView blank rendering when used with
HybridWebView by @SubhikshaSf4851 in
#35814

## Image
- Avoid image source layout invalidation for fixed-size views by
@AdamEssenmacher in #35369
  <details>
  <summary>🔧 Fixes</summary>

- [Image source swaps thrash layout under fixed constraints, tanking
frame rate when scrolling virtualized
collections](#32457)
  </details>

- [Windows] Fix Image layout inconsistency caused by async decode race
in GetDesiredSize by @praveenkumarkarunanithi in
#34699
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Image cropping produces inconsistent results when window is
minimized or resized](#32393)
  </details>

- [Testing] Include more testing around Windows Image Aspect recent
fixes by @kubaflo in #35620
  <details>
  <summary>🔧 Fixes</summary>

- [[Testing] Include more testing around Windows Image Aspect recent
fixes](#31686)
  </details>

- Revert PR #30068 — Fix FontImageSource centering regression on Windows
by @Shalini-Ashokan in #35642
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Image with FontImageSource is not centered and gets clipped
when WidthRequest/HeightRequest equals FontImageSource
Size](#35618)
  </details>

- [Android] Fix screenshot from WebView content not working by @kubaflo
in #35384
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Loading the captured screenshot from webview content to
Image control does not
visible](#30010)
  </details>

## Label
- Improve label mapping performance and ensure complete coverage
including ToPlatform and subsequent property changes by
@Tamilarasan-Paranthaman in #31159

- Fix for Label.FormattedText leaks labels when shared FormattedString
is stored in Application.Resources by @BagavathiPerumal in
#35582
  <details>
  <summary>🔧 Fixes</summary>

- [`Label.FormattedText` leaks labels when shared `FormattedString` is
stored in
`Application.Resources`](#35495)
  </details>

- [iOS] Fix Label Span formatting test failures on candidate branch by
@Vignesh-SF3580 in #35815

## Layout
- [iOS, Mac] Fix Item spacing not properly applied between items in
Horizontal LinearItemsLayout by @Dhivya-SF4094 in
#35445
  <details>
  <summary>🔧 Fixes</summary>

- [[CollectionView2] Item spacing not properly applied between items in
Horizontal
LinearItemsLayout](#35429)
  </details>

- [Windows] Add Automation Id support for Layouts. by @SubhikshaSf4851
in #35562
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] AutomationId does not work for ContentView, Layouts and
controls that inherit them](#4715)
  </details>

- Avoid layout diagnostics allocations without listeners by
@AdamEssenmacher in #35475
  <details>
  <summary>🔧 Fixes</summary>

- [MAUI 10 layout diagnostics no-consumer path is not
zero-allocation](#35473)
  </details>

- [Windows/Android] FlexLayout: Fix wrap misalignment due to
floating-point precision by @SuthiYuvaraj in
#31341
  <details>
  <summary>🔧 Fixes</summary>

- [FlexLayout Wrap Misalignment with Dynamically-Sized Buttons in .NET
MAUI](#30957)
  </details>

## Listview
- Fix Binding for ListView.IsRefreshing by @bill2004158 in
#28516
  <details>
  <summary>🔧 Fixes</summary>

- [Bind ListView.IsRefreshing is not
work.](#28514)
  </details>

## Map
- Fix iOS/Catalyst MapPool retention with MapElements by
@AdamEssenmacher in #35480
  <details>
  <summary>🔧 Fixes</summary>

- [iOS/Mac Catalyst MapHandler leaks MAUI Map views and MapElements
through MapPool](#35479)
  </details>

- Fix Android map view lifecycle cleanup by @AdamEssenmacher in
#35476
  <details>
  <summary>🔧 Fixes</summary>

- [Navigating to a page with Maps multiple times Increase RAM Usage but
doesn't reduce it back after navigating
back](#15257)
  </details>

- Fix Android map element options retention by @AdamEssenmacher in
#35634
  <details>
  <summary>🔧 Fixes</summary>

- [[Regression] [Android] [Maps] Map locks up after rendering 50
Polylines](#20502)
  </details>

## Menubar
- [MacCatalyst] Fix KeyboardAccelerator with Cmd+Shift modifiers breaks
entire MenuBarItem on Mac Catalyst by @KarthikRajaKalaimani in
#35318
  <details>
  <summary>🔧 Fixes</summary>

- [[Bug] KeyboardAccelerator with Cmd+Shift modifiers breaks entire
MenuBarItem on Mac
Catalyst](#35279)
  </details>

## Navigation
- [iOS, Mac] Fix OnBackButtonPressed not invoked for NavigationPage and
Shell by @Dhivya-SF4094 in #35072
  <details>
  <summary>🔧 Fixes</summary>

- [On Screen Back Button Does Not Fire OnBackButtonPressed in
Android](#9095)
- [ContentPage's OnBackButtonPressed not invoked on iOS and
MacCatalyst](#8296)
  </details>

- Fix Android stale ContainerView root leak by @AdamEssenmacher in
#35372
  <details>
  <summary>🔧 Fixes</summary>

- [Android: Stale ContainerView retains replaced FlyoutPage
graph](#35371)
  </details>

- [Android] Fix for predictive back-to-home animation blocked by
unconditional back callback registration by @BagavathiPerumal in
#35223
  <details>
  <summary>🔧 Fixes</summary>

- [OnBackInvokedCallbacks block back-to-home
animation](#34594)
- [Migrate to
OnBackPressedCallback](#24752)
  </details>

- Revert [Android, iOS] - Flyout icon should remain visible when a page
is pushed onto a NavigationPage or Shell page with the back button
disabled. by @praveenkumarkarunanithi in
#35604

## Picker
- [iOS] Fix Picker CharacterSpacing lost after item selection when Title
is set by @SyedAbdulAzeemSF4852 in
#34974
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Picker loses CharacterSpacing after item selection when Title
is set](#34971)
  </details>

- [iOS] Fix Picker CharacterSpacing ignored on initial load by
@SyedAbdulAzeemSF4852 in #34957
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Picker ignores CharacterSpacing on initial
load](#34955)
  </details>

- [Windows] Fix for Picker CharacterSpacing Not Being Applied to Title
and Dropdown Items by @SyedAbdulAzeemSF4852 in
#30612
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Picker CharacterSpacing property not applied to Title and
PickerItems text](#30464)
  </details>

- Fix Picker SelectedIndex deferred initialization by @AdamEssenmacher
in #35629
  <details>
  <summary>🔧 Fixes</summary>

- [Picker Attribute "SelectedIndex" Not being respected on page load on
Android?](#9150)
  </details>

## Progressbar
- Fix iOS ProgressBar bounding box by @AdamEssenmacher in
#35507
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] ProgressBar and Label don't correctly obey height and width at
the core level](#7935)
  </details>

## RadioButton
- [Windows, Android] Fix Border Color and Border Width Not applying for
Radio Button by @HarishwaranVijayakumar in
#35616
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Android] Border Color and Border Width Not applying for
Radio Button.](#35587)
  </details>

- [inflight/current] Fixes a CS0111 build failure in RadioButton.cs
caused by a duplicate OnPropertyChanged override by
@HarishwaranVijayakumar in #35631

- Revert - Fix TalkBack not correctly narrating RadioButtons with
Content by @devanathan-vaithiyanathan in
#35625
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] MissingMethodException
AccessibilityNodeInfoCompat.set_Checked(bool) on 10.0.70 due to
AndroidX.Core 1.17 breaking
change](#35584)
  </details>

## Refreshview
- [Windows] Fix RefreshView IsRefreshing property not working while
binding by @devanathan-vaithiyanathan in
#34845
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] RefreshView IsRefreshing property not working while
binding](#30535)
  </details>

- [Android] Fix for RefreshView triggering pull-to-refresh when
scrolling inside a WebView with internal scrollable content by
@BagavathiPerumal in #34614
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] RefreshView triggers pull-to-refresh immediately when
scrolling up inside a
WebView](#33510)
  </details>

## SafeArea
- [Android] Fix bottom safe area padding dropping to zero when keyboard
is shown by @praveenkumarkarunanithi in
#35084
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Bottom insets issues when keyboard is
shown.](#32871)
  </details>

- Gate SafeArea inset listeners in recycler items by @AdamEssenmacher in
#35664
  <details>
  <summary>🔧 Fixes</summary>

- [[10.0.60] CollectionView scrolling performance
regression](#35344)
  </details>

## ScrollView
- [Windows] Fix COMException when restoring a ScrollView as
ContentPage.Content after swapping it out by @Vignesh-SF3580 in
#35360
  <details>
  <summary>🔧 Fixes</summary>

- [COMException when clone a page's content to a object and set it back
later in mainthread on
Windows](#35277)
  </details>

- Fix - ScrollView.ScrollToAsync(x, y, animated) doesn't work when
called from Page.OnAppearing by @Shalini-Ashokan in
#35395
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] ScrollView.ScrollToAsync(x, y, animated) doesn't work when
called from
Page.OnAppearing](#31177)
  </details>

## Searchbar
- [Android] Fix SearchBar IME full-screen extract mode in landscape
orientation by @SubhikshaSf4851 in
#35197
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Investigate SearchBar presentation in horizontal screen
orientation ](#14708)
  </details>

- [iOS 26] Fix SearchBar layout spacing issues for small HeightRequest
values by @devanathan-vaithiyanathan in
#35347
  <details>
  <summary>🔧 Fixes</summary>

- [Spacing problem with maui 10.0.60
iOS](#35286)
  </details>

## SearchBar
- [Windows] Fix SearchHandler does not focus when ShowSoftInputAsync is
called by @praveenkumarkarunanithi in
#35079
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] SearchHandler.ShowSoftInputAsync() does not focus the
SearchHandler](#34930)
  </details>

## Shell
- Fix Android layout jump when navigating with IME open and
NavBarIsVisible=false by @jpd21122012 in
#34621
  <details>
  <summary>🔧 Fixes</summary>

- [Shell page without NavBar jumping when navigating with keyboard
open](#34584)
  </details>

- [Android] Add defensive not null check to
SearchHandlerAppearanceTracker.FocusChange by @Transis-Felipe in
#29939

- [Android] Fix for Shell colors change before navigation completes on
Android in .NET 10 by @BagavathiPerumal in
#35295
  <details>
  <summary>🔧 Fixes</summary>

- [Shell colors change before navigation completes on Android in .NET
10](#35060)
  </details>

- [Windows] Fix Shell FlyoutItem not taking full width by
@SubhikshaSf4851 in #35131
  <details>
  <summary>🔧 Fixes</summary>

- [MAUI WinUI Grids don't render properly in flyout
menu](#19542)
- [[Windows] [.NET 8 RC2] FlyoutItem Backgroundcolor Is not fully
displaying](#18238)
  </details>

- [Android, iOS, Catalyst] Fix SearchHandler.BackgroundColor cannot be
reset to null by @HarishwaranVijayakumar in
#35224
  <details>
  <summary>🔧 Fixes</summary>

- [[Android, iOS, Catalyst] SearchHandler.BackgroundColor cannot be
reset to null](#35088)
  </details>

- Fix for ApplyQueryAttributes being called on non-destination pages
during back navigation by @BagavathiPerumal in
#35392
  <details>
  <summary>🔧 Fixes</summary>

- [ApplyQueryAttributes gets called for not activated (navigated to)
page on back](#35183)
  </details>

- [Android] Fix Shell flyout background to follow Material 3 theme
colors by @SyedAbdulAzeemSF4852 in
#35148
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Shell Flyout ignores Material 3 surface color when
UseMaterial3 is enabled](#35147)
  </details>

- [Android] Fix Shell.FlyoutHeader background incorrect by
@SyedAbdulAzeemSF4852 in #35489
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Shell.FlyoutHeader background is
incorrect](#35416)
  </details>

- [iOS/MacCatalyst] Fix Shell.BackgroundColor not applied to bottom
TabBar by @Shalini-Ashokan in #35545
  <details>
  <summary>🔧 Fixes</summary>

- [[MacCatalyst] Shell.BackgroundColor not applied to bottom
TabBar](#35380)
- [[Catalyst] Shell.TabBarBackgroundColor is not
applied](#35381)
  </details>

- [Android] Fix Shell FlyoutIcon tint loss after navigation by
@SyedAbdulAzeemSF4852 in #35561
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] The flyout icon loses
colours](#35390)
  </details>

- [iOS] Fix Shell - opened keyboard on modal page shifts parent
page/frame behind modal after update to 10.0.60 by @KarthikRajaKalaimani
in #35559
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Shell - opened keyboard on modal page shifts parent page/frame
behind modal after update to
10.0.60](#35401)
  </details>

- Fix intermediate pages not receiving query parameters in multi-page
Shell navigation by @mattleibow in
#35432
  <details>
  <summary>🔧 Fixes</summary>

- [Shell GoToAsync: no way to pass query parameters to intermediate
pages in multi-segment
navigation](#35107)
  </details>

- [Windows] Fix Shell title bar overlap with window controls in RTL mode
by @Shalini-Ashokan in #33109
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Binding RTL FlowDirection in Shell causes Flyout MenuIcon
and native window controls to
overlap](#32476)
  </details>

- [macOS] Fix IsEnabled property false not working on MenuBarItem by
@devanathan-vaithiyanathan in #35546
  <details>
  <summary>🔧 Fixes</summary>

- [[macOS] IsEnabled property false not working on
MenuBarItem](#34038)
  </details>

- Fix Android Shell top inset when nav bar is hidden by @ne0rrmatrix in
#35555
  <details>
  <summary>🔧 Fixes</summary>

- [wrong statusbar height when Android device has a
notch](#35103)
  </details>

- Fix Changing Content property of ShellContent doesn't change visual
content by @devanathan-vaithiyanathan in
#34630
  <details>
  <summary>🔧 Fixes</summary>

- [Changing Content property of ShellContent doesn't change visual
content. ](#12669)
  </details>

- Fixed a NullReferenceException when starting application with empty
shell on Windows by @Shalini-Ashokan in
#28879
  <details>
  <summary>🔧 Fixes</summary>

- [NullReferenceException when starting application with empty shell on
Windows](#21562)
- [Using SelectionChangedCommand with CollectionView in
Shell.FlyoutContent results in Win32 Unhandled
Exception](#10041)
  </details>

## Slider
- [iOS] Slider: Scale ThumbImageSource to match default thumb size by
@NirmalKumarYuvaraj in #34184
  <details>
  <summary>🔧 Fixes</summary>

- [[Slider] MAUI Slider thumb image is big on
android](#13258)
  </details>

## Stepper
- Fix iOS 26 Stepper overlap in landscape by @AdamEssenmacher in
#35374
  <details>
  <summary>🔧 Fixes</summary>

- [[.NET10] D10-The number and buttons overlap after rotating the
simulator.](#35211)
  </details>

## SwipeView
- Fix SwipeViews with invoked properties crash the app in Release mode
by @BagavathiPerumal in #35208
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS/Catalyst] Swipeviews with invoked properties crash the app in
Release](#18055)
  </details>

- Fix SwipeItemView command leak by @AdamEssenmacher in
#35510
  <details>
  <summary>🔧 Fixes</summary>

- [`SwipeItemView.Command` leaks row views and command parameters
through
`CanExecuteChanged`](#35498)
  </details>

- [iOS/Android] Fix SwipeItem.IsVisible not refreshing native swipe
items when binding changes by @SyedAbdulAzeemSF4852 in
#35217
  <details>
  <summary>🔧 Fixes</summary>

- [SwipeItem.IsVisible doesn't properly refresh the native swipe items
when the binding value changes
dynamically](#34832)
  </details>

- Fix SwipeView memory leak when SwipeItems are reused or replaced by
@Vignesh-SF3580 in #35539
  <details>
  <summary>🔧 Fixes</summary>

- [SwipeView leaks when SwipeItems are reused or
replaced](#35481)
  </details>

- Fix SwipeItem IconImageSource color handling and rendering across
platforms by @Shalini-Ashokan in
#35632
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] SwipeItem IconImageSource should allow more
configuration](#23074)
  </details>

## Switch
- [Android/Windows] Fix RadioButton gradient not clearing when switching
background by @Shalini-Ashokan in
#34997
  <details>
  <summary>🔧 Fixes</summary>

- [RadioButton Background does not reset when set to null at
runtime](#34993)
  </details>

- [Windows] Fix "PlatformView cannot be null here" exception during
handler disconnect by @kubaflo in
#35314
  <details>
  <summary>🔧 Fixes</summary>

- ["PlatformView cannot be null here" Exception in Switch control
[Windows]](#27101)
  </details>

- [iOS 26] Fix Switch ThumbColor and OffColor not applied on initial
load by @SyedAbdulAzeemSF4852 in
#35400
  <details>
  <summary>🔧 Fixes</summary>

- [iOS 26 Switch default color for Off and On is incorrect + Off Color
is not applied at start + Thumb Colors is not
applied](#35257)
  </details>

- [Android] Fix AppBar flicker on CheckBox/Switch toggle with Material 3
by @Dhivya-SF4094 in #35181
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] AppBar flicker while changing the CheckBox or Switch state
after scrolling in Material
3](#35180)
  </details>

- [Android] Fix Switch Shadow Does Not Follow Thumb when Toggle On or
Off by @Dhivya-SF4094 in #35623
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Switch Shadow Does Not Follow Thumb when Toggle On or
Off](#30046)
  </details>

## TabbedPage
- [Android] Fix TabbedPage truncating tab titles instead of scrolling by
@Shalini-Ashokan in #35086
  <details>
  <summary>🔧 Fixes</summary>

- [Maui migrating Xamarin to Maui - Tabbed Page Scroll Issue - Tabs are
not scrolling](#16470)
  </details>

- [Android] Fix BottomNavigationView remaining visible for TabbedPage
inside modal NavigationPage after PushAsync by @Dhivya-SF4094 in
#35359
  <details>
  <summary>🔧 Fixes</summary>

- [Android TabbedPage inside Modal Navigation does not overlay
BottomNavigationView after PushAsync in .NET MAUI
10.0.60](#35331)
  </details>

- [Android & iOS] TabbedPage leaks with shared GradientBrush. by
@SubhikshaSf4851 in #35543
  <details>
  <summary>🔧 Fixes</summary>

- [TabbedPage leaks renderer/manager when BarBackground uses shared
GradientBrush resource](#35469)
  </details>

## Templates
- Bumps Syncfusion.Maui.Toolkit dependency to version 1.0.10 by
@PaulAndersonS in #35608

## Toolbar
- Fix Android app bar inset background coloring by @ne0rrmatrix in
#35601
  <details>
  <summary>🔧 Fixes</summary>

- [Android Edge-to-Edge: Shell and NavigationPage Top Bar colour is not
used for status bar.](#35568)
  </details>

## Tooling
- Add default .gitignore to MAUI project templates by @davidortinau in
#34862
  <details>
  <summary>🔧 Fixes</summary>

- [Add a gitignore file to the Maui template in VS
2022](#4131)
  </details>

- Fix: Propagate AdditionalProperties from ProjectReference in
ResizetizeCollectItems by @mattleibow in
#35575
  <details>
  <summary>🔧 Fixes</summary>

- [Resizetizer GetMauiItems does not propagate ProjectReference
AdditionalProperties](#35574)
  </details>

## WebView
- [Windows] Fix WebView blank rendering when used with HybridWebView by
@SubhikshaSf4851 in #35092
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] WebView Regression from NET9 to
NET10](#34558)
  </details>

- Fix AOT integration test failures: suppress IL3050/IL2026 for
HybridWebViewHandler in AddControlsHandlers by @mattleibow via @Copilot
in #34868

- Fix Android activity result callback leak by @AdamEssenmacher in
#35436
  <details>
  <summary>🔧 Fixes</summary>

- [Android WebView file chooser callbacks leak via
ActivityResultCallbackRegistry](#35405)
  </details>

- [Windows] Fix WebView Does Not Inherit App Theme by
@devanathan-vaithiyanathan in #35037
  <details>
  <summary>🔧 Fixes</summary>

- [WebView on Windows Does Not Inherit App
Theme](#34823)
  </details>

- Fix for WebView leaks when reusing a shared WebViewSource by
@BagavathiPerumal in #35524
  <details>
  <summary>🔧 Fixes</summary>

- [WebView leaks when reusing a shared
WebViewSource](#35483)
  </details>

- Destroy Android WebView on handler disconnect by @AdamEssenmacher in
#35552
  <details>
  <summary>🔧 Fixes</summary>

- [Right way to dispose page with
WebView](#18021)
  </details>

## Xaml
- Fix: Enable VisualStateManager to set Style property dynamically by
@Shalini-Ashokan in #33389
  <details>
  <summary>🔧 Fixes</summary>

- [Setting the `Style` property using the `VisualStateManager` within a
Style resource does not
work](#17175)
  </details>

- Fix Implicit parameter conversion from integer to byte fails with
source generated XAML by @KarthikRajaKalaimani in
#35444
  <details>
  <summary>🔧 Fixes</summary>

- [Implicit parameter conversion from integer to byte fails with source
generated XAML](#35396)
  </details>


<details>
<summary>🔧 Infrastructure (3)</summary>

- Fix: Build fails when appicon is an empty (but valid) SVG by
@Shalini-Ashokan in #35305
  <details>
  <summary>🔧 Fixes</summary>

- [Build fails when appicon is an empty (but valid) svg after upgrade to
10.0.60](#35293)
  </details>
- [inflight/current] Fix CS0111 duplicate GetNativeCharacterSpacing in
PickerHandlerTests.iOS by @SyedAbdulAzeemSF4852 in
#35419
- Update WinAppSDK to 1.8.260508005 by @kubaflo in
#35678

</details>

<details>
<summary>🧪 Testing (3)</summary>

- Backport Test Fixes and Snapshots from SR to Inflight Branch by
@Tamilarasan-Paranthaman in #35499
- Fix hardcoded version of Microsoft.DotNet.XHarness.TestRunners.Xunit
in test projects by @akoeplinger in
#29905
- [Testing] Fixed Build error on inflight/ candidate PR 35716 by
@HarishKumarSF4517 in #35730

</details>

<details>
<summary>🏠 Housekeeping (1)</summary>

- [HouseKeeping] Fix inconsistant namespace in HostApp by
@NirmalKumarYuvaraj in #35210

</details>

<details>
<summary>📦 Other (8)</summary>

- Add .cab and ReconnectModal.razor.js to signing config by @jesuszarate
in #35026
- Fix typo in Clipboard.shared.cs by @Deadpikle in
#35316
- Fix single modifier for NSMenuItem accelerators by @jeremy-visionaid
in #35351
- Avoid unnecessary LINQ enumerations by @jeremy-visionaid in
#35272
- [Testing] Replace retryDelay with retryTimeout in UI tests by @kubaflo
in #35367
- Replace JavaFinalize() with Dispose(bool) in GenericAnimatorListener
by @jonathanpeppers in #35548
- Fix incorrect SDK provisioning commands in integration-tests
instructions by @davidnguyen-tech in
#34992
- Fix VisualElement.ChangeVisualState() gets stuck in Selected state by
@Dhivya-SF4094 in #35421
  <details>
  <summary>🔧 Fixes</summary>

- [VisualElement's ChangeVisualState gets stuck in Selected
state](#35399)
  </details>

</details>

<details>
<summary>📝 Issue References</summary>

Fixes #4131, Fixes #4715, Fixes #5947, Fixes #7150, Fixes #7814, Fixes
#7935, Fixes #8296, Fixes #9095, Fixes #9150, Fixes #10041, Fixes
#12669, Fixes #13258, Fixes #14708, Fixes #15257, Fixes #16470, Fixes
#17175, Fixes #17554, Fixes #17698, Fixes #18021, Fixes #18055, Fixes
#18238, Fixes #19542, Fixes #19668, Fixes #20502, Fixes #20615, Fixes
#21562, Fixes #22053, Fixes #23074, Fixes #24752, Fixes #27101, Fixes
#27627, Fixes #27770, Fixes #27922, Fixes #28514, Fixes #28676, Fixes
#28891, Fixes #29411, Fixes #29449, Fixes #30010, Fixes #30046, Fixes
#30404, Fixes #30464, Fixes #30535, Fixes #30957, Fixes #31048, Fixes
#31177, Fixes #31472, Fixes #31686, Fixes #32279, Fixes #32393, Fixes
#32404, Fixes #32457, Fixes #32476, Fixes #32492, Fixes #32731, Fixes
#32871, Fixes #33508, Fixes #33510, Fixes #33780, Fixes #34038, Fixes
#34104, Fixes #34257, Fixes #34380, Fixes #34522, Fixes #34558, Fixes
#34584, Fixes #34594, Fixes #34823, Fixes #34830, Fixes #34832, Fixes
#34899, Fixes #34930, Fixes #34955, Fixes #34971, Fixes #34973, Fixes
#34993, Fixes #35060, Fixes #35076, Fixes #35088, Fixes #35103, Fixes
#35107, Fixes #35113, Fixes #35114, Fixes #35147, Fixes #35180, Fixes
#35183, Fixes #35211, Fixes #35214, Fixes #35244, Fixes #35257, Fixes
#35277, Fixes #35279, Fixes #35280, Fixes #35286, Fixes #35293, Fixes
#35313, Fixes #35326, Fixes #35331, Fixes #35344, Fixes #35354, Fixes
#35371, Fixes #35380, Fixes #35381, Fixes #35387, Fixes #35390, Fixes
#35396, Fixes #35397, Fixes #35399, Fixes #35401, Fixes #35405, Fixes
#35416, Fixes #35429, Fixes #35469, Fixes #35472, Fixes #35473, Fixes
#35479, Fixes #35481, Fixes #35483, Fixes #35485, Fixes #35492, Fixes
#35495, Fixes #35497, Fixes #35498, Fixes #35513, Fixes #35517, Fixes
#35568, Fixes #35573, Fixes #35574, Fixes #35584, Fixes #35587, Fixes
#35615, Fixes #35618, Fixes #35651, Fixes #35654

</details>


**Full Changelog**:
main...inflight/candidate
@kubaflo kubaflo mentioned this pull request Jul 6, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-core community ✨ Community Contribution s/agent-fix-win AI found a better alternative fix than the PR s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AnimationManager is allocating a lot

8 participants