Repository navigation
[Windows] Replace Header with PlaceholderText for Title property of Picker - #33007
mhrastegari wants to merge 28 commits into
Conversation
|
@mhrastegari Perhaps it's worth adding "Fixes #6845" to the OP. |
Done ✌️ |
|
/rebase |
185a41f to
e8e1830
Compare
e8e1830 to
946931b
Compare
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 33007Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 33007" |
kubaflo
left a comment
There was a problem hiding this comment.
Could you please add a UI Test?
|
Sorry for the late response @kubaflo! Added the UI Tests. |
kubaflo
left a comment
There was a problem hiding this comment.
Could you please review the ai's summary?
|
Done @kubaflo! |
This comment has been minimized.
This comment has been minimized.
MauiBot
left a comment
There was a problem hiding this comment.
AI Review Summary
ℹ️ The review agent did not produce a full summary on this run (an infrastructure issue on the CI agent), but the deep UI tests completed — their results are below. Re-comment
/reviewfor a fresh full review.
Picker, ViewBaseTests), so those deep UI tests could not run. The compiler reported: error CS0234: The type or namespace name 'XamlComponentRegistry' does not exist in the namespace 'Microsoft.Maui.Controls.Xaml' (are you missing an assembly reference?) [D:\a\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostA…. Check the build-output.log in the drop-deep-uitests artifact to see whether main or this PR introduced it, then re-run once the build is fixed.
This comment has been minimized.
This comment has been minimized.
MauiBot
left a comment
There was a problem hiding this comment.
AI Review Summary
ℹ️ The review agent did not produce a full summary on this run (an infrastructure issue on the CI agent), but the deep UI tests completed — their results are below. Re-comment
/reviewfor a fresh full review.
Picker, ViewBaseTests), so those deep UI tests could not run. The compiler reported: error CS0234: The type or namespace name 'XamlComponentRegistry' does not exist in the namespace 'Microsoft.Maui.Controls.Xaml' (are you missing an assembly reference?) [D:\a\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostA…. Check the build-output.log in the drop-deep-uitests artifact to see whether main or this PR introduced it, then re-run once the build is fixed.
This comment has been minimized.
This comment has been minimized.
MauiBot
left a comment
There was a problem hiding this comment.
AI Review Summary
ℹ️ The review agent did not produce a full summary on this run (an infrastructure issue on the CI agent), but the deep UI tests completed — their results are below. Re-comment
/reviewfor a fresh full review.
Picker, ViewBaseTests), so those deep UI tests could not run. The compiler reported: error CS0234: The type or namespace name 'XamlComponentRegistry' does not exist in the namespace 'Microsoft.Maui.Controls.Xaml' (are you missing an assembly reference?) [D:\a\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostA…. Check the build-output.log in the drop-deep-uitests artifact to see whether main or this PR introduced it, then re-run once the build is fixed.
…windows-picker-title-property Resolved conflicts: - PickerExtensions.cs: kept both CharacterSpacing paths. Upstream dotnet#30612 applies spacing to the selected item's TextBlock; this branch applies it to the placeholder TextBlock that now renders Title. Both are needed. - Styles/MauiComboBoxStyle.xaml: kept this branch's deletion. The file only held the ComboBoxHeader template, which is obsolete now that Title maps to the native ComboBox.PlaceholderText. - PublicAPI/net-windows/PublicAPI.Unshipped.txt: kept both added API entries.
- Apply CharacterSpacing to the placeholder and the selected item from a single deferred callback instead of two separate Loaded subscriptions. - Refresh theme resources after TitleColor changes so the placeholder picks up the new brush in every ComboBox visual state.
Regenerate the Issue30464 Windows baseline. Its Picker Title now renders as placeholder text inside the ComboBox instead of a header above it, so the snapshot added by dotnet#30612 no longer matched.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
kubaflo
left a comment
There was a problem hiding this comment.
There's a couple of ui test failures: #33007 (comment)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
…windows-picker-title-property
This comment has been minimized.
This comment has been minimized.
AI Review Summary
🗂️ Review Sessions — click to expand🚦 Gate — Test Before & After FixGate Result: ✅ PASSEDPlatform: WINDOWS · Base: net11.0 · Merge base: 📷 Environmental snapshot residual — not a fix failure — with the fix applied, the only remaining
🔴 Without fix — 📱 PickerTests (TitleDoesNotSetHeader, TitleMapsToPlaceholderText, NullTitleMapsToEmptyPlaceholderText, EmptyTitleMapsToEmptyPlaceholderText, TitleColorMapsToPlaceholderForeground, NullTitleColorClearsPlaceholderForegroundLocalValue, TitleAndTitleColorUpdateAfterHandlerCreation, CharacterSpacingAppliesToPlaceholderWithTitle, CharacterSpacingUpdatesAfterHandlerCreation): FAIL ✅ · 320s(no coded error found; showing last 1200 chars) 🟢 With fix — 📱 PickerTests (TitleDoesNotSetHeader, TitleMapsToPlaceholderText, NullTitleMapsToEmptyPlaceholderText, EmptyTitleMapsToEmptyPlaceholderText, TitleColorMapsToPlaceholderForeground, NullTitleColorClearsPlaceholderForegroundLocalValue, TitleAndTitleColorUpdateAfterHandlerCreation, CharacterSpacingAppliesToPlaceholderWithTitle, CharacterSpacingUpdatesAfterHandlerCreation): PASS ✅ · 123s(no coded error found; showing last 1200 chars) 🔴 Without fix — 🖥️ Issue32723: FAIL ✅ · 306sError-relevant lines (filtered from the build log): 🟢 With fix — 🖥️ Issue32723:
|
| Category | Tests | Snapshot diffs |
|---|---|---|
Picker |
33/51 (17 ❌) | 36 diff PNGs |
ViewBaseTests |
91/115 (24 ❌) | 48 diff PNGs |
🔍 AI analysis of failures — PR-related vs unrelated
🔍 AI-generated triage (GitHub Copilot CLI) — a heuristic judgement of whether each deep UI test failure is connected to this PR's changes. Verify before relying on it.
Likely PR-related: one or more failures appear connected to this PR's changes.
- ✗ PR-related — Windows Picker visual snapshots (~17 tests): the PR changes Windows
Pickerrendering from aComboBox.Headertemplate toPlaceholderText/PlaceholderForegroundand updates many Windows Picker baselines, so Picker screenshot differences such asIssue32984PickerShouldResizeare plausibly caused by this PR or by incomplete/out-of-sync snapshot updates. - ✗ PR-related — New Issue32723 Picker snapshot (~1 test):
Issue32723PickerTitleDisplaysAsPlaceholderis a new Windows Picker UI test and baseline added by this PR, and its snapshot mismatch directly exercises the changed title-as-placeholder behavior. - ℹ Uncertain — AppTheme/ViewBase snapshot tests across multiple controls (~23 tests): these fail with a shared visual-baseline mismatch pattern, but the PR removes a Windows resource dictionary from shared WinUI resources and calls
RefreshThemeResources()for Picker placeholder styling, so the broad theme-related differences could be either PR fallout or a stale run-wide baseline/environment issue.
Strongest signal: the Picker failures line up directly with Windows Picker code and baseline changes; compare the generated Windows snapshots against the PR-updated baselines, then check whether the non-Picker AppTheme diffs show the same global theme shift.
❌ Picker — 17 failed tests
Issue32984PickerShouldResize
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Issue32984PickerShouldResize.png (1.26% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retry
...
Picker_SetFontSizeAndFontAttributesBold_VerifyFontSizeAndAttributes
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Picker_SetFontSizeAndFontAttributesBold_VerifyFontSizeAndAttributes.png (4.40% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyS
...
Picker_SetSelectedIndex_VerifySelectedIndexAndItem
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Picker_SetSelectedIndex_VerifySelectedIndexAndItem.png (1.91% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String
...
Picker_SetFontSizeAndFontFamilyDokdo_VerifyFontSizeAndFontFamily
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Picker_SetFontSizeAndFontFamilyDokdo_VerifyFontSizeAndFontFamily.png (2.12% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScre
...
Issue32723PickerTitleDisplaysAsPlaceholder
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Issue32723PickerTitleDisplaysAsPlaceholder.png (0.84% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nu
...
Issue16737Test
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Issue16737Test.png (0.56% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullabl
...
Picker_SelectItem_VerifySelectedItem
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Picker_SelectItem_VerifySelectedItem.png (1.82% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable
...
PickerTitleShouldBeRed
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: PickerTitleShouldBeRed.png (0.84% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay,
...
Issue32723PickerTitleUpdatesAtRuntime
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Issue32723PickerTitleUpdatesAtRuntime.png (0.84% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullabl
...
Picker_TapPicker_TakeScreenshot
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Picker_TapPicker_TakeScreenshot.png (3.37% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 re
...
ShouldDisplayPickerItemsWhenOpeningPicker
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: ShouldDisplayPickerItemsWhenOpeningPicker.png (2.23% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nul
...
Picker_SetSelectedItem_VerifySelectedItemLabel
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Picker_SetSelectedItem_VerifySelectedItemLabel.png (1.88% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name
...
ValidatePickerTitleAndItemCharacterSpacing
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: ValidatePickerTitleAndItemCharacterSpacing.png (0.84% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nu
...
Picker_Validate_VerifyLabels
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Picker_Validate_VerifyLabels.png (1.21% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retry
...
PickerKeepsCharacterSpacingAfterSelectingItem
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: PickerKeepsCharacterSpacingAfterSelectingItem.png (1.78% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.Issues.Issue34971.PickerKeepsCharacterSpacingAfterSelectingItem() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34971.cs:line 36
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHandleOnStack result)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Picker_SetFlowDirectionRTL_VerifyFlowDirection
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: Picker_SetFlowDirectionRTL_VerifyFlowDirection.png (1.91% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name
...
PickerShouldRegainTitle
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: PickerShouldRegainTitle.png (0.84% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 485
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay
...
❌ ViewBaseTests — 24 failed tests
DarkTheme_SearchBar_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_SearchBar_VerifyVisualState.png (3.56% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_SearchBar_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 266
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, Ob
...
DarkTheme_CheckBox_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_CheckBox_VerifyVisualState.png (3.54% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_CheckBox_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 67
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.RuntimeMethodInfo.Invoke
...
DarkTheme_Editor_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_Editor_VerifyVisualState.png (3.56% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_Editor_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 286
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHa
...
LightTheme_Picker_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_Picker_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_Picker_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 140
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, Objec
...
LightTheme_CheckBox_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_CheckBox_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_CheckBox_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 55
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.Inv
...
DarkTheme_Picker_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_Picker_VerifyVisualState.png (3.54% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_Picker_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 153
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHa
...
DarkTheme_Slider_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_Slider_VerifyVisualState.png (3.54% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_Slider_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 174
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHa
...
DarkTheme_Switch_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_Switch_VerifyVisualState.png (3.56% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_Switch_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 197
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, ObjectHa
...
LightTheme_EditorAndPlaceholderColor_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_EditorAndPlaceholderColor_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.VerifyScreenshotWithPlatformCropping() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 21
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_EditorAndPlaceholderColor_VerifyVisualState() in /_/sr
...
LightTheme_EntryAndPlaceholderColor_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_EntryAndPlaceholderColor_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.VerifyScreenshotWithPlatformCropping() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 21
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_EntryAndPlaceholderColor_VerifyVisualState() in /_/src/
...
LightTheme_SearchBar_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_SearchBar_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_SearchBar_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 256
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor,
...
DarkTheme_DatePicker_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_DatePicker_VerifyVisualState.png (3.54% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_DatePicker_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 105
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.RuntimeMethodInfo.I
...
DarkTheme_RadioButton_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_RadioButton_VerifyVisualState.png (3.54% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_RadioButton_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 125
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor
...
LightTheme_RadioButton_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_RadioButton_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_RadioButton_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 114
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.RuntimeMethodI
...
LightTheme_SearchBarAndPlaceholderColor_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_SearchBarAndPlaceholderColor_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.VerifyScreenshotWithPlatformCropping() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 21
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_SearchBarAndPlaceholderColor_VerifyVisualState() in
...
LightTheme_Editor_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_Editor_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_Editor_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 276
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, Objec
...
DarkTheme_SearchBarAndPlaceholderColor_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_SearchBarAndPlaceholderColor_VerifyVisualState.png (3.56% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.VerifyScreenshotWithPlatformCropping() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 21
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_SearchBarAndPlaceholderColor_VerifyVisualState() in /_
...
LightTheme_Slider_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_Slider_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_Slider_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 164
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, Objec
...
DarkTheme_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_VerifyVisualState.png (5.27% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 40
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object
...
LightTheme_Switch_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_Switch_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_Switch_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 185
at System.RuntimeMethodHandle.InvokeMethod(ObjectHandleOnStack target, Void** arguments, ObjectHandleOnStack sig, BOOL isConstructor, Objec
...
LightTheme_DatePicker_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_DatePicker_VerifyVisualState.png (12.03% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_DatePicker_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 86
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.RuntimeMethodInfo
...
DarkTheme_EditorAndPlaceholderColor_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_EditorAndPlaceholderColor_VerifyVisualState.png (3.56% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.VerifyScreenshotWithPlatformCropping() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 21
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_EditorAndPlaceholderColor_VerifyVisualState() in /_/src/C
...
DarkTheme_EntryAndPlaceholderColor_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: DarkTheme_EntryAndPlaceholderColor_VerifyVisualState.png (3.56% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.VerifyScreenshotWithPlatformCropping() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 21
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.DarkTheme_EntryAndPlaceholderColor_VerifyVisualState() in /_/src/Con
...
LightTheme_VerifyVisualState
VisualTestUtils.VisualTestFailedException :
Snapshot different than baseline: LightTheme_VerifyVisualState.png (4.28% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.
More info: https://aka.ms/visual-test-workflow
at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance, Boolean includeTitleBar) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
at Microsoft.Maui.TestCases.Tests.AppThemeFeatureTests.LightTheme_VerifyVisualState() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/AppThemeFeatureTests.cs:line 31
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Objec
...
📎 Download drop-deep-uitests artifact (TRX + snapshot diffs)
📋 Pre-Flight — Context & Validation
Issue: #32723 / #6845 - Windows Picker Title displays as a header instead of a placeholder
PR: #33007 - [Windows] Replace Header with PlaceholderText for Title property of Picker
Platforms Affected: Windows
Files Changed: 5 implementation/API/resource, 21 test/snapshot
Key Findings
- The PR changes Windows
Picker.Titlefrom aComboBox.Header/HeaderTemplate-based rendering path toComboBox.PlaceholderText, aligning Windows with iOS and Android placeholder semantics. - The PR also maps
Picker.TitleColortoComboBox.PlaceholderForegroundand extends character-spacing updates to the placeholder template part. - Linked issue discussion confirms this is an intentional Windows behavior change and was deferred to .NET 11 as a breaking change.
- Gate result was provided as passed: tests fail without the fix and pass with the PR fix. Gate was not re-run.
Code Review Summary
Verdict: NEEDS_DISCUSSION
Confidence: low
Errors: 0 | Warnings: 1 | Suggestions: 0
Key code review findings:
- ⚠ Duplicate pre-load
Loadedcallbacks can accumulate insrc/Core/src/Platform/Windows/PickerExtensions.cs:107whenUpdateTitleandUpdateCharacterSpacingrun before theComboBoxis loaded.
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #33007 | Map Windows Picker.Title to ComboBox.PlaceholderText, remove the custom header template resource, map TitleColor to PlaceholderForeground, and apply character spacing to placeholder template parts. |
✅ PASSED (Gate) | PickerHandler.Windows.cs, PickerExtensions.cs, Resources.xaml, removed MauiComboBoxStyle.xaml, tests/snapshots |
Original PR |
🔬 Code Review — Deep Analysis
Code Review — PR #33007
Independent Assessment
What this changes: Windows Picker.Title now maps to ComboBox.PlaceholderText instead of Header, TitleColor maps to PlaceholderForeground, and placeholder character spacing is applied to WinUI template parts.
Inferred motivation: Align Windows Picker title rendering with iOS/Android placeholder behavior and fix issue #32723/#6845.
Reconciliation with PR Narrative
Author claims: Replace Windows Picker header title with placeholder text; breaking change targeting .NET 11.
Agreement/disagreement: Matches the code and linked issues.
Prior Review Reconciliation
| Prior ❌ Error Finding | Source | Status | Evidence |
|---|---|---|---|
| Missing/stale Picker screenshot baselines | MauiBot [major] |
✅ Fixed / current CI pending | Current squashed diff adds Issue32723* baselines and refreshes existing Picker Windows snapshots; latest public gate on 317960f passed, but current 2c95990 CI is still pending. |
Missing RefreshThemeResources() after placeholder updates |
MauiBot [moderate] |
✅ Fixed | PickerExtensions.cs:23 and :122. |
Multiple pre-load Loaded callbacks |
MauiBot [moderate] |
❌ Unresolved warning-level | Still possible via UpdateTitle and UpdateCharacterSpacing before load. |
External Output Contract
| Consumer token/pattern | Producer location | Producer emission condition | Consumer assumption | Ordinary negative case | Downstream effect |
|---|---|---|---|---|---|
| N/A | N/A | No changed code classifies external tool output | N/A | N/A | N/A |
Blast Radius Assessment
- Runs for all instances: Yes, all Windows
Pickerhandlers. - Startup impact: Handler initialization path only; no new static state.
- Static/shared state: No.
- Platform/UI plumbing: Yes, Windows handler/template behavior; max confidence medium, capped low by CI.
CI Status
- Required-check result:
gh pr checks --requiredunavailable (gh auth loginrequired); REST shows current head2c95990hasBuild Analysisin progress. - Classification: Undetermined / pending.
- Action taken: Confidence capped low; no
LGTMper skill rules.
Findings
❌ Error
None found.
⚠️ Warning — Duplicate pre-load Loaded callbacks can accumulate
src/Core/src/Platform/Windows/PickerExtensions.cs:107
ApplyCharacterSpacingWhenLoaded() registers a Loaded callback whenever UpdateTitle or UpdateCharacterSpacing runs before the ComboBox is loaded. Initial mapper setup can schedule at least two callbacks, and bound pre-load updates can schedule more. This is not a correctness blocker, but coalescing the pending loaded apply would avoid duplicate visual-tree walks.
💡 Suggestion
None.
Failure-Mode Probing
- Null/default
Title: maps tostring.Empty; safe. - Null
TitleColor: clears localPlaceholderForeground; safe. - Runtime title/color update: mapper updates placeholder/color and refreshes resources.
- Handler disconnect/reconnect: no new subscriptions except one-shot
Loaded; duplicate callbacks are the main lifecycle risk. - Selected item present: placeholder naturally disappears, matching placeholder semantics.
Verdict: NEEDS_DISCUSSION
Confidence: low
Summary: No blocking code correctness issue was found, and the implementation matches the PR narrative. However, current CI is pending/undetermined and there is one unresolved lifecycle/performance warning around duplicate pre-load Loaded callbacks, so this should not be marked LGTM yet.
🛠️ Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| 1 | try-fix | Keep Title -> PlaceholderText, but instantiate a Picker-specific MauiPickerComboBox and apply placeholder character spacing from OnApplyTemplate instead of queuing pre-load Loaded callbacks. |
✅ PASS | 2 files | Fixes the code-review warning but adds a new WinUI subclass. |
| 2 | try-fix | Keep the PR behavior, but coalesce the pre-load Loaded deferral by removing/re-adding a static handler before subscribing. |
✅ PASS | 1 file | Fixes the code-review warning with the smallest localized change and no new control subclass. |
| PR | PR #33007 | Map Windows Picker.Title to ComboBox.PlaceholderText, map TitleColor to PlaceholderForeground, apply character spacing to placeholder template parts, remove the custom header template resource. |
✅ PASSED (Gate) | 5 implementation/API/resource files plus tests/snapshots | Original PR |
Cross-Pollination
| Model | Round | New Ideas? | Details |
|---|---|---|---|
| maui-expert-reviewer | 1 | Yes | Suggested lifecycle-focused subclass, style/template approaches, header-backed compatibility template, and resource-key driven placeholder styling. |
| maui-expert-reviewer | 2 | Yes | Recommended a coalesced Loaded callback as a simpler follow-up to candidate 1. |
Exhausted: Yes — the remaining style/template, header-backed compatibility, and resource-key approaches are meaningfully different but higher-risk and less localized than the passing candidates; candidate 2 already passes and addresses the only pre-flight warning with minimal churn.
Selected Fix: Candidate #2 — It passes the targeted Windows Picker regression suite and is demonstrably better than the current PR fix by making the pre-load character-spacing deferral idempotent without adding a new platform subclass.
📝 Recommended PR Title & Description
Assessment: ✏️ Recommend updating — the current description accurately explains the main Title behavior change, but the winning fix also updates TitleColor/CharacterSpacing handling and coalesces deferred Loaded callback work.
Recommended title
[Windows] Picker: Use Title as PlaceholderText
Recommended description
### Description of Change
This change updates the Windows `Picker` so its `Title` property matches the behavior on iOS and Android.
Instead of displaying the title as a `ComboBox` header, Windows now maps it to `ComboBox.PlaceholderText` so the title appears as placeholder text inside the control.
The fix also:
- Maps `Picker.TitleColor` to `ComboBox.PlaceholderForeground`.
- Applies `Picker.CharacterSpacing` to the selected item and placeholder template text.
- Coalesces deferred pre-load `Loaded` callbacks so `Title` and `CharacterSpacing` updates before first load do not stack duplicate character-spacing work.
- Removes the custom `MauiComboBoxStyle.xaml` header template resource that is no longer needed.
### Platform
- [x] Windows
### Issues Fixed
Fixes #32723
Fixes #6845
### Screenshots
| Before | After |
| ------ | ----- |
| <img src="https://github.com/user-attachments/assets/bdae96ce-4a46-4188-b52b-3d2b0e12fc1c" width="500" /> | <img src="https://github.com/user-attachments/assets/93a3416a-5355-4dad-85a6-1e58b90f20fa" width="500" /> |
---
This is a breaking change and therefore targets the .NET 11 branch as requested.
🏁 Report — Final Recommendation
Comparative Report — PR #33007
Candidates compared
| Candidate | Regression status | Assessment | Rank |
|---|---|---|---|
pr-plus-reviewer |
Pass-equivalent to try-fix-2; gate not re-run by instruction |
Keeps the PR behavior and applies the expert reviewer's actionable fix by coalescing the deferred Loaded character-spacing callback. Same localized code shape as passing try-fix-2, no new subclass, no public API expansion beyond the PR's UpdateTitleColor entry. |
1 |
try-fix-2 |
✅ PASS | Same technical improvement as pr-plus-reviewer: remove/re-add a static Loaded handler before subscribing so repeated pre-load mapper calls coalesce to one pending callback. Strong standalone candidate, but it is equivalent to the reviewer-improved PR candidate. |
2 |
try-fix-1 |
✅ PASS | Fixes duplicate pre-load callbacks by adding a Picker-specific MauiPickerComboBox subclass and applying character spacing from OnApplyTemplate. Correct but broader than needed and adds a new WinUI-derived type. |
3 |
pr |
✅ PASSED gate | Correctly implements the Windows Picker behavior change and has regression coverage, but leaves the expert-review/pre-flight warning unresolved: UpdateTitle and UpdateCharacterSpacing can stack duplicate pre-load Loaded callbacks. |
4 |
Selection rationale
All candidates with recorded regression results passed; no failed-regression candidate outranks a passing one. The raw PR fixes the reported bug and passes the gate, but pr-plus-reviewer strictly improves it by addressing the only actionable expert finding with the smallest lifecycle-safe change. try-fix-1 is also passing, but it introduces a new WinUI subclass for a problem that can be solved by idempotent event subscription in the existing extension method.
Winning candidate
pr-plus-reviewer wins. It preserves the raw PR's intended Windows behavior change, incorporates the expert reviewer feedback, and is equivalent to the passing try-fix-2 implementation while remaining a PR-lineage fix.
🧭 Next Steps — review latest findings
No alternative fix was selected for this run. Review the session findings and CI results before merging.
kubaflo
left a comment
There was a problem hiding this comment.
Expert review — see inline comments.
| public static void UpdateTitle(this ComboBox nativeComboBox, IPicker picker) | ||
| { | ||
| nativeComboBox.Header = string.IsNullOrEmpty(picker.Title) ? null : picker; | ||
| nativeComboBox.PlaceholderText = picker.Title ?? string.Empty; |
There was a problem hiding this comment.
[major] Regression Prevention and Test Coverage — Windows snapshot baselines are only partially refreshed. Moving Title from ComboBox.Header to PlaceholderText removes the header label from every Windows Picker that has a Title, not just the tests whose names contain "Title". I extracted the baselines at this head and visually confirmed the following committed Windows PNGs still show the old header rendering and were not updated by this PR:
Picker_Validate_VerifyLabels.png— showsPicker Titleas a label above an empty ComboBoxPicker_SetSelectedIndex_VerifySelectedIndexAndItem.png— headerPicker TitleaboveOption 2 - Second optionPicker_SetSelectedItem_VerifySelectedItemLabel.pngPicker_SetFontSizeAndFontAttributesBold_VerifyFontSizeAndAttributes.png— headerPicker Titleabove the bold selected itemPicker_SetFontSizeAndFontFamilyDokdo_VerifyFontSizeAndFontFamily.pngPicker_SetFlowDirectionRTL_VerifyFlowDirection.png— right-aligned headerPicker TitlePickerKeepsCharacterSpacingAfterSelectingItem.png/PickerKeepsCharacterSpacingAfterProgrammaticSelectedIndexChange.png— headerS e l e c t a n I t e mabove the ComboBoxLightTheme_Picker_VerifyVisualState.png/DarkTheme_Picker_VerifyVisualState.png— headerSelect a monkeyabove the ComboBoxIssue32984PickerShouldResize.png— host page setsTitle = "Select an item", so the ComboBox height/dropdown anchor shifts
Root cause for the feature-matrix set: FeatureMatrix/Picker/PickerControlPage.xaml binds Title="{Binding Title}" and PickerViewModel defaults _title = "Picker Title", so all Picker_* Windows baselines rendered a header before this change — not only the *Title*-named ones that were regenerated. Same for FeatureMatrix/AppTheme/AppThemePage.xaml / DefaultThemePage.xaml (Title="Select a monkey").
Note this is a different (and complementary) set from the earlier bot comment on this line: the baselines that comment listed (Picker_SetTitle_VerifyTitleLabel.png, PickerShouldRegainTitle.png, PickerTitleShouldBeRed.png, etc.) are correctly updated at this head; the ones above are the remaining stale ones. Please regenerate them or the Windows UI test lane will stay red after merge.
| public void Issue32723PickerTitleUpdatesAtRuntime() | ||
| { | ||
| App.WaitForElement("issue32723Button"); | ||
| App.Tap("issue32723Button"); |
There was a problem hiding this comment.
[moderate] Regression Prevention and Test Coverage — This tap mutates persistent page state and nothing restores it between tests. The host page handler toggles both properties (Issue32723.cs: picker.Title = picker.Title == "Select Option" ? "Updated Title" : "Select Option" and the same for TitleColor), but this fixture does not override ResetAfterEachTest, which defaults to false (src/TestUtils/src/UITest.NUnit/UITestBase.cs:12), and _IssuesUITest.TryToResetTestState() re-navigates only from FixtureSetup/OneTimeSetUp — not per test.
Concrete failure: the two tests carry no [Order], and NUnit does not guarantee method execution order within a fixture. If Issue32723PickerTitleUpdatesAtRuntime runs before Issue32723PickerTitleDisplaysAsPlaceholder, the latter captures the toggled state (Updated Title in blue) and fails against Issue32723PickerTitleDisplaysAsPlaceholder.png. Because the button is a toggle rather than an absolute setter, re-entering this test in the same app session also flips the picker back to the initial state and breaks Issue32723PickerTitleUpdatesAtRuntime.png.
Add protected override bool ResetAfterEachTest => true; (the established convention for state-mutating issue fixtures, e.g. Issue28416.cs:15, Issue20834.cs:14), and/or make the button assign an absolute Title/TitleColor instead of toggling.
|
After investigating the product semantics, WinUI behavior, issue demand, accessibility implications, tests, and several alternative implementations, my recommendation is not to merge this PR unchanged. The request is valid, but this PR changes every existing Windows I suggest one of these paths:
A cross-platform |
|
Here is a current-release workaround that is scoped to an opt-in // PlaceholderPicker.cs
public sealed class PlaceholderPicker : Picker
{
}Register these mapper additions in #if WINDOWS
using Microsoft.Maui;
using Microsoft.Maui.Handlers;
using Microsoft.Maui.Platform;
using Microsoft.UI.Xaml.Automation;
using Microsoft.UI.Xaml.Controls;
PickerHandler.Mapper.AppendToMapping(nameof(IPicker.Title), (handler, picker) =>
{
if (picker is not PlaceholderPicker)
return;
var comboBox = handler.PlatformView;
var title = picker.Title ?? string.Empty;
comboBox.Header = null;
comboBox.HeaderTemplate = null;
comboBox.PlaceholderText = title;
// PlaceholderText disappears after selection, so retain an accessible name.
AutomationProperties.SetName(comboBox, title);
});
PickerHandler.Mapper.AppendToMapping(nameof(IPicker.TitleColor), (handler, picker) =>
{
if (picker is not PlaceholderPicker)
return;
var comboBox = handler.PlatformView;
if (picker.TitleColor is null)
comboBox.ClearValue(ComboBox.PlaceholderForegroundProperty);
else
comboBox.PlaceholderForeground = picker.TitleColor.ToPlatform();
});
#endifThen use <local:PlaceholderPicker
Title="Select a country"
TitleColor="Gray"
ItemsSource="{Binding Countries}" />If every Picker in the application should use this behavior, remove the |
|
Thanks @mhrastegari for all the work and responsiveness on this PR. After reviewing the product tradeoffs, I don’t think we should take this change, so I’m going to close it. While cross-platform consistency is desirable, the current Windows behavior uses the native The implementation has additionally exposed a disproportionate regression and maintenance surface around character spacing, theme states, handler lifecycle, and existing visual baselines. Given the relatively modest demand and the availability of an opt-in handler-mapper workaround, the benefit does not justify that compatibility cost. This is a product decision rather than a reflection on the quality or effort of the contribution. If we revisit this area, I think it should be through an additive, opt-in placeholder API that preserves the existing Windows |
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This change updates the
PickerforWindowsso that itsTitleproperty matches the behavior on iOS and Android.Instead of displaying the title as a header, it now uses it as the placeholder to ensure consistent cross-platform appearance.
Platform
Issues Fixed
Fixes #32723
Fixes #6845
Screenshots
This is a breaking change and therefore targets the .NET 11 branch as requested.