Skip to content

[IOS] Inconsistent Resize Behavior for Header/Footer - fix - #28713

Merged
kubaflo merged 13 commits into
dotnet:inflight/currentfrom
kubaflo:Inconsistent-Resize-Behavior-for-Header/Footer
Apr 2, 2026
Merged

kubaflo merged 13 commits into
dotnet:inflight/currentfrom
kubaflo:Inconsistent-Resize-Behavior-for-Header/Footer

Conversation

@kubaflo

@kubaflo kubaflo commented Mar 30, 2025 •

Copy link
Copy Markdown
Contributor

Issues Fixed

Fixes #26397
Fixes #33501

Before After
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-12-07.at.16.45.45.mp4
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2024-12-07.at.16.46.35.mp4

Copilot AI review requested due to automatic review settings March 30, 2025 17:14
@kubaflo
kubaflo requested a review from a team as a code owner March 30, 2025 17:14
@kubaflo kubaflo self-assigned this Mar 30, 2025
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Mar 30, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses inconsistent resize behavior for the header and footer on iOS by updating test conditions and adjusting the measurement logic in the flyout content renderer. Key changes include:

  • Enabling header/footer size change tests for iOS in the test project.
  • Adding a new "_header" field and modifying event subscriptions in ShellFlyoutContentRenderer to support the corrected resizing logic.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/HeaderFooterShellFlyout.cs Updated conditional compilation to include iOS tests for header/footer resize behavior
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutContentRenderer.cs Introduced a new _header field and modified event subscription logic for header measurement
Comments suppressed due to low confidence (2)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/HeaderFooterShellFlyout.cs:70

  • The conditional compilation now includes iOS for header/footer resize tests. Please update or add a comment clarifying why iOS is included to avoid confusion given the removed note about iOS being ignored.
#if ANDROID || IOS

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutContentRenderer.cs:100

  • It appears the code subscribes to the MeasureInvalidated event on the existing _header before reassigning it, which may result in duplicate event subscriptions or a memory leak. Consider unsubscribing from the old _header's MeasureInvalidated event instead of subscribing again.
if (_header is not null) {

@kubaflo kubaflo added platform/ios area-controls-shell Shell Navigation, Routes, Tabs, Flyout area-controls-flyout Flyout and removed community ✨ Community Contribution labels Mar 30, 2025
@kubaflo
kubaflo force-pushed the Inconsistent-Resize-Behavior-for-Header/Footer branch 2 times, most recently from 6ae82fe to 8cccec6 Compare April 2, 2025 23:46
@rmarinho

rmarinho commented Apr 7, 2025

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@kubaflo
kubaflo force-pushed the Inconsistent-Resize-Behavior-for-Header/Footer branch 2 times, most recently from 9dfc18b to f0f83ea Compare January 14, 2026 14:05
@kubaflo

kubaflo commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

PR Review: #28713 - [IOS] Inconsistent Resize Behavior for Header/Footer - fix

Date: 2026-01-14 | Issue: #26397 | PR: #28713

✅ Final Recommendation: APPROVE

PR #28713 correctly fixes issue #26397 by implementing the iOS platform's measure invalidation pattern.

Phase Status
Pre-Flight ✅ COMPLETE
🧪 Tests ✅ COMPLETE
🚦 Gate ✅ PASSED
🔧 Fix ✅ COMPLETE
📋 Report ✅ COMPLETE

📋 Issue Summary

Description:
When the "Resize Header/Footer" menu is tapped in a Shell flyout, the header and footer sizes change but do not remain consistent across multiple taps. The resizing behavior is inconsistent - sizes may vary each time the resize action is triggered.

Steps to Reproduce:

  1. Run the test app (HeaderFooterShellFlyout sample)
  2. Open the Flyout and tap the "Resize Header/Footer" menu
  3. Observe that the header and footer resize
  4. Tap the "Resize Header/Footer" menu again
  5. Tap the "Resize Header/Footer" menu again and observe the size
  6. The size differs from the initial size (inconsistent behavior)

Expected Behavior:
Header and footer should toggle between small (60) and large (200) consistently on each tap.

Actual Behavior:
Header and footer sizes vary and don't maintain consistent toggle behavior.

Platforms Affected:

  • iOS
  • macOS (Mac Catalyst)
  • Android
  • Windows

Regression:
Not confirmed - user was not sure about previous versions

Version with Bug: 9.0.12 SR1.2

📁 Files Changed
File Type Changes
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutHeaderContainer.cs Fix +11 -1
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/HeaderFooterShellFlyout.cs Test +1 -2

Fix Summary:

  • ShellFlyoutHeaderContainer.cs: Implements IPlatformMeasureInvalidationController interface
    • Adds InvalidateMeasure() method that recalculates size using SizeThatFits and updates frame
    • Returns false to stop propagation after handling resize directly
    • Adds empty InvalidateAncestorsMeasuresWhenMovedToWindow() implementation

Test Summary:

💬 PR Discussion Summary

Key Comments:

  1. PureWeen (Changes Requested) - Line 102 of ShellFlyoutHeaderContainer.cs:

    • "I think we're moving away from subscribing to measure invalidated subscriptions and using the propagation method that @albyrock87 created"
    • Author response: "No problem"
    • Status: ⚠️ INVESTIGATE - Review comment refers to OLD approach (subscribing to MeasureInvalidated event)
    • Note: Current PR implementation uses the NEW approach (IPlatformMeasureInvalidationController interface) which IS the propagation method
  2. Copilot PR Reviewer (Low Confidence Comments):

    • Suggested clarifying why iOS is now included in tests (comment update)
    • Flagged potential memory leak in old version with event subscription (no longer relevant - PR doesn't use event subscription)

Reviewer Feedback:

  • PureWeen requested changes on 2025-03-30: Comment referenced ShellFlyoutContentRenderer.cs:102 about using "propagation method" instead of MeasureInvalidated subscriptions
  • Author responded on 2025-04-02: "No problem" (agreed to change approach)
  • IMPORTANT: The PR diff shows changes to ShellFlyoutHeaderContainer.cs, NOT ShellFlyoutContentRenderer.cs
  • Conclusion: Author changed implementation approach AFTER initial review - now using IPlatformMeasureInvalidationController (the propagation method)

Disagreements to Investigate:

File:Line Reviewer Says Current PR Status
ShellFlyoutContentRenderer.cs:102 Use propagation method instead of MeasureInvalidated Changed to ShellFlyoutHeaderContainer implementing IPlatformMeasureInvalidationController ✅ RESOLVED - Author implemented requested change

Author Uncertainty:

  • None explicitly stated

Edge Cases from Discussion:

  • Memory leak concern with event subscriptions - NOT applicable (author removed event subscription approach)
  • IPlatformMeasureInvalidationController IS the correct "propagation method" - confirmed by interface definition in Core
🧪 Tests

Status: ✅ COMPLETE

  • PR includes UI tests (existing tests modified to enable iOS)
  • Tests compile successfully
  • Tests follow naming convention (uses XFIssue pattern)

Test Files:

  • HostApp: src/Controls/tests/TestCases.HostApp/Issues/XFIssue/HeaderFooterShellFlyout.cs (existing - not modified by PR)
  • NUnit: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/HeaderFooterShellFlyout.cs (modified to enable iOS)

Test Scenario:
The existing test creates a Shell flyout with header/footer, then taps "Resize Header/Footer" three times:

  1. First tap: Resize from initial to small (60)
  2. Second tap: Resize from small to large (200)
  3. Third tap: Resize from large back to small (60)

Tests verify that:

  • headerSizeLarge.Height > headerSizeSmall.Height
  • footerSizeLarge.Height > footerSizeSmall.Height
  • headerSizeSmall2.Height == headerSizeSmall.Height (consistent toggle)
  • footerSizeSmall2.Height == footerSizeSmall.Height (consistent toggle)

PR Change: Enables these tests for iOS by changing #if ANDROID to #if ANDROID || IOS
Note: Tests were previously disabled for iOS with comment: "These tests are ignored on iOS and Catalyst because the header height doesn't update correctly. Refer to issue: #26397"

🚦 Gate - Test Verification

Status: ✅ PASSED

  • Tests FAIL without fix (bug reproduced)
  • Tests PASS with fix (bug resolved)

Result: PASSED ✅

Verification Details:

  • WITHOUT fix: Tests FAIL (exit code 1) - bug reproduced ✅
  • WITH fix: All tests PASS - bug resolved ✅

Platform Tested: iOS (iPhone Xs simulator)
Test: HeaderFooterShellFlyout - Resize header/footer test
Behavior: Tests verify that header and footer sizes toggle consistently between 60 (small) and 200 (large) on repeated taps

Logs: /Users/kubaflo/Desktop/maui/CustomAgentLogsTmp/UITests/

🔧 Fix Candidates

Status: ✅ COMPLETE

# Source Approach Test Result Files Changed Notes
PR PR #28713 Implement IPlatformMeasureInvalidationController interface - respond to measure invalidation by recalculating size with SizeThatFits and updating frame ✅ PASS (Gate) ShellFlyoutHeaderContainer.cs (+12 -1) Original PR - implements propagation pattern, validated by Gate

PR's Approach:

  • Implements IPlatformMeasureInvalidationController interface on ShellFlyoutHeaderContainer
  • InvalidateMeasure() recalculates size using SizeThatFits(new CGSize(Superview.Frame.Width, double.PositiveInfinity))
  • Updates frame with new calculated size: Frame = new CGRect(Frame.X, Frame.Y, size.Width, size.Height)
  • Returns false to stop propagation (resize handled directly)
  • Empty implementation for InvalidateAncestorsMeasuresWhenMovedToWindow()

try-fix Analysis:

  • No try-fix attempts made - PR's approach is the correct iOS platform pattern
  • Reasoning: The reviewer (PureWeen) explicitly requested using "the propagation method that @albyrock87 created", which is IPlatformMeasureInvalidationController
  • Platform Pattern: This interface is the standard iOS mechanism for handling measure invalidation (see src/Core/src/Platform/iOS/IPlatformMeasureInvalidationController.cs)
  • Alternative approaches would:
    1. Use event subscriptions (MeasureInvalidated) - explicitly rejected by reviewer as deprecated pattern
    2. Manual layout override - would bypass the platform's propagation system
    3. Both violate iOS platform conventions and maintainability guidelines

Exhausted: N/A (iOS platform pattern - no alternatives to explore)
Selected Fix: PR's fix - Implements the correct iOS platform pattern as requested by reviewer


Next Step: Review complete - APPROVE PR #28713

@albyrock87

Copy link
Copy Markdown
Contributor

This may have bad performance, but we'll solve it with #33459

@kubaflo

kubaflo commented Jan 14, 2026

Copy link
Copy Markdown
Contributor Author

@albyrock87 thanks! Do you think this fix is good then?

@albyrock87

Copy link
Copy Markdown
Contributor

Yes it's an acceptable workaround indeed!

@github-actions

github-actions Bot commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 28713

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 28713"

@StephaneDelcroix StephaneDelcroix left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multi-Model Consensus Review (5 models: claude-opus-4.6 ×2, claude-sonnet-4.6, gemini-3-pro-preview, gpt-5.3-codex)

CI Status: ⚠️ Pre-existing failures (not PR-specific)

Consensus Findings (2+ models agreed)

🟡 MODERATE Superview.Frame.Width with no null guard -- Superview can be null during view lifecycle transitions (e.g., when the view is removed from the hierarchy during rotation or navigation). Accessing Superview.Frame.Width without a null check will throw a NullReferenceException. Add a null-conditional: Superview?.Frame.Width ?? Frame.Width or similar fallback.

Test Coverage

No new tests added for the corrected resize behavior. Suggest adding a UI test that verifies header/footer resize after orientation change or dynamic content update.

Verdict: ⚠️ Request Changes

The fix approach is correct but needs a null guard on Superview before accessing Frame.Width. This is a one-line fix -- once addressed, the PR is ready to merge.

PureWeen and others added 2 commits March 25, 2026 09:44
…otnet#34548)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

## Description

Adds a [gh-aw (GitHub Agentic
Workflows)](https://github.github.com/gh-aw/introduction/overview/)
workflow that automatically evaluates test quality on PRs using the
`evaluate-pr-tests` skill.

### What it does

When a PR adds or modifies test files, this workflow:
1. **Checks out the PR branch** (including fork PRs) in a pre-agent step
2. **Runs the `evaluate-pr-tests` skill** via Copilot CLI in a sandboxed
container
3. **Posts the evaluation report** as a PR comment using gh-aw
safe-outputs

### Triggers

| Trigger | When | Fork PR support |
|---------|------|-----------------|
| `pull_request` | Automatic on test file changes (`src/**/tests/**`) |
❌ Blocked by `pre_activation` gate |
| `workflow_dispatch` | Manual — enter PR number | ✅ Works for all PRs |
| `issue_comment` (`/evaluate-tests`) | Comment on PR | ⚠️ Same-repo
only (see Known Limitations) |

### Security model

| Layer | Implementation |
|-------|---------------|
| **gh-aw sandbox** | Agent runs in container with scrubbed credentials,
network firewall |
| **Safe outputs** | Max 1 PR comment per run, content-limited |
| **Checkout without execution** | `steps:` checks out PR code but never
executes workspace scripts |
| **Base branch restoration** | `.github/skills/`,
`.github/instructions/`, `.github/copilot-instructions.md` restored from
base branch after checkout |
| **Fork PR activation gate** | `pull_request` events blocked for forks
via `head.repo.id == repository_id` |
| **Pinned actions** | SHA-pinned `actions/checkout`,
`actions/github-script`, etc. |
| **Minimal permissions** | Each job declares only what it needs |
| **Concurrency** | One evaluation per PR, cancels in-progress |
| **Threat detection** | gh-aw built-in threat detection analyzes agent
output |

### Files added/modified

- `.github/workflows/copilot-evaluate-tests.md` — gh-aw workflow source
- `.github/workflows/copilot-evaluate-tests.lock.yml` — Compiled
workflow (auto-generated by `gh aw compile`)
- `.github/skills/evaluate-pr-tests/scripts/Gather-TestContext.ps1` —
Test context gathering script (binary-safe file download, path traversal
protection)
- `.github/instructions/gh-aw-workflows.instructions.md` — Copilot
instructions for gh-aw development

### Known Limitations

**Fork PR evaluation via `/evaluate-tests` comment is not supported in
v1.** The gh-aw platform inserts a `checkout_pr_branch.cjs` step after
all user steps, which may overwrite base-branch skill files restored for
fork PRs. This is a known gh-aw platform limitation — user steps always
run before platform-generated steps, with no way to insert steps after.

**Workaround:** Use `workflow_dispatch` (Actions UI → "Run workflow" →
enter PR number) to evaluate fork PRs. This trigger bypasses the
platform checkout step entirely and works correctly.

**Related upstream issues:**
- [github/gh-aw#18481](github/gh-aw#18481) —
"Using gh-aw in forks of repositories"
- [github/gh-aw#18518](github/gh-aw#18518) —
Fork detection and warning in `gh aw init`
- [github/gh-aw#18520](github/gh-aw#18520) —
Fork context hint in failure messages
- [github/gh-aw#18521](github/gh-aw#18521) —
Fork support documentation

### Fixes

- Fixes dotnet#34602

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
## Summary

Enables the copilot-evaluate-tests gh-aw workflow to run on fork PRs by
adding `forks: ["*"]` to the `pull_request` trigger and removing the
fork guard from `Checkout-GhAwPr.ps1`.

## Changes

1. **copilot-evaluate-tests.md**: Added `forks: ["*"]` to opt out of
gh-aw auto-injected fork activation guard. Scoped `Checkout-GhAwPr.ps1`
step to `workflow_dispatch` only (redundant for other triggers since
platform handles checkout).

2. **copilot-evaluate-tests.lock.yml**: Recompiled via `gh aw compile` —
fork guard removed from activation `if:` conditions.

3. **Checkout-GhAwPr.ps1**: Removed the `isCrossRepository` fork guard.
Updated header docs and restore comments to accurately describe behavior
for all trigger×fork combinations (including corrected step ordering).

4. **gh-aw-workflows.instructions.md**: Updated all stale references to
the removed fork guard. Documented `forks: ["*"]` opt-in, clarified
residual risk model for fork PRs, and updated troubleshooting table.

## Security Model

Fork PRs are safe because:
- Agent runs in **sandboxed container** with all credentials scrubbed
- Output limited to **1 comment** via `safe-outputs: add-comment: max:
1`
- Agent **prompt comes from base branch** (`runtime-import`) — forks
cannot alter instructions
- Pre-flight check catches missing `SKILL.md` if fork isn't rebased on
`main`
- No workspace code is executed with `GITHUB_TOKEN` (checkout without
execution)

## Testing

- ✅ `workflow_dispatch` tested against fork PR dotnet#34621
- ✅ Lock.yml statically verified — fork guard removed from `if:`
conditions
- ⏳ `pull_request` trigger on fork PRs can only be verified post-merge
(GitHub Actions reads lock.yml from default branch)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@MauiBot

MauiBot commented Mar 26, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 AI Summary

📊 Expand Full Review — 9663717 · Address review feedback: add Superview null guard and enable MacCatalyst test
🔍 Pre-Flight — Context & Validation

Issue: #26397 - [IOS, Mac] Inconsistent Resize Behavior for Header/Footer
Issue 2: #33501 - Enable Shell Flyout Header/Footer resize tests on iOS/Catalyst
PR: #28713 - [IOS] Inconsistent Resize Behavior for Header/Footer - fix
Platforms Affected: iOS, macOS (Mac Catalyst) — Android/Windows NOT affected
Files Changed: 3 total: 1 agent-session file (should not be in PR), 1 fix, 1 test

Key Findings

  • Bug: Shell Flyout header/footer sizes toggle inconsistently on iOS/macCatalyst — sizes vary each tap because ShellFlyoutHeaderContainer had no handler for measure-invalidation signals from child views
  • Fix: ShellFlyoutHeaderContainer now implements IPlatformMeasureInvalidationController — InvalidateMeasure() calls SizeThatFits and updates the view's Frame directly, returns false to stop propagation
  • PureWeen (first review) requested using "propagation method by @albyrock87" — author switched from MeasureInvalidated event subscription to IPlatformMeasureInvalidationController (correct)
  • albyrock87 (author of interface) commented: "This may have bad performance, but we'll solve it with [UIKit] Avoid useless measure invalidation propagation cycles #33459" and confirmed "Yes it's an acceptable workaround indeed!"
  • Prior agent review (Jan 2026): Gate ✅ PASSED, recommended APPROVE. That review found a Superview null-guard bug; author addressed it in latest commit (now uses Superview?.Frame.Width ?? Frame.Width)
  • Gate ✅ PASSED (latest run confirms fix works on iOS)
  • ⚠️ PR includes .github/agent-pr-session/pr-28713.md — this agent session file should not be committed as part of the code change
  • Test change: #if ANDROID → #if ANDROID || IOS || MACCATALYST (also enables MacCatalyst, which is correct per issue report)

Fix Candidates

# Source Approach Test Result Files Changed Notes
PR PR #28713 Implement IPlatformMeasureInvalidationController on ShellFlyoutHeaderContainer — intercept measure invalidation, call SizeThatFits, update Frame directly, stop propagation ✅ PASSED (Gate) ShellFlyoutHeaderContainer.cs (+12 -1) Author-acknowledged performance cost, tracked in #33459

🔧 Fix — Analysis & Comparison

Fix Candidates

# Source Approach Test Result Files Changed Notes
1 try-fix (claude-opus-4.6) IPlatformMeasureInvalidationController routing through SetNeedsLayout() + OnHeaderSizeChanged() event chain ✅ PASS ShellFlyoutHeaderContainer.cs (+15/-1) Reuses existing layout manager chain; slightly more architecturally consistent
2 try-fix (claude-sonnet-4.6) Subscribe to MeasureInvalidated event in ShellFlyoutContentRenderer ✅ PASS ShellFlyoutContentRenderer.cs (+19/-1) ⚠️ Uses deprecated event-subscription pattern explicitly rejected by PureWeen
3 try-fix (gpt-5.3-codex) IPlatformMeasureInvalidationController with SetNeedsLayout() only ❌ FAIL ShellFlyoutHeaderContainer.cs Async — frame not updated before test assertions
4 try-fix (gpt-5.4) IPlatformMeasureInvalidationController with SetNeedsLayout() + LayoutIfNeeded() ❌ FAIL ShellFlyoutHeaderContainer.cs Forces UIKit layout cycle but doesn't propagate far enough to outer flyout container
PR PR #28713 IPlatformMeasureInvalidationController — SizeThatFits + direct Frame update, stops propagation ✅ PASS (Gate) ShellFlyoutHeaderContainer.cs (+12/-1) Simplest, self-contained; performance cost acknowledged, tracked in #33459

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 NO NEW IDEAS Space exhausted: SizeThatFits must be called (directly or via chain); SetNeedsLayout variants fail
claude-sonnet-4.6 2 NO NEW IDEAS Deprecated event pattern was the only alternative; both passing approaches require synchronous size computation
gpt-5.3-codex 2 NO NEW IDEAS Confirmed: pure-UIKit-layout approaches insufficient without calling SizeThatFits explicitly
gpt-5.4 2 NO NEW IDEAS LayoutIfNeeded() variant exhausted; no further UIKit layout tricks available

Exhausted: Yes — all 4 models queried, no new ideas
Key Insight: Fixes require synchronous size computation (SizeThatFits). SetNeedsLayout() alone or with LayoutIfNeeded() cannot update the flyout container frame in time. The only viable IPlatformMeasureInvalidationController implementations call SizeThatFits either directly (PR) or indirectly via event chain (Attempt 1).

Selected Fix: PR's fix — simpler (12 vs 15 LOC), more self-contained (no dependency on OnHeaderSizeChanged internal event chain), empirically validated by Gate, approved by albyrock87, implements the IPlatformMeasureInvalidationController pattern as requested by PureWeen.


📋 Report — Final Recommendation

✅ Final Recommendation: APPROVE

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE iOS/macCatalyst, Shell Flyout header/footer, 3 changed files (1 fix, 1 test, 1 agent session)
Gate ✅ PASSED iOS — tests FAIL without fix, PASS with fix
Try-Fix ✅ COMPLETE 4 attempts: 2 ✅ PASS, 2 ❌ FAIL; cross-pollination exhausted
Report ✅ COMPLETE

Summary

PR #28713 fixes inconsistent header/footer resize behavior in Shell Flyout on iOS/macCatalyst. When a user tapped "Resize Header/Footer" repeatedly, sizes didn't toggle consistently between small (60px) and large (200px). The fix implements IPlatformMeasureInvalidationController on ShellFlyoutHeaderContainer, the pattern explicitly requested by reviewer PureWeen and created by @albyrock87. Gate confirmed tests pass on iOS. One minor cleanup item needed.

Root Cause

ShellFlyoutHeaderContainer (a UIContainerView subclass) had no handler for the measure-invalidation propagation signal that the MAUI platform fires when a child view changes size. When the header's child MAUI view changed its desired height, the propagation reached ShellFlyoutHeaderContainer but was ignored — the container's UIKit Frame was not updated. On subsequent layout passes, the stale frame was used, causing inconsistent sizing.

Fix Quality

Approach: Implements IPlatformMeasureInvalidationController.InvalidateMeasure() — calls SizeThatFits with the superview's width (with null guard) and directly updates Frame. Returns false to stop propagation since the container handles it locally. Empty InvalidateAncestorsMeasuresWhenMovedToWindow() is appropriate (no pending-window state needed here).

Strengths:

  • Correctly uses IPlatformMeasureInvalidationController as requested by PureWeen (the approved propagation pattern)
  • Superview null guard added (previous review feedback addressed): Superview?.Frame.Width ?? Frame.Width
  • Minimal, self-contained change (12 LOC net-add)
  • Consistent with other implementations in the codebase (TemplatedCell, MauiCollectionView, VisualElementRenderer)
  • Gate ✅ PASSED empirically; @albyrock87 confirmed "acceptable workaround"

Try-Fix comparison: Two independent alternatives also passed (Attempt 1: route through OnHeaderSizeChanged(); Attempt 2: MeasureInvalidated event). Attempt 1 is comparable but adds more complexity. Attempt 2 uses the deprecated event-subscription pattern explicitly rejected by PureWeen. The PR's fix is the simplest and most aligned with reviewer expectations.

Performance note: albyrock87 noted SizeThatFits called synchronously has a performance cost, tracked in issue #33459 and PR #33459. This is a known, accepted trade-off for the workaround.

Selected Fix: PR's fix — simplest passing approach, implements the team's preferred pattern, empirically validated.

Issues to Address Before Merge

Severity Issue File Action
🔴 Must Fix .github/agent-pr-session/pr-28713.md committed in PR .github/agent-pr-session/pr-28713.md Remove this agent session file from the commit — it should not be part of the code change
🟡 Minor MACCATALYST added to test #if but issue title says "[IOS]" — confirm MacCatalyst fix is also validated HeaderFooterShellFlyout.cs:70 Verify fix also works on MacCatalyst or add tracking note if not tested

Decision

✅ APPROVE — The fix is correct, minimal, uses the recommended pattern, and passes all tests. Remove the agent session file before merge.


@kubaflo
kubaflo merged commit 46905f8 into dotnet:inflight/current Apr 2, 2026
7 of 17 checks passed
PureWeen pushed a commit that referenced this pull request Apr 2, 2026
- Replace non-existent PR numbers (#34000, #33500, #33000, #34100)
  with real merged PRs (#34024, #34727, #31202, #28713, #34723)
- Add "in dotnet/maui" to all prompts to prevent agent asking for repo
- All PRs verified as real merged PRs with actual code changes

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
devanathan-vaithiyanathan pushed a commit to devanathan-vaithiyanathan/maui that referenced this pull request Apr 9, 2026
kubaflo added a commit to kubaflo/maui that referenced this pull request Apr 13, 2026
The InvalidateMeasure override was directly setting Frame height to
the full measured content size, which conflicted with the
ShellFlyoutLayoutManager's scroll-based header resizing (e.g.,
CollapseOnScroll shrinking from 250px to MinimumHeightRequest 100px).

Instead of setting Frame directly, we now update MeasuredHeight via
SizeThatFits and trigger OnHeaderSizeChanged to let the layout manager
handle Frame updates correctly for all FlyoutHeaderBehavior modes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kubaflo added a commit that referenced this pull request Apr 13, 2026
kubaflo added a commit to kubaflo/maui that referenced this pull request Apr 13, 2026
The InvalidateMeasure override was directly setting Frame height to
the full measured content size, which conflicted with the
ShellFlyoutLayoutManager's scroll-based header resizing (e.g.,
CollapseOnScroll shrinking from 250px to MinimumHeightRequest 100px).

Instead of setting Frame directly, we now update MeasuredHeight via
SizeThatFits and trigger OnHeaderSizeChanged to let the layout manager
handle Frame updates correctly for all FlyoutHeaderBehavior modes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kubaflo added a commit to kubaflo/maui that referenced this pull request Apr 13, 2026
After PR dotnet#28713 added InvalidateMeasure to ShellFlyoutHeaderContainer,
the header height after scrolling may include the safe area margin
(~44px) depending on the content type. This is correct behavior -
InvalidateMeasure properly re-measures the header container including
its safe area margin.

Update the test assertions to:
- Accept header height between headerRequestedHeight and
  headerRequestedHeight + safeAreaTop (accommodates both ShellItems
  which don't trigger OnScrolled, and CollectionView/ScrollView which do)
- Use scrolledBox.Height instead of headerRequestedHeight in the scroll
  position assertion, making it self-consistent with the actual height
- Fix typos in assertion messages

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kubaflo added a commit that referenced this pull request Apr 14, 2026
<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Description of Change

Fixes the `FlyoutHeaderScroll` device test regression introduced by PR
#28713.

After PR #28713 added `IPlatformMeasureInvalidationController` to
`ShellFlyoutHeaderContainer`, the header height after scrolling may
include the safe area margin (~44px) depending on the content type. This
is correct behavior — `InvalidateMeasure` properly re-measures the
header container including its safe area margin.

**Changes (test only, no core code changes):**
- Height assertion: accept header height between `headerRequestedHeight`
and `headerRequestedHeight + safeAreaTop` (accommodates both ShellItems
which don't trigger `OnScrolled`, and CollectionView/ScrollView which
do)
- Scroll position assertion: use `scrolledBox.Height` instead of
hardcoded `headerRequestedHeight`, making it self-consistent with the
actual measured height
- Fix typos in assertion messages

### Issues Fixed

Fixes FlyoutHeaderScroll device test regression from #28713

---------
kubaflo added a commit that referenced this pull request Apr 14, 2026
Fixes the FlyoutHeaderScroll device test regression introduced by PR #28713.

- Height assertion: accept header height between headerRequestedHeight and headerRequestedHeight + safeAreaTop
- Scroll position assertion: use scrolledBox.Height instead of hardcoded headerRequestedHeight
- Fix typos in assertion messages

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kubaflo added a commit to kubaflo/maui that referenced this pull request Apr 14, 2026
After PR dotnet#28713 added InvalidateMeasure to ShellFlyoutHeaderContainer,
the header height after scrolling may include the safe area margin
(~44px) depending on the content type. This is correct behavior -
InvalidateMeasure properly re-measures the header container including
its safe area margin.

Update the test assertions to:
- Accept header height between headerRequestedHeight and
  headerRequestedHeight + safeAreaTop (accommodates both ShellItems
  which don't trigger OnScrolled, and CollectionView/ScrollView which do)
- Use scrolledBox.Height instead of headerRequestedHeight in the scroll
  position assertion, making it self-consistent with the actual height
- Fix typos in assertion messages

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kubaflo added a commit that referenced this pull request Apr 14, 2026
### Description of Change

Fixes the `FlyoutHeaderScroll` device test regression introduced by PR
#28713.

After PR #28713 added `IPlatformMeasureInvalidationController` to
`ShellFlyoutHeaderContainer`, the header height after scrolling may
include the safe area margin (~44px) depending on the content type.

**Changes (test only, no core code changes):**
- Height assertion: accept header height between `headerRequestedHeight`
and `headerRequestedHeight + safeAreaTop`
- Scroll position assertion: use `scrolledBox.Height` instead of
hardcoded `headerRequestedHeight`
- Fix typos in assertion messages

### Issues Fixed

Fixes FlyoutHeaderScroll device test regression from #28713

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@PureWeen PureWeen mentioned this pull request Apr 14, 2026
devanathan-vaithiyanathan pushed a commit to Tamilarasan-Paranthaman/maui that referenced this pull request Apr 21, 2026
Ahamed-Ali pushed a commit that referenced this pull request Apr 22, 2026
<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

Fixes the `FlyoutHeaderScroll` device test regression introduced by PR

After PR #28713 added `IPlatformMeasureInvalidationController` to
`ShellFlyoutHeaderContainer`, the header height after scrolling may
include the safe area margin (~44px) depending on the content type. This
is correct behavior — `InvalidateMeasure` properly re-measures the
header container including its safe area margin.

**Changes (test only, no core code changes):**
- Height assertion: accept header height between `headerRequestedHeight`
and `headerRequestedHeight + safeAreaTop` (accommodates both ShellItems
which don't trigger `OnScrolled`, and CollectionView/ScrollView which
do)
- Scroll position assertion: use `scrolledBox.Height` instead of
hardcoded `headerRequestedHeight`, making it self-consistent with the
actual measured height
- Fix typos in assertion messages

Fixes FlyoutHeaderScroll device test regression from #28713

---------
Ahamed-Ali pushed a commit that referenced this pull request Apr 22, 2026
### Description of Change

Fixes the `FlyoutHeaderScroll` device test regression introduced by PR
#28713.

After PR #28713 added `IPlatformMeasureInvalidationController` to
`ShellFlyoutHeaderContainer`, the header height after scrolling may
include the safe area margin (~44px) depending on the content type.

**Changes (test only, no core code changes):**
- Height assertion: accept header height between `headerRequestedHeight`
and `headerRequestedHeight + safeAreaTop`
- Scroll position assertion: use `scrolledBox.Height` instead of
hardcoded `headerRequestedHeight`
- Fix typos in assertion messages

### Issues Fixed

Fixes FlyoutHeaderScroll device test regression from #28713

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PureWeen added a commit that referenced this pull request Apr 29, 2026
## Blazor
- Fix: Filter precompressed RCL assets from MAUI Blazor Hybrid APKs by
@mattleibow in #33917
  <details>
  <summary>🔧 Fixes</summary>

- [.NET MAUI Blazor Hybrid App should not precompress
assets](#33773)
  </details>

- [Windows] Fix for Runtime error when closing external window with WPF
Webview Control by @BagavathiPerumal in
#34006
  <details>
  <summary>🔧 Fixes</summary>

- [Runtime error when closing external window with WPF Webview
Control](#32944)
  </details>

## Button
- [Android] ImageButton CornerRadius not being applied - fix by @kubaflo
in #30074
  <details>
  <summary>🔧 Fixes</summary>

- [ImageButton CornerRadius not being applied on
Android](#23854)
  </details>

- Fix Disabled visual state ignored when Button has locally-set
BackgroundColor/TextColor by @Dhivya-SF4094 in
#34444
  <details>
  <summary>🔧 Fixes</summary>

- [[regression/9.0] VisualState "Disabled" is not properly applied for
Button with custom
appearance](#34363)
  </details>

## CollectionView
- Fix CollectionView grid spacing updates for first row and column by
@KarthikRajaKalaimani in #34527
  <details>
  <summary>🔧 Fixes</summary>

- [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item
Spacing - horizontally updating the spacing only applies to the second
column](#34257)
  </details>

- Fix CollectionView record struct selection on Windows by
@jeremy-visionaid in #33488

- [Android] Ensure disconnected ItemsViewHandler doesn't hold onto the
items source by @filipnavara in
#24610
  <details>
  <summary>🔧 Fixes</summary>

- [Crash on NullReferenceException with measurement cells in
CollectionView](#24304)
  </details>

- [Windows] Fixed VisualState Setters not working properly for
CollectionView by @Dhivya-SF4094 in
#27230
  <details>
  <summary>🔧 Fixes</summary>

- [VisualState Setters not working properly on Windows for a
CollectionView](#27086)
- [[regression/8.0.3] [Windows][CollectionView]Label Disappear when set
Style in
ContentPage.Resources](#19209)
- [[Windows] Label style defined as ContentPage Resource doesn't
propagate to
CollectionView](#18701)
  </details>

- [Windows] Fixed Margin doesn't work inside CollectionView EmptyView by
@Dhivya-SF4094 in #29897
  <details>
  <summary>🔧 Fixes</summary>

- [Margin doesn't work inside CollectionView
EmptyView](#8494)
  </details>

- [Android, Windows] Fix CarouselView PreviousPosition/PreviousItem
incorrect during animated ScrollTo() by @praveenkumarkarunanithi in
#34570
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] CurrentItemChangedEventArgs.PreviousItem and
PositionChangedEventArgs.PreviousPosition Not Updating Correctly When
Using ScrollTo or Setting
Position](#29544)
  </details>

- [iOS] CarouselView2: Update internal scroll indicators for
compositional layout by @SubhikshaSf4851 in
#33639
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Horizontal Scroll Bar Not Visible on CarouselView
(CV2)](#29390)
  </details>

- [CarouselViewHandler2] Fir fox CurrentItem does not work when
ItemSpacing is set by @SyedAbdulAzeemSF4852 in
#32135
  <details>
  <summary>🔧 Fixes</summary>

- [[CarouselViewHandler2] CurrentItem does not work when ItemSpacing is
set](#32048)
  </details>

- [iOS] Fix for Incorrect Scroll in Loop Mode When CurrentItem Is Not
Found in ItemsSource by @SyedAbdulAzeemSF4852 in
#32141
  <details>
  <summary>🔧 Fixes</summary>

- [[Android & iOS] Setting an invalid CurrentItem causes scroll to last
item in looped
CarouselView](#32139)
  </details>

- [Android] IndicatorView: Add TalkBack accessibility descriptions for
indicators by @praveenkumarkarunanithi in
#31775
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] IndicatorView does not convey correct accessibility
information](#31446)
  </details>

- [iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating
Correctly When Items Are Added Dynamically by @NanthiniMahalingam in
#32191
  <details>
  <summary>🔧 Fixes</summary>

- [[.NET10] I9 - Scroll_Position - "KeepLastItemInView" does not keep
the last item at the end of the displayed list when adding new
items.](#31825)
  </details>

- [Windows, Android] Resolved issue with dynamic Header/Footer
reassignment in CollectionView. by @prakashKannanSf3972 in
#28403
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Android] Toggling Header/Footer in CollectionView
Dynamically is not working](#27959)
- [CollectionView HeaderTemplate and FooterTemplate are not displayed
when ItemsSource is initially set to
null](#28337)
- [[Android] Header and Footer Not Visible in CollectionView When
EmptyView is Selected
First](#28351)
  </details>

- [Android] Fix CollectionView inside disabled RefreshView blocks scroll
by @Vignesh-SF3580 in #34702
  <details>
  <summary>🔧 Fixes</summary>

- [C6-The C6 page cannot scroll on Windows and Android
platforms.](#34666)
  </details>

- [Android] CollectionView: Fix SelectedItem visual state not applying
when re-selecting same item by @KarthikRajaKalaimani in
#31591
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView - SelectedItem visual state manager not
working](#20062)
  </details>

- [Windows] Fixed CollectionView.EmptyView can not be removed by setting
it to Null by @Dhivya-SF4094 in
#29487
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] CollectionView.EmptyView can not be removed by setting it
to Null](#18657)
- [[Windows] EmptyViewTemplate Not Working in
CarouselView](#29463)
- [EmptyViewTemplate does not do
anything](#18551)
- [[MAUI] I5_EmptyView - The data template selector cannot display the
correct string.](#23330)
  </details>

- [iOS] Support for IsSwipeEnabled on CarouselView2 by @kubaflo in
#29996
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] IsSwipeEnabled Not Working on CarouselView
(CV2)](#29391)
  </details>

- [iOS, MacOS] Fixed FlowDirection not working on Header/Footer in
CollectionView by @Dhivya-SF4094 in
#32775
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, MacOS] FlowDirection not working on Header/Footer in
CollectionView](#32771)
  </details>

- [iOS] CollectionView: Fix drag-and-drop reordering into empty groups
by @SuthiYuvaraj in #34151
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView Drag and Drop Reordering Can't Drop in Empty
Group](#12008)
  </details>

- [Android] CollectionView: Fix drag-and-drop reordering into empty
groups by @SuthiYuvaraj in #31867
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView Drag and Drop Reordering Can't Drop in Empty
Group](#12008)
  </details>

- [iOS] Fix vertical CarouselView MandatorySingle snapping on iOS by
@Vignesh-SF3580 in #34700
  <details>
  <summary>🔧 Fixes</summary>

- [CarouselView vertical snap points ignored on iOS with
Microsoft.Maui.Controls v10.0.20 (regression from
v9.0.120)](#33308)
  </details>

- [iOS26] Fix CarouselView scrolling to wrong item when navigating to
last item by @Vignesh-SF3580 in
#34013
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS 26] CarouselView does not scroll to the correct last
item](#33770)
  </details>

- Fixed the OnPlatform does not work for header property in Collection
view by @NanthiniMahalingam in #28935
  <details>
  <summary>🔧 Fixes</summary>

- [OnPlatform does not work in Header of
CollectionView](#25124)
  </details>

- [Android] [Candidate branch] Fix
VerifySelectedItemClearsOnNullAssignment,
CollectionViewSelectionShouldClear, SelectedItemVisualIsCleared UI test
failure on Android by @KarthikRajaKalaimani in
#34928

## DateTimePicker
- [iOS] Fix for DatePicker FlowDirection Not Working on iOS by
@SyedAbdulAzeemSF4852 in #30193
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] DatePicker FlowDirection Not Working on
iOS](#30065)
  </details>

## Drawing
- [Shapes] Line: Fix asymmetric Stretch.None path translation when
right/bottom edge overflows by @NirmalKumarYuvaraj in
#34385
  <details>
  <summary>🔧 Fixes</summary>

- [Line coordinates not computed
correctly](#11404)
- [Lines not drawing
correctly](#26961)
  </details>

- [Android] Fixed GraphicsView drawable is visible outside the canvas by
@NirmalKumarYuvaraj in #28353
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] GraphicsView, The drawn image can also be visible outside
the canvas](#20834)
  </details>

- Fixed Custom Drawable does not support binding by @NirmalKumarYuvaraj
in #29442
  <details>
  <summary>🔧 Fixes</summary>

- [Custom IDrawable control does not databind to a model property when
used inside a CollectionView
ItemTemplate](#20991)
  </details>

- Added a support for GradientBrushes on Shape.Stroke by @kubaflo in
#22208
  <details>
  <summary>🔧 Fixes</summary>

- [GradientBrushes are not supported on
Shape.Stroke](#21983)
  </details>

## Editor
- Fixed Editor HorizontalTextAlignment does not update at run time by
@NirmalKumarYuvaraj in #25129
  <details>
  <summary>🔧 Fixes</summary>

- [Editor HorizontalTextAlignment Does not
Works.](#10987)
- [[iOS/MacOs] Right-To-Left (RTL) alignment is not applied to Editor
placeholder](#30052)
  </details>

- [Windows] Fixed Entry Editor placeholder Text CharacterSpacing by
@SubhikshaSf4851 in #30324
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] CharacterSpacing not applied to Placeholder text in Entry
and Editor controls](#30071)
  </details>

## Entry
- [Windows] Fix fo setting an Entry's Keyboard to Date causes it to be
interpreted as a password input by @SyedAbdulAzeemSF4852 in
#29344
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Entry Keyboad-Type "Date" results in
Password-Entry](#28975)
  </details>

- [Android] Exception thrown when give more than 5000 characters to the
Text property of Entry. by @KarthikRajaKalaimani in
#30242
  <details>
  <summary>🔧 Fixes</summary>

- [Android crash when Entry has >5000
characters](#30144)
  </details>

## Essentials
- Bump MonoApiToolsMSBuildTasksPackageVersion to 0.5.0 and ship
Essentials.AI public APIs by @mattleibow via @Copilot in
#34574

- [Mac] DeviceDisplay.KeepScreenOn not being respected on Mac OS by
@HarishwaranVijayakumar in #32708
  <details>
  <summary>🔧 Fixes</summary>

- [[Mac Catalyst] DeviceDisplay.KeepScreenOn not being respected on Mac
OS](#26059)
  </details>

## Flyoutpage
- [Windows] FlyoutPage: update CollapseStyle at runtime by
@devanathan-vaithiyanathan in #29927
  <details>
  <summary>🔧 Fixes</summary>

- [Flyout Page SetCollapseStyle doesn't have any
change](#18200)
  </details>

## Gestures
- [Android] Fix for TapGestureRecognizer doesn't fire by
@HarishwaranVijayakumar in #34497
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TapGestureRecognizer doesn't
fire](#5825)
  </details>

## Image
- [Android] Fix Share.RequestAsync SecurityException on Android 10+
caused by missing ClipData by @HarishwaranVijayakumar in
#34417
  <details>
  <summary>🔧 Fixes</summary>

- [[Bug] Share.RequestAsync throws java.lang.SecurityException
(uid=1000) on Android 10+ due to missing
intent.ClipData](#34370)
  </details>

- [Windows]Fixed the MauiImage with logical name containing path issue
by @sheiksyedm in #32864
  <details>
  <summary>🔧 Fixes</summary>

- [MauiImage with LogicalName containing path - is not working on
Windows](#32356)
  </details>

- [Android, Windows & iOS] Fix Downsize/ScaleImage to maintain aspect
ratio and prevent upscaling by @SyedAbdulAzeemSF4852 in
#30808
  <details>
  <summary>🔧 Fixes</summary>

- [[Android & Windows] In GraphicsView, the aspect ratio is not
maintained when Downsize is called with both maxWidth and
maxHeight](#30803)
  </details>

## Label
- [iOS , macOS] Fixed Label text cropping when a width request is
specified on the label inside a VerticalStackLayout with specified width
request by @NanthiniMahalingam in
#29166
  <details>
  <summary>🔧 Fixes</summary>

- [Label text gets cropped when a width request is specified on the
label inside a
VerticalStackLayout](#28660)
- [[iOS] Label with a fixed WidthRequest has wrong
height](#26644)
  </details>

- [Android] Fix Label word wrapping clips text depending on alignment
and layout options by @Dhivya-SF4094 in
#34533
  <details>
  <summary>🔧 Fixes</summary>

- [Bug: Android Label word wrapping clips text depending on alignment
and layout options](#34459)
  </details>

- LineHeight and decorations for HTML Label - fix by @kubaflo in
#31202
  <details>
  <summary>🔧 Fixes</summary>

- [LineHeight with HTML Label not
working](#22193)
  - [lineheight is broken ](#22197)
  </details>

- [iOS] Fix Label with TailTruncation not rendering after
empty-to-non-empty text transition by @kubaflo in
#34812
  <details>
  <summary>🔧 Fixes</summary>

- [Label with LineBreakMode="TailTruncation" does not render text if
initial Text is null or empty on first render
(iOS)](#34591)
  </details>

## Layout
- [Android] Fix overflowing children clipped when parent Opacity < 1 by
@SyedAbdulAzeemSF4852 in #34565
  <details>
  <summary>🔧 Fixes</summary>

- [Maui Android parent view inappropriately creates clipping mask when
its opacity is less than 1, cropping out
children](#22038)
  </details>

- Fixed the FlexLayout reverse issue with the AlignContent by
@Ahamed-Ali in #32134
  <details>
  <summary>🔧 Fixes</summary>

- [FlexLayout alignment issue when Wrap is set to Reverse and
AlignContent is set to SpaceAround, SpaceBetween or
SpaceEvenly](#31565)
  </details>

- [iOS/Mac] Fixed BoxView in AbsoluteLayout did not return to its
default AutoSize for Height and Width after reset by @Dhivya-SF4094 in
#31648
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Catalyst] BoxView in AbsoluteLayout does not return to default
AutoSize for Height/Width after
reset](#31496)
  </details>

## Map
- [Windows] Implement WinUI 3 MapControl handler using Azure Maps by
@jfversluis in #34138

## Modal
- [Android] PopToRootAsync for modal pages - improvements by @kubaflo in
#26851
  <details>
  <summary>🔧 Fixes</summary>

- [Shell PopToRootAsync doesn't happen instantly - previous pages flash
quickly. Only happens in NET
9](#26846)
  </details>

- [Android] Fix HideSoftInputOnTapped doesn't work on Modal Pages by
@HarishwaranVijayakumar in #34770
  <details>
  <summary>🔧 Fixes</summary>

- [HideSoftInputOnTapped doesn't work on Modal
Pages](#34730)
  </details>

## Navigation
- [iOS] Alert popup may be displayed on wrong window when modal page
navigation is in progress - fix by @kubaflo in
#31016
  <details>
  <summary>🔧 Fixes</summary>

- [Alert popup may be displayed on wrong window when modal page
navigation is in progress on
iOS/MacOS](#30970)
  </details>

- [Android] Page: Fix OnNavigatedTo called twice when NavigationPage is
FlyoutPage Detail by @KarthikRajaKalaimani in
#31931
  <details>
  <summary>🔧 Fixes</summary>

- [NavigationPage and FlyoutPage both call OnNavigatedTo, so it is
called twice](#23902)
  </details>

## Picker
- Fixed the Picker didn't dismiss it when tapping outside on iOS and
MacCatalyst platform. by @KarthikRajaKalaimani in
#30067
  <details>
  <summary>🔧 Fixes</summary>

- [[regression/8.0.3] iOS Picker dismiss does not work when clicking
outside of the Picker](#19168)
  </details>

- [Windows] Fixed Picker items width wont resize back by
@SubhikshaSf4851 in #33042
  <details>
  <summary>🔧 Fixes</summary>

- [Picker items width won't resize back when its container window gets
resized down.](#32984)
  </details>

## RadioButton
- Fix TalkBack not correctly narrating RadioButtons with Content by
@SubhikshaSf4851 in #34521
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TalkBack does not correctly narrate RadioButtons with
Content](#34322)
  </details>

## SafeArea
- [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36
by @praveenkumarkarunanithi in #34239

## ScrollView
- [iOS] Preserve ScrollView offsets when Orientation changes to Neither
by @Vignesh-SF3580 in #34672
  <details>
  <summary>🔧 Fixes</summary>

- [Incorrect implementation of
ScrollView.Orientation](#34583)
  </details>

## Searchbar
- [Android] Fix SearchBar text bleeding between instances after
navigation by @SyedAbdulAzeemSF4852 in
#34703
  <details>
  <summary>🔧 Fixes</summary>

- [MAUI Android: SearchBar copies content from one to the
other](#20348)
  </details>

- Fixed SearchBar CursorPosition and SelectionLength not updating when
typing by @Dhivya-SF4094 in #34347
  <details>
  <summary>🔧 Fixes</summary>

- [SearchBar - CursorPosition and SelectionLength are not updated when
the user types](#30779)
  </details>

## SearchBar
- [Windows] Fixed SearchHandler issues by @Tamilarasan-Paranthaman in
#29520
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] SearchHandler APIs are not functioning
properly](#29493)
  </details>

## Shell
- [iOS, Mac] Fix for Background set to Transparent doesn't have the same
behavior as BackgroundColor Transparent by @HarishwaranVijayakumar in
#32245
  <details>
  <summary>🔧 Fixes</summary>

- [Background set to Transparent doesn't have the same behavior as
BackgroundColor =
Transparent](#22769)
  </details>

- [iOS] Fix App crash with NullReferenceException in
ShellSectionRenderer by @devanathan-vaithiyanathan in
#32109
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] App crash with NullReferenceException in
ShellSectionRenderer](#31961)
  </details>

- [Android] Fixed back button icon selection logic in
ShellToolbarTracker by @kubaflo in
#32080
  <details>
  <summary>🔧 Fixes</summary>

- [IconOverride in Shell.BackButtonBehavior does not
work.](#32050)
  </details>

- Fix TabBarIsVisible Not Updating Dynamically When Set on ShellContent
by @Vignesh-SF3580 in #33090
  <details>
  <summary>🔧 Fixes</summary>

- [Shell.TabBarIsVisible is not updated dynamically at
runtime](#32994)
  </details>

- [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab
bar, and Locked flyout position by @NanthiniMahalingam in
#32701
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support
RightToLeft (RTL)](#32419)
  </details>

- [IOS] Inconsistent Resize Behavior for Header/Footer - fix by @kubaflo
in #28713
  <details>
  <summary>🔧 Fixes</summary>

- [[IOS, Mac] Inconsistent Resize Behavior for
Header/Footer](#26397)
- [Enable Shell Flyout Header/Footer resize tests on
iOS/Catalyst](#33501)
  </details>

- [Android] Fix for SearchHandler retaining previous page SearchView
data in pages within Shell sections by @BagavathiPerumal in
#29545
  <details>
  <summary>🔧 Fixes</summary>

- [[Shell][Android] The truth is out there...but not on top tab search
handlers](#8716)
  </details>

- [Android] Fix empty space above TabBar after navigating back when
TabBar visibility is toggled by @praveenkumarkarunanithi in
#34324
  <details>
  <summary>🔧 Fixes</summary>

- [Empty space appears above TabBar after navigating back when TabBar
visibility is toggled](#33703)
- [Grid with SafeAreaEdges=Container has incorrect size when tab bar
appears](#34256)
  </details>

## SwipeView
- [Android] SwipeView: Use MeasureSpecMode.Exactly for SwipeItem layout
to fix text visibility by @Ahamed-Ali in
#27399
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Right SwipeView items are not visible in the
SwipeView.](#27367)
  </details>

- [Android] Prevent the tap that closes an open SwipeView from being
propagated to children by @sjordanGSS in
#24275
  <details>
  <summary>🔧 Fixes</summary>

- [Tapping to close a SwipeView will activate TapGestureRecognizers on
.Content](#23921)
  </details>

## Switch
- [iOS & Mac] Fix for SearchHandler retains previous page state when
switching top tabs by @BagavathiPerumal in
#34735
  <details>
  <summary>🔧 Fixes</summary>

- [[Shell] [iOS & Mac] SearchHandler retains previous page state when
switching top tabs](#34693)
  </details>

## TabbedPage
- [Android] Fixed NullReferenceException in app with TabBar after
returning from minimized state by @NirmalKumarYuvaraj in
#34779
  <details>
  <summary>🔧 Fixes</summary>

- [NullReferenceException in app with TabBar after returning from
minimized state](#34720)
  </details>

## Titlebar
- Fixed BindingContext of the Window TitleBar is not being passed on to
its child content. by @NirmalKumarYuvaraj in
#30080
  <details>
  <summary>🔧 Fixes</summary>

- [The BindingContext of the Window TitleBar is not being passed on to
its child content.](#24831)
  </details>

- [Windows/Mac] Fix RTL FlowDirection causes overlap with native window
control buttons in TitleBar by @devanathan-vaithiyanathan in
#30400
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Mac] RTL FlowDirection causes overlap with native window
control buttons in
TitleBar](#30399)
  </details>

## WebView
- [Windows] Fix WebView background color not being applied by
@SubhikshaSf4851 in #34599
  <details>
  <summary>🔧 Fixes</summary>

- [WebView background color has changed after update, can't
override.](#34518)
  </details>

- [Android] Fix for WebView/HybridWebView briefly flashes full screen
before layout completes by @praveenkumarkarunanithi in
#33207
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] HybridWebView briefly resizes to full screen when page is
opened before snapping back to correct
size](#31475)
  </details>

## Xaml
- Improved style inheritance by @kubaflo in
#31317
  <details>
  <summary>🔧 Fixes</summary>

- [Styles based on a style that is based on another style that uses
AppThemeBinding do not inherit properties
correctly.](#31280)
  </details>

- Fix for VisualStateManager Setter.TargetName failing when
ControlTemplate is applied by @BagavathiPerumal in
#33208
  <details>
  <summary>🔧 Fixes</summary>

- [Setter.TargetName + ControlTemplate
crash](#26977)
  </details>


<details>
<summary>🧪 Testing (4)</summary>

- [Testing] Additional Feature Matrix Event Test Cases for Slider and
ScrollView by @nivetha-nagalingam in
#34352
- [Testing] Fixed Build error on inflight/ candidate PR 34885 by
@NafeelaNazhir in #34891
- [Testing] Fixed UI test image failure in PR 34885 - [13/4/2026] by
@NafeelaNazhir in #34933
- Fixed test failure - CursorPositionUpdatesWhenSearchBarGainsFocus by
@Dhivya-SF4094 in #34938

</details>

<details>
<summary>📦 Other (3)</summary>

- Fix Loaded event not called for MAUI View added to native View by
@NirmalKumarYuvaraj in #34345
  <details>
  <summary>🔧 Fixes</summary>

- [Loaded event not called for MAUI View added to native
View](#34310)
  </details>
- Add public IAlertManager and IAlertManagerSubscription interfaces by
@Redth in #34228
  <details>
  <summary>🔧 Fixes</summary>

- [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`,
`DisplayPromptAsync`) needs a public extensibility
point](#34104)
  </details>
- Fix crash when displaying alerts on unloaded pages by @kubaflo in
#33288

</details>

<details>
<summary>📝 Issue References</summary>

Fixes #5825, Fixes #8494, Fixes #8716, Fixes #10987, Fixes #11404, Fixes
#12008, Fixes #18200, Fixes #18551, Fixes #18657, Fixes #18701, Fixes
#19168, Fixes #19209, Fixes #20062, Fixes #20348, Fixes #20834, Fixes
#20991, Fixes #21983, Fixes #22038, Fixes #22193, Fixes #22197, Fixes
#22769, Fixes #23330, Fixes #23854, Fixes #23902, Fixes #23921, Fixes
#24304, Fixes #24831, Fixes #25124, Fixes #26059, Fixes #26397, Fixes
#26644, Fixes #26846, Fixes #26961, Fixes #26977, Fixes #27086, Fixes
#27367, Fixes #27959, Fixes #28337, Fixes #28351, Fixes #28660, Fixes
#28975, Fixes #29390, Fixes #29391, Fixes #29463, Fixes #29493, Fixes
#29544, Fixes #30052, Fixes #30065, Fixes #30071, Fixes #30144, Fixes
#30399, Fixes #30779, Fixes #30803, Fixes #30970, Fixes #31280, Fixes
#31446, Fixes #31475, Fixes #31496, Fixes #31565, Fixes #31825, Fixes
#31961, Fixes #32048, Fixes #32050, Fixes #32139, Fixes #32356, Fixes
#32419, Fixes #32771, Fixes #32944, Fixes #32984, Fixes #32994, Fixes
#33308, Fixes #33501, Fixes #33703, Fixes #33770, Fixes #33773, Fixes
#34104, Fixes #34256, Fixes #34257, Fixes #34310, Fixes #34322, Fixes
#34363, Fixes #34370, Fixes #34459, Fixes #34518, Fixes #34583, Fixes
#34591, Fixes #34666, Fixes #34693, Fixes #34720, Fixes #34730

</details>

**Full Changelog**:
main...inflight/candidate
@github-actions github-actions Bot locked and limited conversation to collaborators May 3, 2026
@kubaflo kubaflo added the s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) label May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-flyout Flyout area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/ios s/agent-approved AI agent recommends approval - PR fix is correct and optimal s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Shell Flyout Header/Footer resize tests on iOS/Catalyst [IOS, Mac] Inconsistent Resize Behavior for Header/Footer

8 participants