Repository navigation
Conversation
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
mattleibow
left a comment
There was a problem hiding this comment.
@tj-devel709 @PureWeen this PR looks all nice, but since it touches focus and we have all sorts of bits of code, maybe there is a better person to review the focus changes?
| { | ||
| _dialog = CreateTimePickerDialog(hour, minute); | ||
| _dialog.Show(); | ||
| VirtualView.IsFocused = true; |
There was a problem hiding this comment.
Why is this needed here? The maui time p;icker is a text box, so that should work with normal focus commands?
Entry does this:
maui/src/Core/src/Handlers/Entry/EntryHandler.Android.cs
Lines 152 to 156 in 46096ff
I also see we double-override it in Controls:
maui/src/Controls/src/Core/Entry/Entry.Mapper.cs
Lines 23 to 29 in 46096ff
So basically, Focus support is all strage...
There was a problem hiding this comment.
I've added it so that focus is activated when the dialog is opened. Without it the control never recognises its focus status
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
c315c89 to
bf1753c
Compare
|
Closing this in favor of APIs we're adding into .NET 10 |
Issues Fixed
Fixes #26908