Repository navigation
[ci-scan] Add Hard Rule 10 for early exit on no scannable build - #7654
Merged
Merged
Conversation
95 consecutive ci-scan runs have skipped at Step 1 selection time (stale build window >14d) while consuming 350-470K effective tokens on the build-list fetch, instruction read, and reasoning. The 'and stop' sentence in Step 1 was a prose instruction; Hard Rule 10 elevates the no-scannable-build exit to the same level as the issue-cap and label rules — an inviolable invariant. When Step 1 determines no scannable build exists, the scanner must: - append the outcome line to MachineLearning-CI.txt - print | 0 | 0 | 0 | 1 | as the Step 7 tally (honest: 1 skipped) - emit noop and stop immediately - NOT fetch AzDO timeline, task logs, or Helix work items Updates Step 1's trailing sentence to reference Hard Rule 10 directly. Triggering signal: 14 prior ci-scan-feedback runs proposed this edit; git push failed each time, producing misfiled fallback issues #7627, #7630, #7636, #7637, #7639, #7640, #7641, #7642, #7643, #7644, #7645, #7646, #7648, #7650. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ci-scan agent prompt to make “no scannable build” an explicit hard invariant, ensuring the workflow exits immediately at Step 1 and reports the run as a skip (instead of continuing into later steps and consuming tokens).
Changes:
- Add Hard Rule 10 requiring an immediate early-exit when Step 1 finds no scannable build, including emitting
noopand reporting a skip tally. - Replace Step 1’s inline “record skip reason and stop” prose with a single authoritative reference to Hard Rule 10.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci-scan.agent.md | Adds Hard Rule 10 for mandatory early exit on empty build window; updates Step 1 to defer to that hard rule. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
…ep 7 table Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kotlarmilos
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rosebyte
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Hard Rule 10 to ci-scan.agent.md so the scanner exits immediately when Step 1 finds no scannable build instead of continuing through later steps and burning hundreds of thousands of tokens on a run that ends in a no-op. The rule appends the documented Step 7 coverage line, prints the full Step 7 summary table including the skipped-with-reason count, emits noop, and stops without fetching the AzDO timeline, downloading task logs, or querying Helix. This is the change the ci-scan-feedback workflow proposed repeatedly but could not push, and the lock file runtime-imports the prompt so no recompile is needed.