Repository navigation
Reverting dead unallignedCode paths - #1845
Merged
Merged
Conversation
Contributor
Author
|
@Ivanidzo4ka @eerhardt @TomFinley @tannergooding can you please review this one ? |
eerhardt
reviewed
Dec 10, 2018
eerhardt
reviewed
Dec 10, 2018
tannergooding
approved these changes
Dec 10, 2018
tannergooding
left a comment
tannergooding
left a comment
Member
There was a problem hiding this comment.
LGTM. A couple of nits on places where we could still be generating better code
…e tests done for odd input, enabled timeseries tests
eerhardt
reviewed
Dec 10, 2018
eerhardt
reviewed
Dec 10, 2018
| public static void MatrixTimesSource(bool transpose, AlignedArray matrix, AlignedArray source, AlignedArray destination, int stride) => SseUtils.MatTimesSrc(transpose, matrix, source, destination, stride); | ||
| private static bool Compat(AlignedArray a) | ||
| { | ||
| Contracts.AssertValue(a); |
Member
There was a problem hiding this comment.
Moving code like this is really hard to review. Did you make any changes to this code, or is it a straight copy from Sse.cs to this file?
Contributor
Author
There was a problem hiding this comment.
it is straight copy from sse.cs
Contributor
Author
There was a problem hiding this comment.
The only addition is the function GetVectorAlignment
Contributor
Author
|
@eerhardt can we merge this one ? |
Member
|
Since we are editing Time Series code, I think it would be good for @codemzs to sign off on the changes to it. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting unaligned CodePaths were added in #1218 and #1274
Related to #1838