Skip to content

DetectSpikeBy(Ssa|Iid) confidence param should be double #4058

Description

@esso23

This one is pretty simple. Confidence parameter in DetectIidSpike & DetectSpikeBySsa should be of type double. It makes no sense that it is of type Int32 since it is being cast to double when creating SsaSpikeDetector.Options() anyway.

Same thing goes for DetectChangePointBySsa, DetectIidChangePoint and possibly others.

Right now it is not possible to search only for "extreme spikes" (confidence = ~99.9 or even more) using these extension methods.

Thanks
Esso

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions