Skip to content

Non-standard naming in L-BFGS Learners (LogisticRegression, PoissonRegression) #2882

Description

@rogancarr

In LogisticRegression and PoissonRegression (which use the same L-BFGS base), we have a parameter IterationsToRemember that refers to the number of gradients to accumulate in the history. While this terminology makes sense, it's not what we usually encounter in the field.

In the literature, we see this referred to as the "history size" (see e.g. wikipedia).

In the various toolkits that expose an L-BFGS solver, they use:
Scikit Learn: Doesn't expose it.
Spark: NumberOfCorrections
TensorFlow: num_correction_pairs
PyTorch: history_size

I would vote for HistorySize, with the docs explaining what it is.

What do you all think? Any big feelings around this?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions