Analyzer - support unknown values for some untracked values

Currently the analyzer only tracks values which are "interesting", which really means System.Type or System.String. Both of these can carry DAM annotations. Everything is not tracked and flows through the system as TopValue which means "empty".

In some cases though, the intrinsic handling works with other types of values, for example integers or arrays. Analyzer has some basic handling of integers mostly around constants and some basic handling of arrays when created locally. But it doesn't track "unknown" values, instead it tracks the rest as "empty" value.

"empty" value means that it will not cause warnings (that's the purpose of the value), unlike "unknown" which typically produces warnings as it represents "can't figure this our statically".

This means that for example code like this:

class MyOwnGeneric<[DAM(All)] T> { }

static void MakeMyOwnGeneric(Type[] types)
{
     typeof(MyOwnGeneric).MakeGenericType(types); // No warning in the analyzer, linker warns
}

In this case analyzer doesn't warn because the parameter to MakeGenericType is "empty" value, and so the entire call is effectively ignored. Linker warns, because it knows that the type has requirements on the generic parameters, and thus if it can't figure out the generic arguments it needs to warn.

class MyOwnGeneric<[DAM(All)] T> { }

static void MakeMyOwnGeneric(int length)
{
     var types = new Type[length]; // Since length is unknown the array should be either treated as unknown as a whole, or at least its size should be as such
     types[0] = typeof(TestType);
     typeof(MyOwnGeneric).MakeGenericType(types); // No warning in the analyzer, linker warns
}

Currently since the length is treated as "empty", the value of the array creation is also "empty" -> no warnings.

I'm going to add method tracking as well - similar scenario for MethodInfo values:

void GenericMethod<[DAM(All)] T>() {}

static void MakeItAGeneric(MethodInfo method)
{
    method.MakeGenericMethod(typeof(TestType));  // linker warns, analyzer doesn't
}

Same reason - the untracked value is considered "empty" (unlike linker where it's "unknown").

Trim analyzer: Implement intrinsics handling of object.GetType

Trim analyzer: Implement intrinsics handling of object.GetType (dotne…

Navigation Menu

Repository navigation

Analyzer - support unknown values for some untracked values #2755

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Analyzer - support unknown values for some untracked values #2755

Description

Activity

vitek-karas commented on Apr 22, 2022

vitek-karas commented on Apr 22, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions