Repository navigation
Reduce the amount of concurrency in Deadlock_on_inserts_and_deletes_with_dependents_is_handled_correctly to a avoid sporadic timeout on LocalDB - #39180
Merged
Conversation
…ith_dependents_is_handled_correctly to a avoid sporadic timeout on LocalDB
AndriySvyryd
changed the title
AndriySvyryd
enabled auto-merge (squash)
October 6, 2026 02:41
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The revised scheduling may no longer exercise the competing lock sets required by the regression test.
Review effort: Lite
Findings: None
What changed in this PR
Reduces concurrency in the SQL Server deadlock regression test to avoid sporadic LocalDB timeouts.
Changes:
- Runs operations in smaller sequential waves.
- Retains repeated iterations and cleanup.
| File | Review |
|---|---|
test/EFCore.SqlServer.FunctionalTests/BatchingTest.cs |
Moderate concern: reduced overlap may weaken deadlock and retry coverage; preserve bounded competing operations. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Code Coverage OverviewLanguages: C# C# / code-coverageThe overall line coverage in commit 1a5139f in the Show a line coverage summary of the most impacted files.
|
wtgodbe
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to a avoid sporadic timeout on LocalDB