Skip to content

Fix test helper method override assertions for arbitrary parameters #38633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndriySvyryd merged 3 commits into from
Jul 16, 2026
Merged

Fix test helper method override assertions for arbitrary parameters #38633

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1309954
Fix test helper method override assertions for arbitrary parameters
JoasE Jul 15, 2026
d6c3ce1
Use short display name and add sql baseline string for generator
JoasE Jul 15, 2026
fac90cc
Remove temp sql baseline
JoasE Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions test/EFCore.Specification.Tests/TestUtilities/TestHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,17 +333,9 @@ public static void AssertAllMethodsOverridden(Type testClass)
foreach (var method in methods)
{
var parameters = method.GetParameters();
var hasAsyncParameter = parameters.Length == 1
&& parameters[0].ParameterType == typeof(bool);
var paramList = string.Join(", ", parameters.Select(x => $"{Infrastructure.TypeExtensions.ShortDisplayName(x.ParameterType)} {x.Name}"));
var argList = string.Join(", ", parameters.Select(x => x.Name));

if (parameters.Length > 0
&& !hasAsyncParameter)
{
continue;
}

var paramList = hasAsyncParameter ? "bool async" : "";
var argList = hasAsyncParameter ? "async" : "";
if (method.ReturnType == typeof(Task))
{
methodCalls.Append(
Expand Down
Loading