Skip to content

Mark some comments about Assembly.GetEntryAssembly as .NET Framework only - #10004

Merged
elinor-fung merged 2 commits into
dotnet:mainfrom
elinor-fung:get-entry-assembly
Jun 7, 2024
Merged

elinor-fung merged 2 commits into
dotnet:mainfrom
elinor-fung:get-entry-assembly

Conversation

@elinor-fung

Copy link
Copy Markdown
Member

The comments on Assembly.GetEntryAssembly behaviour around app domains and AppDomain.ExecuteAssembly only apply to .NET Framework.

cc @gewarren @jkotas @dotnet/appmodel

@elinor-fung
elinor-fung requested a review from a team as a code owner June 7, 2024 16:30

@gewarren gewarren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elinor-fung.

Comment thread xml/System.Reflection/Assembly.xml Outdated

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@learn-build-service-prod

Copy link
Copy Markdown

Learn Build status updates of commit a372860:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ⚠️Warning View Details

xml/System.Reflection/Assembly.xml

  • Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@learn-build-service-prod

Copy link
Copy Markdown

Learn Build status updates of commit d22a7c8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Reflection/Assembly.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants