Repository navigation
Merge main into live - #33394
Merged
Merged
Merge main into live#33394
Conversation
This description of the `Changed` event behavior is incomplete since the event is also triggered when some item is changed via the indexer `set` accessor of the generic class `MyList<T>`.
My suggestion is to modify the indexer `set` accessor code of the `MyList<T>` class to only assign a value to an item at a specific index and call the `OnChange()` virtual method if the value of the item has really been changed. This modification will make the code more confident with the event name.
The current version of the previous example doesn't have a static method called `Square`, but instead a lambda expression to create an anonymous function: `(x) => x * x`.
Fixes dotnet/roslyn#66103 See dotnet/roslyn#66103 (comment) for conclusion of our discussion. FYI @BillWagner
add missing word
* changed description of `IsNot` original: "Use the `IsNot` keyword instead of `Not ... Is Nothing`." proposal-1: "Use `... IsNot Nothing` instead of `Not ... Is Nothing`." proposal-2: "Use `x IsNot y` instead of `Not x Is y`." * Update docs/visual-basic/programming-guide/program-structure/coding-conventions.md * Apply suggestions from code review Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Co-authored-by: BillWagner <BillWagner@users.noreply.github.com>
These OSes are not supported by .NET Core for quite a while.
* Update Linux installation dependencies * Fixed links * Address review comments
This was referenced Jan 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please don't squash-merge this PR.