Skip to content

Merge main into live - #33394

Merged
BillWagner merged 15 commits into
livefrom
main
Jan 10, 2023
Merged

BillWagner merged 15 commits into
livefrom
main

Conversation

@ghost

@ghost ghost commented Jan 10, 2023

Copy link
Copy Markdown

Please don't squash-merge this PR.

rogeriomc and others added 15 commits January 9, 2023 09:32
This description of the `Changed` event behavior is incomplete since the event is also triggered when some item is changed via the indexer `set` accessor of the generic class `MyList<T>`.
My suggestion is to modify the indexer `set` accessor code of the `MyList<T>` class to only assign a value to an item at a specific index and call the `OnChange()` virtual method if the value of the item has really been changed. This modification will make the code more confident with the event name.
The current version of the previous example doesn't have a static method called `Square`, but instead a lambda expression to create an anonymous function: `(x) => x * x`.
add missing word
* changed description of `IsNot`

original: "Use the `IsNot` keyword instead of `Not ... Is Nothing`."

proposal-1: "Use `... IsNot Nothing` instead of `Not ... Is Nothing`."
proposal-2: "Use `x IsNot y` instead of `Not x Is y`."

* Update docs/visual-basic/programming-guide/program-structure/coding-conventions.md

* Apply suggestions from code review

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
Co-authored-by: BillWagner <BillWagner@users.noreply.github.com>
These OSes are not supported by .NET Core for quite a while.
* Update Linux installation dependencies

* Fixed links

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.