Repository navigation
Document ProtoBuf repeated/map use read-only props - #19908
Merged
Merged
Conversation
Document that the Protocol Buffer generated C# code for repeated and map fields use read-only properties that have mutable instances. Include links to the reference documentation for `RepeatedField<T>` and `MapField<K, V>`. These improvements are based on grpc/grpc-dotnet#1012
Contributor
Author
|
@shirhatti, can you let me know when you think you'll be able to review this? If you won't have time in the next couple of days, can you find someone else to help review? Thanks. |
shirhatti
reviewed
Aug 14, 2020
shirhatti
reviewed
Aug 14, 2020
Contributor
|
I like the text changes. I think this is okay to merge once we have the links in the right places and can verify it doesn't breaking rendering of the PDF |
Contributor
Author
|
The links are working on the rendered HTML pages (map, repeated). I don't know how to check the PDF output. I don't see anything about that on the build results page. Do you know how to check the PDF output? |
Contributor
Author
|
@shirhatti, anything else needed here? |
shirhatti
reviewed
Aug 25, 2020
shirhatti
reviewed
Aug 25, 2020
shirhatti
approved these changes
Aug 25, 2020
BillWagner
added
dotnet-architecture/svc
grpc/subsvc
and removed
📚 Area - .NET Architecture Guide
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document that the Protocol Buffer generated C# code for repeated and map
fields use read-only properties that have mutable instances. Include
links to the reference documentation for
RepeatedField<T>andMapField<K, V>.These improvements are based on
grpc/grpc-dotnet#1012