This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Add CodeDom.CodeValidator tests and fix some bugs - #39585
Merged
Merged
Conversation
hughbe
commented
Jul 18, 2019
hughbe
commented
Jul 18, 2019
maryamariyan
requested review from
maryamariyan
and removed request for
maryamariyan
August 8, 2019 08:17
buyaa-n
reviewed
Aug 14, 2019
krwq
reviewed
Aug 14, 2019
krwq
reviewed
Aug 14, 2019
krwq
approved these changes
Aug 14, 2019
Author
|
Would be great to get this merged. I've written loads of other CodeDom tests (aiming for 100% code coverage woo!) that depend on this PR |
Member
|
@hughbe new changes LGTM, you will need to disable/fixup tests so that full framework also passes |
krwq
reviewed
Sep 9, 2019
| // Because CodeDomProvider.CreateProvider(string.Empty) throws an internal ConfigurationErrorsException, | ||
| // rather than the publically exposed exception, we need to call BinaryFormatterHelpers.AssertExceptionDeserializationFails | ||
| // through reflection. | ||
| MethodInfo method = typeof(BinaryFormatterHelpers).GetMethod(nameof(BinaryFormatterHelpers.AssertExceptionDeserializationFails)); |
Member
There was a problem hiding this comment.
Can we add new overload to BinaryFormatterHelpers which takes Type to avoid reflection? (current one can call it since it's doing typeof(T) anyway)
Author
There was a problem hiding this comment.
We’d have to do the same reflection jazz in that method in BinaryFormatter. I actually don’t think it would be really that useful. Mainly because this is the only case IIRC where we catch and validate an internal exception thrown from public API
krwq
approved these changes
Sep 9, 2019
Member
|
Thanks @hughbe! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add CodeDom.CodeValidator tests and fix some bugs * Fix netfx tests * PR feedback Commit migrated from dotnet/corefx@50e8db3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.