This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Port some methods of the VB Interaction module - #39574
Merged
Merged
Conversation
cston
reviewed
Jul 17, 2019
cston
reviewed
Jul 17, 2019
cston
reviewed
Jul 17, 2019
cston
reviewed
Jul 18, 2019
cston
reviewed
Jul 18, 2019
|
@KathleenDollard the highest usage for any of these is 0.3%. So to my mind this does not meet the bar to port to 3.0 and must wait for 5.0 (as we cannot add API in 3.1). If you believe it should be in 3.0 please let's discuss in tactics meeting. |
cston
reviewed
Jul 18, 2019
cston
approved these changes
Jul 18, 2019
|
@cston ready to merge? Sounds like we want a PR against 3.0 also. |
|
@ehasis, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.