This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Repository navigation
Undo a few JIT layout workarounds - #23510
Merged
Merged
Conversation
jkotas
reviewed
Aug 23, 2017
| @@ -456,30 +428,22 @@ public static unsafe int IndexOfAny(ref byte searchSpace, byte value0, byte valu | |||
| } | |||
| // Found match, reuse Vector vComparison to keep register pressure low | |||
Member
There was a problem hiding this comment.
You should be able to remove this bit too and just use vMatches to compute the result.
Contributor
Author
There was a problem hiding this comment.
Updated (x3)
jkotas
reviewed
Aug 23, 2017
| @@ -303,30 +287,22 @@ public static unsafe int IndexOfAny(ref byte searchSpace, byte value0, byte valu | |||
| } | |||
| // Found match, reuse Vector vComparison to keep register pressure low | |||
| values0 = vMatches; | |||
JosephTremoulet
force-pushed
the
UndoGoto
branch
from
August 23, 2017 20:28
e5df992 to
f9a26d4
Compare
Remove some `goto`s that were added to work around dotnet/coreclr#9692 (poor code layout for loop exit paths) -- the JIT's layout decisions were improved in dotnet/coreclr#13314, and these particular `goto`s are no longer needed; the same machine code is generated with or without this change. Some `goto`s previously tagged as workarounds for dotnet/coreclr#9692 are still relevant for keeping codesize down pending dotnet/coreclr#13549; update their comments accordingly. Part of #23395.
JosephTremoulet
force-pushed
the
UndoGoto
branch
from
August 23, 2017 20:30
f9a26d4 to
96d18e5
Compare
danmoseley
reviewed
Aug 23, 2017
| index += Vector<byte>.Count; | ||
| continue; | ||
| } | ||
| // Found match, reuse Vector vComparison to keep register pressure low |
There was a problem hiding this comment.
this workaround is also not necessary?
jkotas
approved these changes
Aug 23, 2017
stephentoub
approved these changes
Aug 23, 2017
Member
|
@dotnet-bot test Windows x64 Debug Build please (System.Private.Uri.Functional crash) |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Remove some `goto`s that were added to work around dotnet/coreclrdotnet/corefx#9692 (poor code layout for loop exit paths) -- the JIT's layout decisions were improved in dotnet/coreclrdotnet/corefx#13314, and these particular `goto`s are no longer needed; the same machine code is generated with or without this change. Some `goto`s previously tagged as workarounds for dotnet/coreclrdotnet/corefx#9692 are still relevant for keeping codesize down pending dotnet/coreclrdotnet/corefx#13549; update their comments accordingly. Part of dotnet/corefx#23395. Commit migrated from dotnet/corefx@d90ebb8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some
gotos that were added to work around dotnet/coreclr#9692(poor code layout for loop exit paths) -- the JIT's layout decisions
were improved in dotnet/coreclr#13314, and these particular
gotos areno longer needed; the same machine code is generated with or without
this change.
Some
gotos previously tagged as workarounds for dotnet/coreclr#9692 arestill relevant for keeping codesize down pending dotnet/coreclr#13549;
update their comments accordingly.
Part of #23395.