Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[release/3.1] Remove blob feeds - #28177

Merged
wtgodbe merged 1 commit into
release/3.1from
mmitche-patch-2
Aug 11, 2021
Merged

wtgodbe merged 1 commit into
release/3.1from
mmitche-patch-2

Conversation

@mmitche

@mmitche mmitche commented Jun 9, 2021

Copy link
Copy Markdown
Member

No description provided.

@mmitche

mmitche commented Jun 10, 2021

Copy link
Copy Markdown
Member Author

@wtgodbe Are these known failures?

@wtgodbe

wtgodbe commented Jun 10, 2021 •

Copy link
Copy Markdown
Member

System.Net.Primitives.Unit.Tests.CookieContainerTest.SetCookies_Success

I'm seeing this particular test failure in a few arcade ingestion PRs across 3.1 and 5.0: #28175, dotnet/corefx#43081, dotnet/runtime#53937. I thought it was related to the arcade change, but looks like it's a general failure in the runtime. @Anipik @jeffschwMSFT could somebody take a look? We'll need to get this fixed up before servicing builds kick off on Monday

@jeffschwMSFT

Copy link
Copy Markdown
Member

Adding @danmoseley for System.Net.* test

@danmoseley

Copy link
Copy Markdown

System.Net.Primitives.Unit.Tests.CookieContainerTest.SetCookies_Success is failing for an amusing reason

We need to roll in dotnet/runtime#53932

@danmoseley

Copy link
Copy Markdown

I'll create a PR for that in CoreFX.

The regex AV looks very like what dotnet/corefx#43071 should have fixed. (it's being killed on Ubuntu 1804 specifically). That went into corefx release/3.1 a month ago. Is it possible we aren't picking that up?

@danmoseley

Copy link
Copy Markdown

@jeffschwMSFT there is a failure in Readytorun/DynamicMethodGCStress/DynamicMethodGCStress/DynamicMethodGCStress.sh

@wtgodbe

wtgodbe commented Jun 10, 2021

Copy link
Copy Markdown
Member

Is it possible we aren't picking that up?

The corefx -> coreclr subscription hasn't fired in a long time since it's a back edge. Should I fire that off? Or is it a shared source thing?

@danmoseley

Copy link
Copy Markdown

I've no idea - who can answer that? But yes, we should be keeping them up to date, otherwise we're in a nonsensical configuration, testing new CoreCLR with old CoreFX.

@wtgodbe

wtgodbe commented Jun 10, 2021

Copy link
Copy Markdown
Member

Ok, I triggered dotnet/corefx#43083, #28178, and #28179

@danmoseley

Copy link
Copy Markdown

@wtgodbe can we make those updates happen automatically? I see eg., for the SDK one "Microsoft.NETCore.App: from 3.1.9 to 3.1.17-servicing.21309.1". Presumably it should happen at least monthly.

@mangod9

mangod9 commented Jun 10, 2021

Copy link
Copy Markdown
Member

Looks like a timeout

Yeah feels like its intermittent, trying to rerun it

@wtgodbe

wtgodbe commented Jun 14, 2021

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@wtgodbe

wtgodbe commented Jun 14, 2021

Copy link
Copy Markdown
Member

@danmoseley I'd suggest firing them off manually as part of branding - there isn't a day of the month when we know the branches will always be open, so if we create the PRs monthly automatically then they'd sometimes get auto-merged when branches are closed (and we don't want to lose the benefits of having auto-merge on for other maestro PRs)

@danmoseley

Copy link
Copy Markdown

@wtgodbe there's no way to tell Maestro to not automerge in dotnet/coreclr and dotnet/corefx only?

But if not -- that's OK. if we have another problem, we can kick it then.

@wtgodbe

wtgodbe commented Jun 14, 2021

Copy link
Copy Markdown
Member

there's no way to tell Maestro to not automerge in dotnet/coreclr and dotnet/corefx only?

There is, but then we lose the automatic merging of arcade -> coreclr/corefx & coreclr -> corefx PRs, which could slow down the final builds.

@aik-jahoda

Copy link
Copy Markdown

@Anipik, @mmitche is this ready for servicing?

@wtgodbe
wtgodbe merged commit b583270 into release/3.1 Aug 11, 2021
@wtgodbe
wtgodbe deleted the mmitche-patch-2 branch August 11, 2021 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants