Repository navigation
add api diff for preview6 - #6417
Conversation
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
The System.Threading.Channels.md part LGTM, but the diff is missing the new System.IO APIs added in #53669
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
System.Threading.Channels and System.IO LGTM, thank you @Anipik
| @@ -0,0 +1,14 @@ | |||
| # System.Numerics | |||
|
|
|||
| ``` diff | |||
| @@ -0,0 +1,21 @@ | |||
| # System.Runtime.Intrinsics.X86 | |||
|
|
|||
| ``` diff | |||
There was a problem hiding this comment.
Intrinsics LGTM. CC @echesakovMSFT, @pgovind
Do we need to do anything explicit to express these are RequiresPreviewFeatures?
The attribute is in the ref but isn't relayed here and likely not readily visible in the docs/etc
CC. @terrajobst, @carlossanlop, @jeffhandley ^
There was a problem hiding this comment.
@Anipik, can we ensure that a particular attribute is included in the future diffs (namely RequiresPreviewFeature)?
|
For System.Threading, the new ones shown look good to me, but the new APIs from dotnet/runtime#53899 may be missing. |
Those will be in Preview 7. |
|
This diff appears to be missing the AddEndpointsApiExplorer extension method added here. |
karelz
left a comment
karelz
left a comment
There was a problem hiding this comment.
System.Net.* namespaces are good
|
System.Security.* LGTM. I don't see System.IO.Hashing -- I'm guessing full OOBs don't show up? |
nope. just the ref packs |
|
|
||
| ``` diff | ||
| namespace System.Text { | ||
| + public ref struct SpanLineEnumerator { |
There was a problem hiding this comment.
Where's the EnumerateLines method that creates this?
10 participants
cc @adamsitnik @carlossanlop @jozkee @eiriktsarpalis @layomia @buyaa-n @joperezr @krwq @kouvel @pgovind @tannergooding @steveharter @tarekgh @dotnet/ncl
@stephentoub @ericstj @danmoseley
cc @pranavkm @Tratcher @Pilchie @davidfowl @dougbu @richlander