Let JsonException bubble through problem details in minimal APIs - #66519
Merged
Conversation
Youssef1313
requested review from
a team,
BrennanConroy and
halter73
as code owners
April 28, 2026 17:40
github-actions
Bot
added
the
area-networking
Contributor
There was a problem hiding this comment.
Pull request overview
Updates minimal API JSON body binding to emit validation-style Problem Details when System.Text.Json throws a JsonException (e.g., missing required properties), aligning the behavior more closely with MVC/controller model binding.
Changes:
- Write
HttpValidationProblemDetailsviaIProblemDetailsServicewhen JSON body deserialization throwsJsonExceptioninRequestDelegateFactory. - Add a functional test validating consistent Problem Details output for both a minimal endpoint and an MVC
[ApiController]endpoint. - Extend the
SimpleWebSiteWithWebApplicationBuildertest app with endpoints/models to reproduce therequiredproperty scenario.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Mvc/test/WebSites/SimpleWebSiteWithWebApplicationBuilder/Program.cs | Adds ProblemDetails services + new endpoints/model to exercise missing required property behavior. |
| src/Mvc/test/Mvc.FunctionalTests/SimpleWithWebApplicationBuilderTests.cs | Adds a functional test asserting Problem Details JSON for both minimal + MVC endpoints. |
| src/Http/Http.Extensions/src/RequestDelegateFactory.cs | Emits HttpValidationProblemDetails on JsonException during minimal API JSON body binding. |
mikekistler
reviewed
Apr 29, 2026
mikekistler
left a comment
mikekistler
left a comment
There was a problem hiding this comment.
@Youssef1313 Thank you for this contribution!
I will let the engineering team weigh in on the details of this change but I fully support the effort to solve this problem.
Youssef1313
added
area-minimal
3 tasks
Member
Author
|
@BrennanConroy @halter73 @javiercn Can I get a review here please? Thanks. |
1 task
BrennanConroy
approved these changes
May 7, 2026
|
|
||
| await endpoint.RequestDelegate(httpContext); | ||
|
|
||
| var logs = TestSink.Writes.ToArray(); |
rokonec
approved these changes
May 15, 2026
3 tasks
Youssef1313
enabled auto-merge (squash)
May 22, 2026 09:11
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64139