Skip to content

[release/8.0] Fix ResponseCompressionMiddleware tests #60884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 7 commits into from
Sep 5, 2026
Merged

[release/8.0] Fix ResponseCompressionMiddleware tests #60884

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3976a49
Fix ResponseCompressionMiddleware tests
wtgodbe Mar 11, 2025
e59d900
Update ResponseCompressionMiddlewareTest.cs
wtgodbe Mar 11, 2025
ec4420c
Update ResponseCompressionMiddlewareTest.cs
wtgodbe Mar 11, 2025
995f94b
Update content length assertion in test
wtgodbe Mar 11, 2025
52a27d9
Merge branch 'release/8.0' into wtgodbe/rcmtest
Youssef1313 Aug 25, 2026
3945785
Apply suggestion
akoeplinger Sep 4, 2026
5832d28
Validate decompressed send file responses
wtgodbe Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions src/Middleware/ResponseCompression/test/ResponseCompressionMiddlewareTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1114,7 +1114,8 @@ public async Task SendFileAsync_FirstWrite_CompressesAndFlushes()

var response = await client.SendAsync(request);

CheckResponseCompressed(response, expectedBodyLength: 34, expectedEncoding: "gzip");
var expectedBody = File.ReadAllBytes("testfile1kb.txt");
await CheckGzipResponseCompressed(response, expectedBody);

Assert.False(fakeSendFile.SendFileInvoked);
}
Expand Down Expand Up @@ -1164,7 +1165,11 @@ public async Task SendFileAsync_AfterFirstWrite_CompressesAndFlushes()

var response = await client.SendAsync(request);

CheckResponseCompressed(response, expectedBodyLength: 46, expectedEncoding: "gzip");
var fileBody = File.ReadAllBytes("testfile1kb.txt");
var expectedBody = new byte[100 + fileBody.Length];
Array.Fill(expectedBody, (byte)'a', 0, 100);
fileBody.CopyTo(expectedBody, 100);
await CheckGzipResponseCompressed(response, expectedBody);

Assert.False(fakeSendFile.SendFileInvoked);
}
Expand Down Expand Up @@ -1287,6 +1292,24 @@ public async Task Dispose_SyncWriteOrFlushNotCalled(string encoding)
}

private static void CheckResponseCompressed(HttpResponseMessage response, long? expectedBodyLength, string expectedEncoding)
{
CheckResponseCompressedHeaders(response, expectedEncoding);
Assert.Equal(expectedBodyLength, response.Content.Headers.ContentLength);
}

private static async Task CheckGzipResponseCompressed(HttpResponseMessage response, byte[] expectedBody)
{
CheckResponseCompressedHeaders(response, "gzip");

using var compressedBody = await response.Content.ReadAsStreamAsync();
using var gzipBody = new GZipStream(compressedBody, CompressionMode.Decompress);
using var decompressedBody = new MemoryStream();
await gzipBody.CopyToAsync(decompressedBody);

Assert.Equal(expectedBody, decompressedBody.ToArray());
}

private static void CheckResponseCompressedHeaders(HttpResponseMessage response, string expectedEncoding)
{
var containsVaryAcceptEncoding = false;
foreach (var value in response.Headers.GetValues(HeaderNames.Vary))
Expand All @@ -1300,7 +1323,6 @@ private static void CheckResponseCompressed(HttpResponseMessage response, long?
Assert.True(containsVaryAcceptEncoding);
Assert.False(response.Content.Headers.TryGetValues(HeaderNames.ContentMD5, out _));
Assert.Single(response.Content.Headers.ContentEncoding, expectedEncoding);
Assert.Equal(expectedBodyLength, response.Content.Headers.ContentLength);
}

private static void CheckResponseNotCompressed(HttpResponseMessage response, long? expectedBodyLength, bool sendVaryHeader)
Expand Down
Loading