[JamesNK]

Addresses #57259

Counter tests are flaky. Possible cause is a timing change for reporting counter values in dotnet/runtime.

PR changes:

• Adds logging to help find out what is going on.
• Sums changes from event counter events. Makes tests more resilient to counter events spread across intervals.
• Ensures test event listener is only listening to values from the current test.

[JamesNK]

I noticed when I added logging that TestCounterListener (an event listener) was getting events from event sources in different tests. This was surprising to me because the listener's EnableEvents method has the event source as an argument, so I would have expected it to only listen to events from that event source.

I fixed the issue by also passing the unique event source name to the listener and filtering event data.

Is this expected? @noahfalk @tarekgh

[noahfalk]

I noticed when I added logging that TestCounterListener (an event listener) was getting events from event sources in different tests. This was surprising to me because the listener's EnableEvents method has the event source as an argument, so I would have expected it to only listen to events from that event source.

I fixed the issue by also passing the unique event source name to the listener and filtering event data.

Is this expected? @noahfalk @tarekgh

That sounds like you hit dotnet/runtime#31927. Its expected only in the sense that it is a known bug that has been around a long time. I'm encouraging that we fix it.

[amcasey]

Naively, I would have expected the base call to go at the end, though it doesn't appear to matter in this case.

[JamesNK]

Usually, I put base call at the beginning unless there is a reason not to.

[amcasey]

While I generally agree, I think Dispose is a mirror of the constructor and, for similar reasons, it makes sense to tear down the derived class before tearing down the base class (which it may depend upon).

[JamesNK]

That sounds like you hit dotnet/runtime#31927. Its expected only in the sense that it is a known bug that has been around a long time. I'm encouraging that we fix it.

Ok. These tests have been flawed forever 😬

[JamesNK]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).