Skip to content

[main] Update dependencies from dotnet/efcore dotnet/runtime - #48558

Merged
dotnet-maestro[bot] merged 16 commits into
mainfrom
darc-main-6790b73a-eab1-44c7-b689-186633a4fcf1
Jun 8, 2023
Merged

[main] Update dependencies from dotnet/efcore dotnet/runtime#48558
dotnet-maestro[bot] merged 16 commits into
mainfrom
darc-main-6790b73a-eab1-44c7-b689-186633a4fcf1

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jun 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20230608.1
  • Date Produced: June 8, 2023 9:57:02 AM UTC
  • Commit: 7c00b17be1b2ffb6ed49ad68cf36e9a056323152
  • Branch: refs/heads/main

From https://github.com/dotnet/efcore

  • Subscription: 8ce5251e-8269-419d-3b2a-08d8b8050dda
  • Build: 20230607.2
  • Date Produced: June 7, 2023 1:46:15 PM UTC
  • Commit: f2a3da4048c0c5368d5fce832299ba9597d2e4be
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
58be3a4 
…0601.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.6.23280.5 -> To Version 8.0.0-preview.6.23301.1
@dotnet-maestro
dotnet-maestro Bot requested review from a team and wtgodbe as code owners June 1, 2023 12:00
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Jun 1, 2023
ghost
ghost approved these changes Jun 1, 2023
View reviewed changes

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@ghost

ghost commented Jun 1, 2023

Copy link
Copy Markdown

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20230…
aa05cb4 
…601.1

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 8.0.0-preview.6.23279.4 -> To Version 8.0.0-preview.6.23301.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Jun 1, 2023
dotnet-maestro Bot added 3 commits June 1, 2023 14:43
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20230…
7305e29 
…601.2

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 8.0.0-preview.6.23279.4 -> To Version 8.0.0-preview.6.23301.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20230…
095918e 
…601.3

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 8.0.0-preview.6.23279.4 -> To Version 8.0.0-preview.6.23301.3
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
ce2a451 
…0602.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.6.23280.5 -> To Version 8.0.0-preview.6.23302.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Jun 2, 2023
dotnet-maestro Bot added 4 commits June 3, 2023 12:02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
be70f74 
…0602.11

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.6.23280.5 -> To Version 8.0.0-preview.6.23302.11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
128c21c 
…0603.4

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.6.23280.5 -> To Version 8.0.0-preview.6.23303.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
9087a2f 
…0604.2

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.6.23280.5 -> To Version 8.0.0-preview.6.23304.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
5b229e4 
…0605.2

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.6.23280.5 -> To Version 8.0.0-preview.6.23305.2
@BrennanConroy

BrennanConroy commented Jun 6, 2023

Copy link
Copy Markdown
Member

Couple tests likely broken by dotnet/runtime#87093.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20230…
d57e858 
…607.1

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 8.0.0-preview.6.23279.4 -> To Version 8.0.0-preview.6.23307.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Jun 7, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
2b83f1b 
…0607.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.6.23280.5 -> To Version 8.0.0-preview.6.23307.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Jun 7, 2023
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20230…
ba05754 
…607.2

dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools
 From Version 8.0.0-preview.6.23279.4 -> To Version 8.0.0-preview.6.23307.2
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Jun 7, 2023
@eerhardt

eerhardt commented Jun 7, 2023

Copy link
Copy Markdown
Member

@JamesNK @Tratcher @amcasey - There's a kestrel failure. Can someone take a look?

System.Exception : Connection not removed from CWT.

@amcasey

amcasey commented Jun 7, 2023

Copy link
Copy Markdown
Member

I wonder why that's a throw and not an assert. In any case, the failure is in QuicConnectionListenerTests.AcceptAsync_NoCertificateCallback_RemovedFromPendingConnections. It looks kind of race-y TBH: await Task.Delay(100 * i).

"CWT" appears to be ConditionalWeakTable<QuicConnection, QuicConnectionContext>.

@Tratcher

Tratcher commented Jun 7, 2023

Copy link
Copy Markdown
Member

I wonder why that's a throw and not an assert. In any case, the failure is in QuicConnectionListenerTests.AcceptAsync_NoCertificateCallback_RemovedFromPendingConnections. It looks kind of race-y TBH: await Task.Delay(100 * i).

"CWT" appears to be ConditionalWeakTable<QuicConnection, QuicConnectionContext>.

Looks flaky. Quarantine it.

@eerhardt

eerhardt commented Jun 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

FYI - @eiriktsarpalis - I updated 2 HttpResults Json tests in response to dotnet/runtime#87093.

@BrennanConroy

BrennanConroy commented Jun 7, 2023

Copy link
Copy Markdown
Member

Looks flaky. Quarantine it.

It does look a little fragile, but it seems like something changed to make it fail now. See how it's consistently failing for this PR.

Someone should take a quick look to see if anything obvious changed in runtime. E.g. dotnet/runtime@8a5ae8b#diff-a9b6f4bb4f623894b968d15166375e929e14716f6910febcadd9a13e20a15b46L232 which might change how Kestrel's accept loop works. https://source.dot.net/#Microsoft.AspNetCore.Server.Kestrel.Transport.Quic/Internal/QuicConnectionListener.cs,181

@amcasey

amcasey commented Jun 7, 2023

Copy link
Copy Markdown
Member

Looks flaky. Quarantine it.

It does look a little fragile, but it seems like something changed to make it fail now. See how it's consistently failing for this PR.

Someone should take a quick look to see if anything obvious changed in runtime. E.g. dotnet/runtime@8a5ae8b#diff-a9b6f4bb4f623894b968d15166375e929e14716f6910febcadd9a13e20a15b46L232 which might change how Kestrel's accept loop works. https://source.dot.net/#Microsoft.AspNetCore.Server.Kestrel.Transport.Quic/Internal/QuicConnectionListener.cs,181

That particular change looks like it would just throw more often, which I would expect to break the test in other ways? If someone knowledgeable is planning to take a look, I'd love to shadow because this code is entirely new to me.

@BrennanConroy

BrennanConroy commented Jun 7, 2023

Copy link
Copy Markdown
Member

That particular change looks like it would just throw more often

? It throws less with that change. See the exact line I linked to where it previously threw an ODE and now doesn't. And the corresponding link to Kestrel's code where we caught an ODE and returned null from the accept loop, but now that ODE isn't thrown we catch any exceptions and continue the accept loop instead of returning.

@amcasey

amcasey commented Jun 7, 2023

Copy link
Copy Markdown
Member

That particular change looks like it would just throw more often

? It throws less with that change. See the exact line I linked to where it previously threw an ODE and now doesn't. And the corresponding link to Kestrel's code where we caught an ODE and returned null from the accept loop, but now that ODE isn't thrown we catch any exceptions and continue the accept loop instead of returning.

I misread. I agree with @BrennanConroy's interpretation.

@BrennanConroy

BrennanConroy commented Jun 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Talking with Andrew a bit and it looks like dotnet/runtime#87057 might actually be the culprit. It disposes a CTS and it looks like the lifetime of the cancellation token registration might last longer than the method where the CTS is disposed? The registration handled timing out the handshake after 10 seconds, but if the CTS is disposed too early, the registration will be dropped and not run.

This might be wrong because the ValueTask returned from FinishHandshakeAsync is where the registration is disposed and that's awaited...

cc @stephentoub

@stephentoub

stephentoub commented Jun 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Talking with Andrew a bit and it looks like dotnet/runtime#87057 might actually be the culprit. It disposes a CTS and it looks like the lifetime of the cancellation token registration lasts longer than the method where the CTS is disposed. The registration handled timing out the handshake after 10 seconds, but if the CTS is disposed too early, the registration will be dropped and not run.

Which registration? The CTS is being disposed only after the FinishHandshakeAsync call completes. Is this some kind of error condition where that CTS is actually canceling something in one of the catch blocks?

@JamesNK

JamesNK commented Jun 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

re: AcceptAsync_NoCertificateCallback_RemovedFromPendingConnections

The conditional weak table is required because there isn't a way to pass the state out of a callback. There is a proposal to improve that in .NET 8 with dotnet/runtime#72511

Successful connections are explicitly removed the table. The test validates that failed QuicConnection instances are also removed from the conditional weak table. That happens automatically when the failed connection is garbage collected.

The test is probably failing because a change in System.Net.Quic is holding onto the QuicConnection.

  1. QuicConnection still has a reference
  2. It isn't garbage collected
  3. It isn't removed from the weak table
  4. The test fails

I ran the test locally, which consistently passes before the update and fails afterward. It's not flaky.

Edit: Pinged @karelz to see if someone can take a look at recent S.N.Q changes.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2023…
f9e0324 
…0608.1

Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting
 From Version 8.0.0-preview.6.23280.5 -> To Version 8.0.0-preview.6.23308.1
@dotnet-maestro dotnet-maestro Bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Jun 8, 2023
@eerhardt
Convert to new generic JsonStringEnumConverter<TEnum> to fix JSON sou…
4355284 
…rce generator warning.

InteractionType is used in a JsonSerializerContext. With dotnet/runtime#87224, there is now a warning to convert source generated usages of JsonStringEnumConverter to JsonStringEnumConverter<TEnum>.

I went ahead and updated the other 2 usages as well, to make them consistent.
@eerhardt
eerhardt requested a review from a team as a code owner June 8, 2023 15:11
@eerhardt

eerhardt commented Jun 8, 2023

Copy link
Copy Markdown
Member

Fixed the diagnostic warning coming from dotnet/runtime#87224. I went ahead and updated the other 2 usages as well, to make them consistent.

@eerhardt

eerhardt commented Jun 8, 2023

Copy link
Copy Markdown
Member

Can we log an issue for the failing Kestrel test and disable the test to get this PR unblocked?

@amcasey

amcasey commented Jun 8, 2023

Copy link
Copy Markdown
Member

My SOS knowledge is pretty rusty, but these are the GC roots I was seeing for the QuicConnection when I grabbed a dump

0:054> !gcroot -all 000002106140c4d0
HandleTable:
    00000210367411F8 (strong handle)
    -> 000002103C400028 System.Object[]
    -> 000002105C043F98 System.Collections.Generic.Dictionary`2[[System.Int32, System.Private.CoreLib],[System.Threading.Tasks.Task, System.Private.CoreLib]]
    -> 0000021062014C20 System.Collections.Generic.Dictionary`2+Entry[[System.Int32, System.Private.CoreLib],[System.Threading.Tasks.Task, System.Private.CoreLib]][]
    -> 000002105CC017A8 System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1+AsyncStateMachineBox`1[[System.Threading.Tasks.VoidTaskResult, System.Private.CoreLib],[System.Net.Quic.QuicConnection+<DisposeAsync>d__47, System.Net.Quic]]
    -> 000002106140C4D0 System.Net.Quic.QuicConnection

    00000210380A11D0 (strong handle)
    -> 000002106140C4D0 System.Net.Quic.QuicConnection

    00000210380A11E0 (strong handle)
    -> 000002106140C4D0 System.Net.Quic.QuicConnection

I wasn't sure how to interpret the latter two - maybe pinned instances for native interop?

@amcasey

amcasey commented Jun 8, 2023

Copy link
Copy Markdown
Member

Can we log an issue for the failing Kestrel test and disable the test to get this PR unblocked?

Based on my superficial understanding, this looks like a leak in a configuration failure scenario, which doesn't feel like a blocker to me.

@stephentoub

stephentoub commented Jun 8, 2023

Copy link
Copy Markdown
Member

-> 000002105C043F98 System.Collections.Generic.Dictionary2[[System.Int32, System.Private.CoreLib],[System.Threading.Tasks.Task, System.Private.CoreLib]] -> 0000021062014C20 System.Collections.Generic.Dictionary2+Entry[[System.Int32, System.Private.CoreLib],[System.Threading.Tasks.Task, System.Private.CoreLib]][]
-> 000002105CC017A8 System.Runtime.CompilerServices.AsyncTaskMethodBuilder1+AsyncStateMachineBox1[[System.Threading.Tasks.VoidTaskResult, System.Private.CoreLib],[System.Net.Quic.QuicConnection+d__47, System.Net.Quic]]
-> 000002106140C4D0 System.Net.Quic.QuicConnection

This suggests the connection isn't going away because an invocation of its QuicConnection.DisposeAsync is still in flight...

@amcasey

amcasey commented Jun 8, 2023

Copy link
Copy Markdown
Member

In fairness, I didn't grab that dump at the last possible moment, so I can try again after it fully times out.

@BrennanConroy

BrennanConroy commented Jun 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

I grabbed a dump during the long delay where nothing is happening and the test is waiting for it's timeout. The dump has one QuicConnection rooted still. Which, when you track the reference down, is from QuicConnection._connectedTcs._keepAlive. So basically the QuicConnection is rooting itself. Normally this would be cleaned up by awaiting the task returned via QuicConnection.FinishHandshakeAsync or QuicConnection.FinishConnectAsync so I tracked down which method the rooted connection came from, and it was from FinishHandshakeAsync.

And the reason the ValueTask returned from FinishHandshakeAsync isn't awaited (thus freeing the GCHandle) is because the method throws which keeps the GCHandle alive forever in this case.

The reason the test worked before was because the TCS wasn't disposed before @stephentoub's change which meant there was a 10 second timeout that would eventually cleanup the ValueTask and thus the GCHandle.

So properly disposing the TCS exposed a bug in QuicConnection.

@stephentoub

stephentoub commented Jun 8, 2023

Copy link
Copy Markdown
Member

the TCS wasn't disposed before @stephentoub's change which meant there was a 10 second timeout that would eventually cleanup the ValueTask and thus the GCHandle

So properly disposing the TCS exposed a bug in QuicConnection.

You're welcome 😄

cc: @wfurt, @ManickaP

@amcasey amcasey mentioned this pull request Jun 8, 2023
Closed
@amcasey
amcasey requested review from JamesNK and mgravell as code owners June 8, 2023 19:21
@amcasey amcasey mentioned this pull request Jun 8, 2023
Closed
@dotnet-maestro
dotnet-maestro Bot merged commit 6575b28 into main Jun 8, 2023
@dotnet-maestro
dotnet-maestro Bot deleted the darc-main-6790b73a-eab1-44c7-b689-186633a4fcf1 branch June 8, 2023 21:04
@ghost ghost added this to the 8.0-preview6 milestone Jun 8, 2023
@wfurt

wfurt commented Jun 9, 2023

Copy link
Copy Markdown
Member

@ManickaP has insight and she will come up with fix.

@ghost

ghost commented Jun 9, 2023

Copy link
Copy Markdown

Hi @wfurt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner
@Tratcher Tratcher Awaiting requested review from Tratcher
@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner
@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner
@captainsafia captainsafia Awaiting requested review from captainsafia
@JamesNK JamesNK Awaiting requested review from JamesNK
@mgravell mgravell Awaiting requested review from mgravell
1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼

Projects

None yet

Milestone

8.0-preview6

Development

Successfully merging this pull request may close these issues.

7 participants

@BrennanConroy @eerhardt @amcasey @Tratcher @stephentoub @JamesNK @wfurt