Update "empty" web project templates to use minimal hostinng and routing by halter73 · Pull Request #32003 · dotnet/aspnetcore

halter73 · 2021-04-21T01:03:46Z

Description

Update the "Empty" project templates (used by dotnet new empty/dotnet new web and VS) to use the new "minimal hosting" APIs that were just merged minutes ago for preview4 by #31825.

Customer Impact

We're looking to collect feedback on our new "minimal hosting" and "minimal routing" API which we will present at BUILD. This updates the "empty" web project templates to make it easier to customer trying preview4 after BUILD to test out these new APIs.

Regression?

Yes
No

The template behaves as it did before. It does not include all the usings/opens for unused namespace. That might change based on code review feedback.

Risk

High
Medium
Low

This is a pretty big change to the empty web project template. It might confuse people. It is just a template change though.

@glennc looked up some usage statistics and this is one of the less popular than the MVC and API templates.

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

Addresses #30665

ghost · 2021-04-21T01:03:59Z

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

cartermp · 2021-04-21T01:27:48Z

+    if app.Environment.IsDevelopment() then
+        app.UseDeveloperExceptionPage() |> ignore
+
+    app.MapGet("/", Func<string>(fun () -> "Hello World!")) |> ignore


Is the explicit Func construction needed here? Might be able to elide that

It seems like it. Without it, I see the following error:

Program.fs(12,34): error FS0001: This expression was expected to have type↔ 'AspNetCore.Http.HttpContext' ↔but here has type↔ 'unit' [C:\dev\dotnet\aspnetcore\src\Http\samples\MinimalSampleFSharp\MinimalSampleFSharp.fsproj]

This is the F# language feature we wanted

halter73 · 2021-04-21T01:30:04Z

+    app.UseDeveloperExceptionPage();
 }
+
+app.MapGet("/", (Func<string>)(() => "Hello World!"));


I don't like that we still have to explicitly cast to Func<string> until we can consume the changes in dotnet/roslyn#52448, but I still think this is already a big improvement overall.

@jaredpar @cston

The bits should be lining up for preview 4 to allow this cast to be removed.

Tratcher · 2021-04-21T02:37:01Z

+
+app.MapGet("/", (Func<string>)(() => "Hello World!"));
+
+await app.RunAsync();


Program+Startup before: 66 lines
after: 14 lines.

It's a lot emptier than it used to be 😁.

davidfowl

Make the "empty" project, "really empty"

ShreyasJejurkar · 2021-04-21T05:30:10Z

Go..Go..Go SingleFile 😅😅

jkotalik · 2021-04-21T16:17:50Z

This plus making Kestrel the default server brings a smile to my face 😄. True modernization.

halter73 · 2021-04-22T17:33:49Z

/azp run

azure-pipelines · 2021-04-22T17:34:04Z

Azure Pipelines successfully started running 1 pipeline(s).

halter73 · 2021-04-22T17:56:09Z

 {
  "sdk": {
-    "version": "6.0.100-preview.4.21216.8"
+    "version": "6.0.100-preview.4.21222.6"


Heads up @dotnet/aspnet-build. I'm updating the preview4 branch SDK version so we can consume the WebApplication related types from our new "empty" web project templtates.

If these new types come from dotnet/aspnetcore, something is very wrong if they aren't just showing up. Fine if, on the other hand, the main thing we need is @DavidKarlas' dotnet/templating#3078 fix.

I needed to update this to get EmptyWebTemplateTest.EmptyWebTemplateCSharp EmptyWebTemplateTest.EmptyWebTemplateFSharp passing locally and on helix, so there's definitely room for improvement here. Not sure how common it is to update the templates to use very-newly-added APIs.

My understanding of the fix to templating is that the regression broke the custom hive logic we were using to make our template tests find our updated templates, so that's why stefan had to update the sdk. The templating workaround PR should also fix the tests I would assume

Pilchie · 2021-04-22T18:19:00Z

👀

Latest `dotnet new` doesn't work with relative path for `--debug:custom-hive`... Hence make it absolute Also switched to using `--debug:disable-sdk-templates` to avoid potential conflict between SDK and tests installed templates.

dougbu

Looks fine from a build perspective

dougbu · 2021-04-22T22:27:11Z

 {
  "sdk": {
-    "version": "6.0.100-preview.4.21216.8"
+    "version": "6.0.100-preview.4.21222.6"


If these new types come from dotnet/aspnetcore, something is very wrong if they aren't just showing up. Fine if, on the other hand, the main thing we need is @DavidKarlas' dotnet/templating#3078 fix.

ghost · 2021-04-23T01:56:14Z

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

halter73 added area-runtime feature-templates feature-minimal-hosting labels Apr 21, 2021

halter73 added this to the 6.0-preview4 milestone Apr 21, 2021

halter73 requested review from Tratcher, cartermp and davidfowl April 21, 2021 01:03

halter73 requested a review from jkotalik as a code owner April 21, 2021 01:03

halter73 added the Servicing-consider Shiproom approval is required for the issue label Apr 21, 2021

halter73 removed the Servicing-consider Shiproom approval is required for the issue label Apr 21, 2021

halter73 requested a review from LadyNaggaga April 21, 2021 01:26

cartermp reviewed Apr 21, 2021

View reviewed changes

halter73 commented Apr 21, 2021

View reviewed changes

Comment thread src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/Program.cs

Tratcher reviewed Apr 21, 2021

View reviewed changes

davidfowl approved these changes Apr 21, 2021

View reviewed changes

jkotalik approved these changes Apr 21, 2021

View reviewed changes

Tratcher reviewed Apr 21, 2021

View reviewed changes

Comment thread src/Http/samples/MinimalSample/Program.cs

halter73 requested review from HaoK and javiercn April 21, 2021 17:54

halter73 force-pushed the halter73/30665 branch from 3208b1f to a295dc3 Compare April 21, 2021 23:56

halter73 added 4 commits April 22, 2021 10:52

Minimize EmptyWeb-CSharp project template

f586466

Add UseDeveloperExceptionPage() back

ddaf769

Minimize EmptyWeb-FSharp project template

fc8b60e

Add MinimalSampleFSharp

eb5546a

halter73 added 5 commits April 22, 2021 10:52

upcast

7ff1200

Fix tests

c4733b8

Show WebApplicationBuilder

2fbc0e9

_

23caa4e

Update SDK to 6.0.100-preview.4.21222.6

cc57bb8

halter73 force-pushed the halter73/30665 branch from a295dc3 to cc57bb8 Compare April 22, 2021 17:54

halter73 requested a review from a team as a code owner April 22, 2021 17:54

halter73 commented Apr 22, 2021

View reviewed changes

Fixes #32028: Investigate Template Baseline tests errors

850e934

Latest `dotnet new` doesn't work with relative path for `--debug:custom-hive`... Hence make it absolute Also switched to using `--debug:disable-sdk-templates` to avoid potential conflict between SDK and tests installed templates.

dougbu approved these changes Apr 22, 2021

View reviewed changes

halter73 added the Servicing-consider Shiproom approval is required for the issue label Apr 23, 2021

halter73 added api-approved API was approved in API review, it can be implemented and removed Servicing-consider Shiproom approval is required for the issue labels Apr 23, 2021

Pilchie merged commit 90137b0 into release/6.0-preview4 Apr 23, 2021

Pilchie deleted the halter73/30665 branch April 23, 2021 04:55

dougbu mentioned this pull request Apr 25, 2021

Fixes #32028: Investigate Template Baseline tests errors #32054

Closed

2 of 4 tasks

halter73 mentioned this pull request May 14, 2021

Further simplify empty project template #32662

Merged

amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023


		app.MapGet("/", (Func<string>)(() => "Hello World!"));

		await app.RunAsync();

Conversation

halter73 commented Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Customer Impact

Regression?

Risk

Verification

Packaging changes reviewed?

Uh oh!

ghost commented Apr 21, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

halter73 Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidfowl Apr 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidfowl left a comment

Choose a reason for hiding this comment

Uh oh!

ShreyasJejurkar commented Apr 21, 2021

Uh oh!

jkotalik commented Apr 21, 2021

Uh oh!

Uh oh!

halter73 commented Apr 22, 2021

Uh oh!

azure-pipelines Bot commented Apr 22, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Pilchie commented Apr 22, 2021

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost commented Apr 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

halter73 commented Apr 21, 2021 •

edited

Loading

halter73 Apr 21, 2021 •

edited

Loading

davidfowl Apr 21, 2021 •

edited

Loading