Repository navigation
Bring back Random.Shared API once new SDK is picked up #31782
Description
Noticed this while looking at why the blazor template tests are 100% failing now in the quarantined runs:
Related to this PR: https://github.com/dotnet/aspnetcore/pull/31453/files
https://dev.azure.com/dnceng/public/_test/analytics?definitionId=869&contextType=build
C:\h\w\BABC09DD\w\A5850946\e\Templates\BaseFolder\AspNet.klo4c0qemnm\Server\Controllers\WeatherForecastController.cs(35,39): error CS0117: 'Random' does not contain a definition for 'Shared' [C:\h\w\BABC09DD\w\A5850946\e\Templates\BaseFolder\AspNet.klo4c0qemnm\Server\AspNet.klo4c0qemnm.Server.csproj]
C:\h\w\BABC09DD\w\A5850946\e\Templates\BaseFolder\AspNet.klo4c0qemnm\Server\Controllers\WeatherForecastController.cs(36,44): error CS0117: 'Random' does not contain a definition for 'Shared' [C:\h\w\BABC09DD\w\A5850946\e\Templates\BaseFolder\AspNet.klo4c0qemnm\Server\AspNet.klo4c0qemnm.Server.csproj]
Activity
javiercn commentedon Apr 14, 2021
@HaoK good catch.
I ran into this last week too, I thought it was because we were missing an updated SDK on the repo. I expect these to go away once we update the SDK in our repo
davidfowl commentedon Apr 14, 2021
When will that happen?
javiercn commentedon Apr 14, 2021
@davidfowl My understanding is before we ship preview4, otherwise we need to back this change out on Friday.
davidfowl commentedon Apr 14, 2021
Are the tests being skipped? Do we know when the update is coming? In general we shouldn't merge these until the dependency PR flows in.
javiercn commentedon Apr 14, 2021
@davidfowl agree.
This was originally a community contribution. We rely on CTI tests for the SPA templates and the Blazor tests are quarantined at the moment while we work on improving their reliability
javiercn commentedon Apr 14, 2021
@davidfowl here is a PR to revert the commit #31795
[-]Random.Shared missing build errors in quarantined template tests[/-][+]Bring back Random.Shared API once new SDK is picked up[/+]