Skip to content

Update Polly dependency to latest release? #31705

Closed

Description

@martincostello

Is your feature request related to a problem? Please describe.

ASP.NET Core currently depends on Polly 7.1.0, which was released in March 2019.

<PollyVersion>7.1.0</PollyVersion>

Since then there have been a number of minor releases, the most recent being yesterday to 7.2.2, to fix a number of bugs and minor improvements (CHANGELOG).

Describe the solution you'd like

Update the Polly dependency to the latest release, 7.2.2.

Updating to at least 7.2.0 would also make the new IConcurrentPolicyRegistry interface available, which could then be registered by default in the Polly extensions for HttpClientFactory: #28283 (comment).

Assuming there isn't a specific reason to pin the dependency at 7.1.0, I'd be happy to raise a PR to update the minimum version for ASP.NET Core 6.0.

Activity

  1. added
    area-mvcIncludes: MVC, Actions and Controllers, Localization, CORS, most templates
    on Apr 12, 2021
  2. javiercn commented on Apr 12, 2021

    @javiercn
    Member

    @martincostello thanks for contacting us.

    Are there known breaking changes between 7.2.2 and 7.1.0? I think we would be open to a PR if there are no breaking changes, otherwise we would need to evaluate the impact.

  3. added
    help wantedUp for grabs. We would accept a PR to help resolve this issue
    on Apr 12, 2021
  4. added this to the Next sprint planning milestone on Apr 12, 2021
  5. martincostello commented on Apr 12, 2021

    @martincostello
    MemberAuthor

    @javiercn No, there shouldn't be any breaking changes. There's no changes to the public API other than the addition of the new IConcurrentPolicyRegistry interface and PolicyRegistry implementing it. All the other changes are just bug fixes.

    If you'd be happy to accept a PR to update the dependency then I'll open one later on today 👍

  6. javiercn commented on Apr 12, 2021

    @javiercn
    Member

    @martincostello go for it.

  7. added a commit that references this issue on Apr 12, 2021
  8. BrennanConroy commented on Apr 14, 2021

    @BrennanConroy
    Member

    Done via #31708

  9. ghost locked as resolved and limited conversation to collaborators on May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-mvcIncludes: MVC, Actions and Controllers, Localization, CORS, most templatesgood first issueGood for newcomers.help wantedUp for grabs. We would accept a PR to help resolve this issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions