HTTPSysServer does not use LoggerMessage.Define #31313

Activity

1. davidfowl

   added

   Perf

   area-servers

   feature-httpsys

   help wantedUp for grabs. We would accept a PR to help resolve this issueUp for grabs. We would accept a PR to help resolve this issue

   on Mar 27, 2021
2. davidfowl

   changed the title [-]HTTPSys server does not use LoggerMessage.Define[/-] [+]HTTPSysServer does not use LoggerMessage.Define[/+] on Mar 28, 2021
3. martincostello commented on Mar 28, 2021

   

   martincostello

   on Mar 28, 2021

   Member

   More actions

   Happy to pick this up if you've not already started on it.

   👍React with 👍2Reacted by David Fowler and Sébastien Ros
4. davidfowl commented on Mar 28, 2021

   

   davidfowl

   on Mar 28, 2021

   MemberAuthor

   More actions

   Sounds good. Are you aware of the latest pattern we've been using? It's a nested static Log class with static methods that do logging. If the class is big enough we make a partial class and put the log methods in there m. If that's not clear, take a look at SignalR
5. martincostello commented on Mar 28, 2021

   

   martincostello

   on Mar 28, 2021

   Member

   More actions

   I took a look at the repo and saw that there's a class called LoggingExtensions (example) and then the messages are defined in there.

   If you're moving to nested per-class instead I'll do it that way instead 👍
6. davidfowl commented on Mar 28, 2021

   

   davidfowl

   on Mar 28, 2021

   MemberAuthor

   More actions

   E.g.

   aspnetcore/src/Servers/IIS/IIS/src/Core/IISHttpContext.Log.cs

   Line 12 in 155f402

   private static class Log

   aspnetcore/src/SignalR/clients/csharp/Http.Connections.Client/src/Internal/SendUtils.cs

   Line 112 in 46359cd

   private static class Log
7. davidfowl

   assigned

   martincostello

   on Mar 28, 2021
8. davidfowl commented on Mar 28, 2021

   

   davidfowl

   on Mar 28, 2021

   MemberAuthor

   More actions

   Assigned the issue to you @martincostello

   👍React with 👍1Reacted by Martin Costello
9. martincostello

   added a commit that references this issue on Mar 28, 2021

   Use LoggerMessage.Define in HttpSys

   ...

   b239111
10. davidfowl

    added this to the 6.0-preview4 milestone on Mar 28, 2021
11. davidfowl

    linked a pull request that will close this issueUse LoggerMessage.Define in HttpSys #31333on Mar 28, 2021
12. davidfowl

    closed this as completedin #31333on Mar 28, 2021
13. davidfowl

    added a commit that references this issue on Mar 28, 2021

    Use LoggerMessage.Define in HttpSys (#31333)

    ...

    This issue will close once commit 020745c is merged into the 'main' branch.

    020745c
14. davidfowl commented on Mar 28, 2021

    

    davidfowl

    on Mar 28, 2021

    MemberAuthor

    More actions

    Thanks!

    👍React with 👍1Reacted by Martin Costello
15. eugene2candy

    added a commit that references this issue on Apr 10, 2021

    PR (#2)

    ...

    This issue will close once commit c07f867 is merged into the 'dev' branch.

    c07f867
16. ghost locked as resolved and limited conversation to collaborators on Apr 28, 2021
17. amcasey

    added

    area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

    and removed

    area-runtime

    on Jun 2, 2023