Skip to content

Fix expect 100 continue logic in Kestrel to avoid doing sync over async #31225

Closed
#31650
Closed
Fix expect 100 continue logic in Kestrel to avoid doing sync over async#31225
#31650
Assignees
wtgodbe
Labels
area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsbugThis issue describes a behavior which is not expected - a bug.feature-kestrelhelp wantedUp for grabs. We would accept a PR to help resolve this issue
Milestone
6.0-preview4

Description

@davidfowl
davidfowl
opened on Mar 25, 2021

Describe the bug

Though this doesn't cause any problems in practice (we believe), there's a code cleanup that needs to happen around expect 100 continue handling in Kestrel. The code paths ProduceContinue are called from are all asynchronous, yet the method is synchronous and does sync over async. Lets fix that finally.

Here's the code

aspnetcore/src/Servers/Kestrel/Core/src/Internal/Http/HttpProtocol.cs

Line 909 in 333134c

public void ProduceContinue()

Activity

  1. davidfowl
    added
    area-servers
    feature-kestrel
    on Mar 25, 2021
  2. davidfowl
    added this to the Next sprint planning milestone on Mar 25, 2021
  4. davidfowl
    added
    help wantedUp for grabs. We would accept a PR to help resolve this issue
    on Mar 25, 2021
  5. davidfowl
    assigned
    wtgodbe
    on Mar 26, 2021

  6. davidfowl commented on Mar 26, 2021

    @davidfowl
    davidfowl
    on Mar 26, 2021
    MemberAuthor

    @wtgodbe assigned this to you for the next preview.

  7. davidfowl
    modified the milestones: Next sprint planning, 6.0-preview4 on Mar 26, 2021
  8. wtgodbe
    closed this as completedin #31650on Apr 13, 2021
  9. ghost locked as resolved and limited conversation to collaborators on May 13, 2021
  10. danroth27
    added
    bugThis issue describes a behavior which is not expected - a bug.
    on May 14, 2021
  11. amcasey
    added
    area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
    and removed
    area-runtime
    on Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-networkingIncludes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractionsbugThis issue describes a behavior which is not expected - a bug.feature-kestrelhelp wantedUp for grabs. We would accept a PR to help resolve this issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions