Skip to content

Make MSBuild tasks safe for multi-threaded execution - #17381

Closed
ViktorHofer wants to merge 33 commits into
dotnet:mainfrom
ViktorHofer:mt-task-migration
Closed

ViktorHofer wants to merge 33 commits into
dotnet:mainfrom
ViktorHofer:mt-task-migration

Conversation

@ViktorHofer

@ViktorHofer ViktorHofer commented Aug 21, 2026 •

Copy link
Copy Markdown
Member

Why

MSBuild 18.x can run tasks on multiple threads inside a single node (-mt), but only for tasks that opt in via [MSBuildMultiThreadableTask]; everything else is routed to an out-of-proc TaskHost, which is much more expensive. Arcade tasks run in essentially every project in every repo, so they are the single biggest lever.

Measured on a runtime inner-repo build in the VMR — -mt -nodeReuse:true -ms against an otherwise identical baseline, with no Arcade task annotated:

baseline -mt + server + node reuse
Wall clock 3090.2 s 2978.2 s
TaskHost task invocations 849 14,125
Total task time (non-nesting) 4,026 s 4,124 s
Effective parallelism 4.41x 4.09x

Only a 3.6% wall-clock gain: task time went up and effective parallelism went down, cancelling most of the benefit of threading. Expected saving across a full VMR build once migrated: 5-15 minutes.

What

This is the final part of the migration. The infrastructure and every other assembly already landed in main through reviewable subsets — #17469 (non-multithreading cleanups), #17497, #17507, #17513, #17522 and #17525 — which account for the 84 tasks annotated there today, and which carried the MSBuild 17.12.50 -> 18.8.2 upgrade, the Microsoft.Build.TaskAuthoring.Analyzer wiring, and the removal of the internal BuildTask/ILog base class. eng/ is untouched here.

What is left is the 35 tasks in the six assemblies whose path handling runs through shared helper chains:

Assembly Tasks annotated
Packaging 25
Workloads 5
SignTool 2
Feed, GenFacades, SwaggerGenerator 1 each
  • Replace ambient process state with the injected TaskEnvironment. Relative paths resolve against the project directory instead of the process-wide current directory, environment variables are read per-project, and child processes start from TaskEnvironment.GetProcessStartInfo().
  • Thread AbsolutePath through the shared path helpers in Packaging, GenFacades and Feed. Retyping a helper's path parameter is what actually resolves the transitive MSBuildTask0005 chains, and it is why this subset was kept for last: eight public methods on the PackageIndex helper change from string to AbsolutePath.

Concurrency bugs found and fixed

The analyzer checks path/env/process API usage, not thread-safety of shared mutable state, so a clean analyzer run is not evidence a task is thread-safe. A manual sweep across the whole migration found seven such sites; five are already in main, and these two are latent bugs today under any concurrent access, not just under -mt:

Site Defect
GetPackageDescription Unsynchronized static Dictionary; also memoized the null returned after a logged IOException, so every later invocation silently got null without retrying.
PackageIndex Shared static Newtonsoft JsonSerializer, which is not thread-safe.

Two regressions the migration introduced along the way, already fixed and worth flagging to anyone doing this work:

  • GetAbsolutePath(null) throws, while File.Exists(null)/Directory.Exists(null) return false — the only two BCL path APIs with that tolerance. Mechanically wrapping them turns an optional, unset task property into a hard failure; it took out every source-build leg. This surfaced on legs running without -mt: TaskEnvironment is injected in normal builds too.
  • The attribute and the interface are independent signals. The attribute controls routing, the interface controls injection, and nothing fails loudly when only one is present. Five tasks carried the attribute without implementing IMultiThreadableTask, so every path silently resolved against Fallback.

Deliberately not migrated

14 tasks here, each carrying a comment at its declaration recording why, so the decision is not silently reverted: ambient credentials or pipeline environment (6 Feed publishing tasks), process-wide static state (SignCheckTask, GenPartialFacadeSource, NotSupportedAssemblyGenerator), and unresolved paths flowing into helper chains (GenAPITask, PushToBuildStorage, SignToolTask, CreateVisualStudioWorkload, CreateVisualStudioWorkloadSet). Three more were excluded the same way in earlier subsets (SendHelixJob, InstallDotNetTool, SingleError), for 17 across the migration.

All are P3 with no measured invocations in the hot-path profile — every task appearing in a runtime inner-repo binlog is already migrated, so annotating the rest cannot save build time — and they are where a mistake is most expensive and least testable: Maestro and blob publishing, code signing, Wix packaging.

Several keep their IMultiThreadableTask implementation without the attribute. That is deliberate, not a half-migration: routing is decided by the attribute alone, so the interface only causes TaskEnvironment to be injected, making path resolution correct in either mode. It can never become the routing signal, since ToolTask implements it and that would opt in every ToolTask-derived task in the ecosystem.

Validation

dotnet build Arcade.slnx -c Release --no-incremental: 0 errors, 0 warnings. Reviewers: incremental builds skip up-to-date projects, so the analyzer does not re-run and reports a false "0 warnings" — --no-incremental is required. Liveness was separately confirmed by injecting an Environment.GetEnvironmentVariable call into an annotated task and checking it was reported as MSBuildTask0002.

Test suites for the assemblies in scope all pass: Packaging (48), Feed (218), SignTool (196, 7 skipped). Workloads.Tests needs a full VS MSBuild.exe and Arcade.Validation.Tests.RepoTests times out building test repos locally; neither runs here.

Contributes to #17378; the remaining tasks are tracked in #17388.

Filed against MSBuild while doing this work: #14779 and #14790 (TaskRouter documentation contradicts the attribute-only implementation), #14780 (MSBuildTask0003 code fix produces non-compiling code), and #14783/#14784/#14785 (analyzer gaps this migration surfaced).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prepares Arcade MSBuild tasks for in-process multithreaded execution through task annotations, project-scoped environment handling, analyzer enforcement, and concurrency fixes.

Changes:

  • Updates MSBuild dependencies and adds analyzer guardrails.
  • Migrates tasks to TaskEnvironment and removes the obsolete shared task base.
  • Addresses shared caches, serializers, and other concurrency hazards while leaving unsafe task chains unannotated.
Show a summary per file
File Review result
src/Microsoft.DotNet.XliffTasks/Tasks/XlfTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.XliffTasks/Tasks/UpdateXlf.cs Moderate: exception handling still compares against a potentially relative path.
src/Microsoft.DotNet.XliffTasks/Tasks/TranslateSource.cs Reviewed; no final comment.
src/Microsoft.DotNet.XliffTasks/Tasks/TransformTemplates.cs Reviewed; no final comment.
src/Microsoft.DotNet.XliffTasks/Tasks/SortXlf.cs Reviewed; no final comment.
src/Microsoft.DotNet.XliffTasks/Tasks/GatherXlf.cs Reviewed; no final comment.
src/Microsoft.DotNet.XliffTasks/Tasks/GatherTranslatedSource.cs Reviewed; no final comment.
src/Microsoft.DotNet.XliffTasks/Tasks/EnsureAllResourcesTranslated.cs Reviewed; no final comment.
src/Microsoft.DotNet.XliffTasks/Model/Document.cs Reviewed; no final comment.
src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.MSBuild/GenerateSwaggerCode.cs Reviewed; no final comment.
src/Microsoft.DotNet.SourceBuild/tasks/src/WriteBuildOutputProps.cs Moderate: relative asset directories are checked against the process directory.
src/Microsoft.DotNet.SourceBuild/tasks/src/UsageReport/WriteUsageReports.cs Reviewed; no final comment.
src/Microsoft.DotNet.SourceBuild/tasks/src/UsageReport/WritePackageUsageData.cs Moderate: RootDir is not normalized consistently.
src/Microsoft.DotNet.SourceBuild/tasks/src/ReadNuGetPackageInfos.cs Reviewed; no final comment.
src/Microsoft.DotNet.SignTool/src/SignToolTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.SignCheckTask/SignCheckTask.cs Critical: the shared verifier registry is not safe for concurrent or repeated construction.
src/Microsoft.DotNet.SharedFramework.Sdk/src/ValidateFileVersions.cs Reviewed; no final comment.
src/Microsoft.DotNet.SharedFramework.Sdk/src/GenerateSharedFrameworkDepsFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.SharedFramework.Sdk/src/GeneratePlatformManifestEntriesFromTemplate.cs Reviewed; no final comment.
src/Microsoft.DotNet.SharedFramework.Sdk/src/GeneratePlatformManifestEntriesFromFileList.cs Reviewed; no final comment.
src/Microsoft.DotNet.SharedFramework.Sdk/src/FileUtilities.cs Reviewed; no final comment.
src/Microsoft.DotNet.SharedFramework.Sdk/src/CreateFrameworkListFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.SharedFramework.Sdk/Microsoft.DotNet.SharedFramework.Sdk.csproj Reviewed; no final comment.
src/Microsoft.DotNet.PackageTesting/VerifyTypes.cs Reviewed; no final comment.
src/Microsoft.DotNet.PackageTesting/VerifyClosure.cs Reviewed; no final comment.
src/Microsoft.DotNet.PackageTesting/Microsoft.DotNet.PackageTesting.csproj Reviewed; no final comment.
src/Microsoft.DotNet.PackageTesting/GetCompatiblePackageTargetFrameworks.cs Critical: static mutable framework collections are shared across executions.
src/Microsoft.DotNet.NuGetRepack/tests/VersionUpdaterTests.cs Reviewed; no final comment.
src/Microsoft.DotNet.NuGetRepack/tasks/src/UpdatePackageVersionTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.NuGetRepack/tasks/src/ReplacePackageParts.cs Reviewed; no final comment.
src/Microsoft.DotNet.NuGetRepack/tasks/src/NuGetVersionUpdater.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/WaitForHelixJobCompletion.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/StopAzurePipelinesTestRun.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/StartAzurePipelinesTestRun.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/SendHelixJob.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/InstallDotNetTool.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/GetHelixWorkItems.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/FindDotNetCliPackage.cs Critical: the process-wide client can be overwritten or disposed during concurrent execution.
src/Microsoft.DotNet.Helix/Sdk/DownloadFromResultsContainer.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/CreateXUnitWorkItems.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAppleWorkItems.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAndroidWorkItems.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/CreateMTPWorkItems.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/CreateFailedTestsForFailedWorkItems.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/CheckHelixJobStatus.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/CheckAzurePipelinesTestResults.cs Reviewed; no final comment.
src/Microsoft.DotNet.Helix/Sdk/CancelHelixJob.cs Reviewed; no final comment.
src/Microsoft.DotNet.GenFacades/TypeParser.cs Reviewed; no final comment.
src/Microsoft.DotNet.GenFacades/SourceGenerator.cs Reviewed; no final comment.
src/Microsoft.DotNet.GenFacades/RoslynBuildTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.GenFacades/NotSupportedAssemblyGenerator.cs Critical: the shared process-wide assembly resolver is not thread-safe.
src/Microsoft.DotNet.GenFacades/Microsoft.DotNet.GenFacades.csproj Reviewed; no final comment.
src/Microsoft.DotNet.GenFacades/GenPartialFacadeSourceGenerator.cs Reviewed; no final comment.
src/Microsoft.DotNet.GenFacades/GenPartialFacadeSource.cs Critical: the shared process-wide assembly resolver is not thread-safe.
src/Microsoft.DotNet.GenFacades/ClearAssemblyReferenceVersions.cs Reviewed; no final comment.
src/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj Reviewed; no final comment.
src/Microsoft.DotNet.GenAPI/GenAPITask.cs Reviewed; no final comment.
src/Microsoft.DotNet.Deployment.Tasks.Links/src/DeleteAkaMSLinks.cs Reviewed; no final comment.
src/Microsoft.DotNet.Deployment.Tasks.Links/src/CreateAkaMSLinks.cs Reviewed; no final comment.
src/Microsoft.DotNet.CMake.Sdk/src/CreateCMakeFileApiQuery.cs Reviewed; no final comment.
src/Microsoft.DotNet.CMake.Sdk/Microsoft.DotNet.CMake.Sdk.csproj Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Workloads/src/Wix/WixToolTaskBase.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Workloads/src/Wix/WixToolTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Workloads/src/Wix/HarvesterToolTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Workloads/src/Microsoft.DotNet.Build.Tasks.Workloads.csproj Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Workloads/src/CreateVisualStudioWorkloadSet.wix.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Workloads/src/CreateVisualStudioWorkload.wix.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.VisualStudio/Vsix/GetPkgDefAssemblyDependencyGuid.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.VisualStudio/Vsix/FinalizeInsertionVsixFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.VisualStudio/OptProf/GetRunSettingsSessionConfiguration.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.VisualStudio/OptProf/GenerateTrainingPropsFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.VisualStudio/OptProf/GenerateTrainingInputFiles.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.VisualStudio/OptProf/FindLatestDrop.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Templating/src/GenerateFileFromTemplate.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/TargetFrameworkResolver.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/Microsoft.DotNet.Build.Tasks.TargetFramework.csproj Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/ChooseBestTargetFrameworksTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/ChooseBestP2PTargetFrameworkTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/tests/ValidateHarvestVersionIsLatestForReleaseTests.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/tests/TestBuildEngine.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/tests/RuntimeGraphTests.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/tests/PackageIndexTests.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/tests/Log.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/tests/CreateTrimDependencyGroupsTests.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/VersionUtility.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidationTask.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidatePackage.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidateHarvestVersionIsLatestForRelease.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidateFrameworkPackage.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/UpdatePackageIndex.cs Critical: mutable cached PackageIndex instances are shared across executions.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/SplitReferences.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/SplitDependenciesBySupport.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/PromoteDependencies.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageReport.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageMetadata.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageItem.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageIndex.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetUtility.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetPack.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetAssetResolver.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/Microsoft.DotNet.Build.Tasks.Packaging.csproj Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/HarvestPackage.cs Moderate: relative package-folder offsets can produce invalid asset paths.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetSupportedPackagesFromPackageReports.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetRuntimeTargets.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetRuntimeJsonValues.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetPackageVersion.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetPackageFromModule.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetPackageDestination.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetPackageDescription.cs Critical: the static description cache is not synchronized.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetMinimumNETStandard.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetLayoutFiles.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetLastStablePackage.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetInboxFrameworks.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetAssemblyReferences.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetApplicableAssetsFromPackages.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetApplicableAssetsFromPackageReports.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GenerateRuntimeDependencies.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GeneratePackageReport.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/GenerateNuSpec.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/FilterUnknownPackages.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/CreateTrimDependencyGroups.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/ApplyPreReleaseSuffix.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/ApplyMetaPackages.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Packaging/src/ApplyBaseLine.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/StabilizeWixFileId.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateMsiVersion.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateMacOSDistributionFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateGuidFromName.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateCurrentVersion.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/ExecWithRetries.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateWixCommandPackageDropBase.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateRpmPackage.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateMD5SumsFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateLightCommandPackageDrop.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateDebPackage.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateControlFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateChangelogFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Installers/Microsoft.DotNet.Build.Tasks.Installers.csproj Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.FileCatalog/GenerateFileCatalog.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.FileCatalog/CatalogEntry.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.FileCatalog/CatalogBuilder.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.FileCatalog.Tests/CatalogTests.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/PushToBuildStorage.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishSignedAssets.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishBuildToMaestro.cs Critical: the environment proxy still reads process-global environment state.
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestV4.cs Critical: shared credential detection still reads process-global environment state.
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestV3.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifest.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/LaunchDebugger.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/CreateAzureDevOpsFeed.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/ConfigureInputFeed.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/common/UploadToAzure.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/common/CreateNewAzureContainer.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/common/CreateAzureContainerIfNotExists.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/common/AzureStorageUtils.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/BlobFeedAction.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/AzureStorageExtensions.cs Reviewed; no final comment.
src/Microsoft.DotNet.Build.Tasks.Feed/src/AzureStorageAssetPublisher.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/ValidateLicense.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/Unsign.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/SingleError.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/SetCorFlags.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/SaveItems.cs Moderate: the saved output still uses the original relative path.
src/Microsoft.DotNet.Arcade.Sdk/src/LocateDotNet.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/InstallDotNetCore.cs Moderate: project loading and process start still use original relative paths.
src/Microsoft.DotNet.Arcade.Sdk/src/GroupItemsBy.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/GetLicenseFilePath.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/GetAssemblyFullName.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/GenerateSourcePackageSourceLinkTargetsFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/GenerateResxSource.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/GenerateChecksums.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/ExtractNgenMethodList.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/CompareVersions.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/CheckRequiredDotNetVersion.cs Reviewed; no final comment.
src/Microsoft.DotNet.Arcade.Sdk/src/CalculateAssemblyAndFileVersions.cs Reviewed; no final comment.
src/Common/Internal/BuildTask.cs Reviewed; no final comment.
eng/Version.Details.xml Reviewed; no final comment.
eng/Version.Details.props Reviewed; no final comment.
eng/MultiThreadableTaskAnalyzer.globalconfig Reviewed; no final comment.
eng/BuildTask.targets Reviewed; no final comment.
Directory.Packages.props Reviewed; no final comment.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Suppressed comments (16)

src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateLightCommandPackageDrop.cs:10

  • The derived task is annotated, but CreateWixCommandPackageDropBase still performs its core Directory/File operations with raw packageDropOutputFolder, OutputFolder, WixSrcFiles, and Loc paths. Relative inputs therefore continue to use the process current directory; the single resolved WixProjectFile copy here does not make the inherited execution safe. Thread TaskEnvironment through the base chain or leave this task unannotated.
    src/Microsoft.DotNet.Build.Tasks.Installers/src/ExecWithRetries.cs:17
  • The outer task is annotated, but each inner Microsoft.Build.Tasks.Exec is created without propagating the outer TaskEnvironment. Its working directory and child-process environment consequently fall back to process-global state, so relative commands/working directories can resolve incorrectly in a multi-threaded build. Add and assign the child task's TaskEnvironment, or do not opt this wrapper in.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/GeneratePackageReport.cs:24
  • The new environment plumbing does not reach RuntimeFile: both resolver constructors later pass the raw string to JsonRuntimeFormat.ReadRuntimeGraph. A relative runtime.json consequently remains process-current-directory dependent. Resolve RuntimeFile before constructing either resolver.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetApplicableAssetsFromPackages.cs:24
  • RuntimeFile is still passed unmodified to AggregateNuGetAssetResolver, whose constructor reads the file directly. Relative values therefore remain dependent on the process current directory despite this task being annotated; pass TaskEnvironment.GetAbsolutePath(RuntimeFile) instead.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/HarvestPackage.cs:20
  • RuntimeFile is still passed raw to both NuGet resolver constructors, which read it directly. Relative runtime graph paths therefore bypass the newly injected project directory and can load/fail against the process current directory. Resolve this input before constructing the resolvers.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetPack.cs:17
  • This task is now marked multithreadable, but BaseDirectory is passed unchanged to PackageBuilder.PopulateFiles. If a caller supplies a relative base directory, NuGet resolves the package files against the process current directory rather than TaskEnvironment.ProjectDirectory, so -mt can pack the wrong files. Resolve BaseDirectory through TaskEnvironment before passing it to the NuGet API.
    src/Microsoft.DotNet.Deployment.Tasks.Links/src/CreateAkaMSLinks.cs:12
  • The shared AkaMSLinksBase helper reads ClientCertificate with File.ReadAllText directly. For a relative certificate path, this annotated task still resolves against the process current directory rather than the project directory supplied by TaskEnvironment, so concurrent projects can read the wrong file or fail. Add TaskEnvironment plumbing and resolve the certificate path before enabling the annotation.
    src/Microsoft.DotNet.Deployment.Tasks.Links/src/DeleteAkaMSLinks.cs:11
  • The shared AkaMSLinksBase helper reads ClientCertificate with File.ReadAllText directly. For a relative certificate path, this annotated task still resolves against the process current directory rather than the project directory supplied by TaskEnvironment, so concurrent projects can read the wrong file or fail. Add TaskEnvironment plumbing and resolve the certificate path before enabling the annotation.
    src/Microsoft.DotNet.Helix/Sdk/CheckAzurePipelinesTestResults.cs:16
  • This task now runs concurrently with other AzureDevOpsTask instances, but the base class uses one static Random for GetRetryDelay. Random instances are not thread-safe, so concurrent retries race on the generator and can produce corrupted/non-random backoff values, defeating retry staggering. Use Random.Shared or an instance-local generator before opting these tasks into multithreaded execution.
    src/Microsoft.DotNet.Helix/Sdk/CheckAzurePipelinesTestResults.cs:16
  • This annotation also opts the AzureDevOpsTask base implementation into in-process multi-threading, but that base reads BUILD_*, SYSTEM_*, and the access token via Environment.GetEnvironmentVariable. Those values are process-global rather than the injected per-project task environment, so concurrent projects can observe the wrong build credentials/metadata. Thread TaskEnvironment through the base or leave these derived tasks TaskHost-routed.
    src/Microsoft.DotNet.Helix/Sdk/CreateFailedTestsForFailedWorkItems.cs:15
  • This task now runs concurrently with other AzureDevOpsTask instances, but the base class uses one static Random for GetRetryDelay. Random instances are not thread-safe, so concurrent retries race on the generator and can produce corrupted/non-random backoff values, defeating retry staggering. Use Random.Shared or an instance-local generator before opting these tasks into multithreaded execution.
    src/Microsoft.DotNet.Helix/Sdk/InstallDotNetTool.cs:18
  • This task is annotated while inheriting MSBuildTaskBase, which has no TaskEnvironment; DestinationPath, ToolPath, and WorkingDirectory are passed to FileSystem/Command unchanged. Relative paths and the command's inherited environment therefore still depend on the process current directory/environment. Resolve these inputs and propagate the task environment through the helper interfaces, or keep the task out of in-process multi-threading.
    src/Microsoft.DotNet.Helix/Sdk/StartAzurePipelinesTestRun.cs:13
  • This task now runs concurrently with other AzureDevOpsTask instances, but the base class uses one static Random for GetRetryDelay. Random instances are not thread-safe, so concurrent retries race on the generator and can produce corrupted/non-random backoff values, defeating retry staggering. Use Random.Shared or an instance-local generator before opting these tasks into multithreaded execution.
    src/Microsoft.DotNet.Helix/Sdk/StopAzurePipelinesTestRun.cs:13
  • This task now runs concurrently with other AzureDevOpsTask instances, but the base class uses one static Random for GetRetryDelay. Random instances are not thread-safe, so concurrent retries race on the generator and can produce corrupted/non-random backoff values, defeating retry staggering. Use Random.Shared or an instance-local generator before opting these tasks into multithreaded execution.
    src/Microsoft.DotNet.SourceBuild/tasks/src/ReadNuGetPackageInfos.cs:13
  • PackagePaths is a plain string array, and ReadIdentity passes each value directly to PackageArchiveReader. Relative package paths therefore still resolve against the process current directory despite this task being annotated. Inject TaskEnvironment and resolve the paths before opening them (including callers of the static helper).
    src/Microsoft.DotNet.SourceBuild/tasks/src/UsageReport/WritePackageUsageData.cs:24
  • The four package-file arrays are still passed directly to ReadNuGetPackageInfos.ReadIdentity, which opens each string as-is. Relative nupkg paths therefore use the process current directory even though this task now has a per-project TaskEnvironment; pass resolved paths into the helper.
  • Files reviewed: 184/184 changed files
  • Comments generated: 17
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings August 21, 2026 20:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (17)

src/Microsoft.DotNet.Arcade.Sdk/src/SaveItems.cs:53

  • The directory is now resolved through TaskEnvironment, but project.Save(File) below still passes the raw path. With a relative File in an in-process multithreaded build, the directory can be created under the project directory while the generated project is written relative to the process current directory. Save using the same environment-resolved path.
                Directory.CreateDirectory(TaskEnvironment.GetAbsolutePath(path));

src/Microsoft.DotNet.Arcade.Sdk/src/SingleError.cs:9

  • The get-then-register sequence is not atomic. Two concurrently scheduled SingleError instances with the same text can both observe no sentinel and both log an error, defeating the task's single-error contract. Synchronize the check/registration or use an atomic build-scoped gate before opting this task into multithreaded execution.
    [MSBuildMultiThreadableTask]

src/Microsoft.DotNet.Build.Tasks.Feed/src/LaunchDebugger.cs:11

  • Debugger.Launch() depends on process-wide debugger state and can prompt or attach the debugger for the entire MSBuild process. That is not safe for a task opted into in-process multithreaded execution; remove the multithreadable annotation from this diagnostic-only task.
    [MSBuildMultiThreadableTask]
    public class LaunchDebugger : Microsoft.Build.Utilities.Task

src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifest.cs:28

  • The concrete task is opted into multithreading, but its inherited PublishArtifactsInManifestBase still calls Environment.GetEnvironmentVariable directly when deciding whether Entra credentials are available. The injected TaskEnvironment on this class is therefore not used for that decision, so concurrent project executions still depend on process-global environment state. Move the check into the environment-aware plumbing in the base class, or remove the opt-in until that migration is complete.
    src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestV4.cs:21
  • This annotation opts the task into in-process execution even though the inherited PublishArtifactsInManifestBase reads Azure credential variables with Environment.GetEnvironmentVariable and has no TaskEnvironment plumbing. That makes the task depend on process-global state, contrary to the multithreadable-task contract. Either thread the environment through the base class or leave this task unannotated.
    src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishBuildToMaestro.cs:35
  • Several execution paths still call _getEnvProxy.GetEnv, whose implementation uses Environment.GetEnvironmentVariable directly (for example, the Azure DevOps collection URI, project, and build identifiers). The task is now annotated and has a TaskEnvironment, but those reads bypass it and retain process-global behavior. Replace the proxy with the injected environment before opting this task into multithreading.
    src/Microsoft.DotNet.Build.Tasks.Feed/src/PushToBuildStorage.cs:48
  • This task is now routed as multithreadable, but it has no TaskEnvironment; the injected file system receives paths such as package.OriginalFile, the local storage directories, and AssetManifestPath without project-relative normalization. Any relative input still uses the process current directory. Normalize the task's path inputs before model/file-system operations or leave it TaskHost-routed.
    src/Microsoft.DotNet.Build.Tasks.Feed/src/common/UploadToAzure.cs:20
  • This task is now opted into concurrent in-process execution, but TokenSource is static and Cancel() cancels that shared source. Cancelling one task instance therefore cancels every concurrently running UploadToAzure invocation, causing unrelated uploads to stop. Make the cancellation source/token instance-owned before enabling multithreaded execution.
    src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateMD5SumsFile.cs:42
  • The file is opened via TaskEnvironment.GetAbsolutePath, but the emitted relative name still subtracts the raw RootDirectory length from the raw ItemSpec. When these inputs are project-relative, the checksum file contains a malformed path (or throws) even though hashing succeeded. Compute the relative name from the same normalized file and root paths.
    src/Microsoft.DotNet.Build.Tasks.Installers/src/ExecWithRetries.cs:18
  • This wrapper opts into in-process multithreading but delegates to Microsoft.Build.Tasks.Exec without injecting a per-project environment or resolving WorkingDirectory. A relative working directory therefore still uses the process current directory, and the child process inherits ambient process state. Keep this task TaskHost-routed (or replace the wrapper with a ToolTask implementation using TaskEnvironment).
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/GeneratePackageReport.cs:15
  • This task now runs in-process and calls FrameworkUtilities, whose shared FrameworkReducer is initialized through an unsynchronized if (s_reducer == null) s_reducer = new FrameworkReducer() lazy path. Concurrent first use can race on that static state, so this opt-in does not meet the thread-safety requirement. Make the helper use Lazy<FrameworkReducer>/synchronized initialization (and audit the other newly annotated callers) before enabling this task.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/HarvestPackage.cs:619
  • This helper has the same mismatch: it enumerates from TaskEnvironment.GetAbsolutePath(packageFolder) but strips packageFolder.Length from the resulting absolute path. Relative package folders therefore yield incorrect item paths. Keep the normalized folder in the relative-path calculation.
    src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAndroidWorkItems.cs:18
  • The annotated task passes APK metadata through XHarnessTaskBase.GetNameAndPath and raw IFileSystem operations, but neither the task nor the base has a TaskEnvironment. A relative APK path (and the generated payload path) is consequently resolved against the process current directory rather than the project directory. Normalize these paths before the helper/file-system calls or remove the annotation.
    src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAppleWorkItems.cs:18
  • The annotated task passes app-bundle and temporary paths through XHarnessTaskBase/raw IFileSystem operations without a TaskEnvironment. Relative inputs are therefore still resolved against the process current directory in multithreaded builds. Normalize all paths before this helper chain or remove the annotation.
    src/Microsoft.DotNet.Helix/Sdk/FindDotNetCliPackage.cs:21
  • The task is now eligible to run concurrently, but its HTTP client is stored in the static mutable _client field and reassigned for every task instance. Concurrent invocations can overwrite each other's client while requests are in flight, so one task can use another task's handler/configuration. Make the client instance-owned (and dispose it appropriately), or do not opt this task into multithreaded execution.
    src/Microsoft.DotNet.Helix/Sdk/InstallDotNetTool.cs:18
  • This task is annotated, but its destination, dotnet executable, working directory, and mutex/file-system paths are passed through raw IFileSystem/command APIs with no TaskEnvironment. Relative inputs therefore still resolve against the process current directory in multithreaded builds. Inject and apply the task environment to every path, or do not opt this task in.
    src/Microsoft.DotNet.SourceBuild/tasks/src/UsageReport/WritePackageUsageData.cs:146
  • The files returned here are absolute because GetAbsolutePath(RootDir) is used, but GetPathRelativeToRoot still compares them with the unnormalized RootDir. If RootDir is relative, every discovered asset path fails the StartsWith check and the task throws instead of producing usage data. Normalize RootDir once with TaskEnvironment before both the scan and relative-path calculation.
  • Files reviewed: 185/185 changed files
  • Comments generated: 15
  • Review effort level: Lite

ViktorHofer added a commit to dotnet/dotnet that referenced this pull request Aug 23, 2026
Copilot's reviewer found two bug classes on dotnet/arcade#17381 that my own
audit missed, plus the two races I had already fixed independently.

1. Paths resolved at one site but used raw at another. These do not throw;
   they silently produce wrong results, which is why the null-guard audit
   did not surface them:

   - HarvestPackage enumerated the resolved absolute folder but computed
     package-relative paths with Substring(rawPath.Length + 1), so a relative
     PackagesFolders entry misclassified every harvested asset. Fixed at the
     source: LocatePackageFolder now returns an absolute path, so every
     downstream use agrees.
   - WritePackageUsageData compared absolute enumeration results against a raw
     RootDir in both GetPathRelativeToRoot and the ProjectDirectories
     validation, throwing for every discovered file when RootDir is relative.
     Added AbsoluteRootDir, which preserves any trailing separator because
     callers depend on the stripped result staying relative.
   - UpdateXlf's exception filter compared FileNotFoundException.FileName
     against the unresolved path, turning a friendly BuildErrorException into
     an unhandled exception.
   - SaveItems created the resolved directory but saved to the raw path;
     InstallDotNetCore checked the resolved VersionsPropsPath but loaded the
     raw one and launched the raw DotNetInstallScript; WriteBuildOutputProps
     filtered AdditionalAssetDirs with an unresolved Directory.Exists.

2. Tasks annotated despite process-global state inherited from a base class.
   The analyzer does not walk into base types, so these all passed a clean
   analyzer run. De-annotated with TODOs pointing at arcade#17378:

   - The five Feed publishing tasks (PublishArtifactsInManifestBase reads
     AZURESUBSCRIPTION_*, SYSTEM_ACCESSTOKEN and workload-identity variables
     from the process environment; PublishBuildToMaestro goes through
     _getEnvProxy).
   - Four AzureDevOpsTask derivatives (same environment reads plus a shared
     static Random for retry jitter).
   - Two RoslynBuildTask derivatives (process-wide AssemblyLoadContext.Resolving).
   - SignCheckTask (static _fileVerifiers populated per manager construction),
     FindDotNetCliPackage (static HttpClient overwritten per execution),
     CreateLightCommandPackageDrop (base still uses raw paths).

   FinalizeInsertionVsixFile and ReadNuGetPackageInfos were annotated but never
   implemented IMultiThreadableTask, so TaskEnvironment was never injected and
   every resolution silently used Fallback. Both are now fully migrated instead.

Also keyed the LocateDotNet and CheckRequiredDotNetVersion build-scoped caches
by repository and SDK version; they are registered per build, not per project,
so a second repository could reuse the first one's result.

UpdatePackageIndex is deliberately left annotated: it passes a single
AbsolutePath to PackageIndex.Load, which binds to the uncached overload rather
than the cached IEnumerable one, so it never shares a mutable index.

Annotated tasks: 119 of 136. Arcade builds clean (0 warnings, 0 errors);
PackageTesting (9), Packaging (48) and Feed (214) tests pass. The one
Arcade.Sdk.Tests failure is the pre-existing NU1009 SwixBuild conflict, which
this change does not touch.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 23, 2026 07:18
Copilot stopped reviewing on behalf of ViktorHofer due to an error August 23, 2026 07:39
MSBuild 18.x can execute tasks on multiple threads inside a single node
(`-mt`), but only for tasks that opt in via [MSBuildMultiThreadableTask].
Everything else is routed to an out-of-proc sidecar TaskHost, which is far
more expensive than the in-proc path.

Measuring a runtime inner-repo build in the VMR with `-mt -nodeReuse:true`
against a baseline showed only a 3.6% wall-clock improvement, because none of
Arcade's tasks were annotated: TaskHost task invocations went from 849 to
14,125 and total task time went *up* by 98 seconds, cancelling out most of the
gain from threading.

This annotates 133 of Arcade's 136 concrete tasks and makes the supporting
code multi-threading safe:

- Update the MSBuild package dependencies from 17.12.50 to 18.8.2, which is the
  first version exposing both [MSBuildMultiThreadableTask]/IMultiThreadableTask
  and ToolTask.TaskEnvironment.
- Reference Microsoft.Build.TaskAuthoring.Analyzer from eng/BuildTask.targets so
  new violations are caught at build time. eng/MultiThreadableTaskAnalyzer.globalconfig
  scopes it to tasks that have already opted in, and disables the API-shape
  suggestions (MSBuildTask0006-0008, 0011) which would be binary-breaking for
  task parameters set from targets across the ecosystem.
- Replace ambient process state with the injected TaskEnvironment: relative
  paths now resolve against the project directory instead of the process-wide
  current directory, environment variables are read per-project, and child
  processes are started from TaskEnvironment.GetProcessStartInfo().
- Thread AbsolutePath through the shared path helpers in Packaging, GenFacades,
  Feed, NuGetRepack, SharedFramework.Sdk, PackageTesting and XliffTasks.
- Fix a real data race: TargetFrameworkResolver.CreateOrGet used an
  unsynchronized static Dictionary cache. It is now a ConcurrentDictionary.
- Stop sharing a static Newtonsoft JsonSerializer instance in PackageIndex.
- Delete the internal BuildTask/ILog base class. It only wrapped
  Microsoft.Build.Utilities.Task and TaskLoggingHelper, and standing between
  tasks and the MSBuild base class meant every derived task needed its own
  TaskEnvironment plumbing. Tasks now derive from Microsoft.Build.Utilities.Task
  directly and use Log/TaskLoggingHelper.

SignToolTask, CreateVisualStudioWorkload and CreateVisualStudioWorkloadSet are
deliberately left unannotated. Their helper chains (BatchSignUtil, ZipData,
Configuration, VerifySignatures, WorkloadPackageBase, MsiBase, SwixProject, ...)
still resolve paths against the process-wide current directory, and converting
them is a much larger change. Each carries a TODO pointing at the tracking
issue. Both run once per build, so keeping them TaskHost-routed costs
effectively nothing.

Contributes to dotnet#17378

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (1)

src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishBuildToMaestro.cs:39

  • IMultiThreadableTask is documented as a thread-safe routing signal, even though the current router bug ignores interface-only implementations. Once fixed, this task would run in-process while _getEnvProxy still reads ambient process environment. Remove the interface until environment access is migrated.
  • Files reviewed: 186/186 changed files
  • Comments generated: 14
  • Review effort level: Balanced

- GetPackageDescription: stop memoizing failed description loads. GetOrAdd cached
  the null returned after an IOException, so every later invocation on the node
  silently got null without retrying or re-logging.
- GetAssemblyFullName, ExecWithRetries: implement IMultiThreadableTask and resolve
  paths through TaskEnvironment. ExecWithRetries forwards its TaskEnvironment into
  the nested Exec instance, which MSBuild does not inject into because the task
  constructs it directly.
- InstallDotNetTool, PushToBuildStorage, SingleError, LaunchDebugger: remove the
  MSBuildMultiThreadableTask attribute. These are not yet safe to run in-process,
  so they must keep routing to a TaskHost until they are migrated properly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 23, 2026 18:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings September 1, 2026 09:50
Removed remarks comment regarding token handling.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Review tier: Balanced
Findings: None

Copilot AI review requested due to automatic review settings September 1, 2026 10:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 12 Medium severity

New issues introduced by this change (12)
Severity Finding
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogEntry.cs — Changing this public packaged API from string to AbsolutePath is source- and binary-breaking;…
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogBuilder.cs — Replacing the public AddFile(string, ...) signature breaks existing source and compiled consumers…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageReport.cs — Changing this public method from Save(string) to Save(AbsolutePath) removes the existing…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageItem.cs — Changing the public SourcePath property type from string to AbsolutePath breaks both source…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​VersionUtility.cs — This replaces the public GetAssemblyVersion(string) API and will break compiled callers. Keep the…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​ValidateHarvestVersionIsLatestForRelease.cs — This protected virtual signature is part of the public task’s subclassing contract; changing it…
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — The public Execute method’s four path parameters changed from strings to AbsolutePath, which is…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​AzureStorageExtensions.cs — Replacing the public CalculateMD5(string) extension helper with an AbsolutePath signature…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​common/​AzureStorageUtils.cs — This public method previously accepted string; replacing that signature breaks compiled callers.…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetUtility.cs — Changing this public helper’s parameter from string to AbsolutePath removes the old binary API.…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageIndex.cs — The PackageIndex type is public in a packable assembly, and this migration replaces its…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetPack.cs — The existing public Pack(string, string, Manifest, bool) method has been replaced by this…
Suppressed comments (4)

src/Microsoft.DotNet.XliffTasks/Tasks/XlfTask.cs:12

  • This makes the task assembly unloadable on MSBuild hosts that predate these new framework types, rather than leaving the opt-in “inert” as the PR description states. Build-task packages exclude Microsoft.Build.Framework runtime assets (eng/BuildTask.targets:33-38), so an older host supplies its own framework assembly; resolving this class then fails when IMultiThreadableTask/TaskEnvironment are absent. Either establish a minimum MSBuild 18.8 host requirement or ship a down-level-compatible task assembly/shim before adding these type references.
    src/Microsoft.DotNet.Build.Tasks.FileCatalog/CatalogBuilder.cs:98
  • Replacing the public WriteTo(string) method is a binary-breaking API change. Retain the old overload and delegate to the AbsolutePath implementation to preserve consumers while keeping the task path-safe.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageReport.cs:53
  • Removing Load(string) is a source- and binary-breaking change to this public packaged type. Preserve that overload and delegate to the typed path implementation.
    src/Microsoft.DotNet.Build.Tasks.Feed/src/AzureStorageExtensions.cs:26
  • Changing this public extension method from string to AbsolutePath is a binary-breaking API change. Keep a string overload for existing consumers and forward it to the typed overload.
        public static async Task<bool> IsFileIdenticalToBlobAsync(this BlobClient client, AbsolutePath file)

/// V2 catalogs do not carry per-member file names); it is retained only for diagnostics.
/// </param>
public static CatalogEntry FromFile(string filePath, string? name = null)
public static CatalogEntry FromFile(AbsolutePath filePath, string? name = null)
Comment on lines 81 to 82
public CatalogBuilder AddFile(AbsolutePath filePath, string? name = null)
=> Add(CatalogEntry.FromFile(filePath, name));
public PackageAsset[] UnusedAssets { get; set; }

public void Save(string path)
public void Save(AbsolutePath path)
public bool IsRef { get; }
public ITaskItem OriginalItem { get; }
public string SourcePath { get; }
public AbsolutePath SourcePath { get; }


public static Version GetAssemblyVersion(string assemblyPath)
public static Version GetAssemblyVersion(AbsolutePath assemblyPath)
public static class AzureStorageExtensions
{
public static string CalculateMD5(string filename)
public static string CalculateMD5(AbsolutePath filename)
Comment on lines 139 to 140
public async Task<bool> IsFileIdenticalToBlobAsync(AbsolutePath localFileFullPath, string blobPath) =>
await GetBlob(blobPath).IsFileIdenticalToBlobAsync(localFileFullPath);
}

public static void WriteRuntimeGraph(string filePath, RuntimeGraph runtimeGraph)
public static void WriteRuntimeGraph(AbsolutePath filePath, RuntimeGraph runtimeGraph)
public HashSet<string> IndexSources { get; set; } = new HashSet<string>(StringComparer.OrdinalIgnoreCase);

public static PackageIndex Load(IEnumerable<string> packageIndexFiles)
public static PackageIndex Load(IEnumerable<AbsolutePath> packageIndexFiles)
}

public void Pack(string nuspecPath, string nupkgPath, Manifest manifest, bool packSymbols)
public void Pack(string nuspecPath, AbsolutePath absoluteNuspecPath, string nupkgPath, Manifest manifest, bool packSymbols)
ViktorHofer and others added 2 commits September 7, 2026 11:41
# Conflicts:
#	eng/BuildTask.targets
#	eng/MultiThreadableTaskAnalyzer.globalconfig
#	eng/Version.Details.props
#	eng/Version.Details.xml
#	src/Microsoft.DotNet.Build.Tasks.Workloads/src/Wix/WixToolTaskBase.cs
#	src/Microsoft.DotNet.Helix/Sdk/AzureDevOpsTask.cs
The merge picks up analyzer 18.12 and the globalconfig from dotnet#17491, which
enables MSBuildTask0013 and deepens the MSBuildTask0005 call-chain analysis.
Both report on tasks this branch deliberately leaves out of the migration.

MSBuildTask0013 flags a task that declares IMultiThreadableTask without
[MSBuildMultiThreadableTask]. That combination is intentional here and each
class already documents why: the interface is what makes MSBuild assign
TaskEnvironment (TaskExecutionHost only tests the interface, so it is assigned
in the task host too), while the attribute alone decides routing. Suppressed at
each of the 13 declarations rather than in the globalconfig, so the rule keeps
guarding against an accidental half-migration everywhere else.

MSBuildTask0005 reports 150 file system calls reached through the SignTool and
Workloads helper chains. Those chains are the documented reason SignToolTask and
CreateVisualStudioWorkload are not opted in, so the tasks stay out-of-proc and
the calls remain correct. Neither project contains a task carrying the
attribute, so the rule has nothing in scope there today; suppressed per project
with a pointer to the class comments and issue dotnet#17378. Verified the rule still
fires elsewhere by temporarily reintroducing a violation in Arcade.Sdk.

Also extends the existing NuGetVersionUpdater suppression to 0005, which now
reports the same already-justified Path.GetTempPath call transitively.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: be19d794-fe4f-43fe-9e6e-f6e6b13ec6e7
Copilot AI review requested due to automatic review settings September 7, 2026 09:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Path canonicalization regressions and unresolved public API compatibility breaks can produce incorrect task behavior and consumer failures.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 16 Medium severity

New issues introduced by this change (4)
Severity Finding
Medium severity src/​Microsoft.DotNet.Build.Tasks.Templating/​src/​GenerateFileFromTemplate.cs — This no longer preserves the documented behavior of ResolvedOutputPath: GetAbsolutePath roots…
Medium severity src/​Microsoft.DotNet.CMake.Sdk/​src/​GetCMakeArtifactsFromFileApi.cs — This replaces Path.GetFullPath with an API that roots but does not canonicalize. A valid…
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — AbsolutePath equality compares the unnormalized stored value. Removing Path.GetFullPath means…
Medium severity src/​Microsoft.DotNet.SignTool/​src/​SignToolTask.cs — GetAbsolutePath only roots paths; MSBuild 18.8.2 does not canonicalize .. segments. Because…
Pre-existing issues (12)
Severity Finding
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetPack.cs — The existing public Pack(string, string, Manifest, bool) method has been replaced by this… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageIndex.cs — The PackageIndex type is public in a packable assembly, and this migration replaces its… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetUtility.cs — Changing this public helper’s parameter from string to AbsolutePath removes the old binary API.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​common/​AzureStorageUtils.cs — This public method previously accepted string; replacing that signature breaks compiled callers.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​AzureStorageExtensions.cs — Replacing the public CalculateMD5(string) extension helper with an AbsolutePath signature… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — The public Execute method’s four path parameters changed from strings to AbsolutePath, which is… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​ValidateHarvestVersionIsLatestForRelease.cs — This protected virtual signature is part of the public task’s subclassing contract; changing it… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​VersionUtility.cs — This replaces the public GetAssemblyVersion(string) API and will break compiled callers. Keep the… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageItem.cs — Changing the public SourcePath property type from string to AbsolutePath breaks both source… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageReport.cs — Changing this public method from Save(string) to Save(AbsolutePath) removes the existing… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogBuilder.cs — Replacing the public AddFile(string, ...) signature breaks existing source and compiled consumers… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogEntry.cs — Changing this public packaged API from string to AbsolutePath is source- and binary-breaking;… View comment
Suppressed comments (2)

src/Microsoft.DotNet.CMake.Sdk/src/GetCMakeArtifactsFromFileApi.cs:138

  • GetAbsolutePath does not collapse relative segments. If a CMake directory source contains .., this value remains non-canonical and cannot match the canonical project source path. Retain the previous Path.GetFullPath normalization after project-aware resolution.
    src/Microsoft.DotNet.CMake.Sdk/src/GetCMakeArtifactsFromFileApi.cs:191
  • The old Path.GetFullPath canonicalized artifact paths, while GetAbsolutePath only makes them rooted. Emitting paths that retain .. or duplicate separators changes the task output identity and can defeat downstream item comparisons and incremental checks. Canonicalize the resolved path before creating the item.

Comment on lines +73 to +74
AbsolutePath resolvedOutputPath = TaskEnvironment.GetAbsolutePath(OutputPath.Replace('\\', '/'));
ResolvedOutputPath = resolvedOutputPath;

// Normalize source directory for comparison
string normalizedSourceDir = Path.GetFullPath(SourceDirectory).Replace('\\', '/').TrimEnd('/');
string normalizedSourceDir = TaskEnvironment.GetAbsolutePath(SourceDirectory).Value.Replace('\\', '/').TrimEnd('/');
// Normalizing and Removing Relative Segments from the seed paths.
string[] distinctSeeds = seeds.Select(seed => Path.GetFullPath(seed)).Distinct().ToArray();
string[] seedNames = distinctSeeds.Select(seed => Path.GetFileName(seed)).ToArray();
AbsolutePath[] distinctSeeds = seeds.Distinct().ToArray();
}

var directoryParts = Path.GetFullPath(Path.GetDirectoryName(itemToSign.ItemSpec)).Split(separators);
var directoryParts = TaskEnvironment.GetAbsolutePath(Path.GetDirectoryName(itemToSign.ItemSpec)).Value.Split(separators);
# Conflicts:
#	src/Microsoft.DotNet.Arcade.Sdk/src/CheckRequiredDotNetVersion.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/GenerateChecksums.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/GenerateResxSource.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/GenerateSourcePackageSourceLinkTargetsFile.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/GetAssemblyFullName.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/InstallDotNetCore.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/LocateDotNet.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/SetCorFlags.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/SingleError.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/Unsign.cs
#	src/Microsoft.DotNet.Build.Tasks.Feed/src/CreateAzureDevOpsFeed.cs
#	src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestV3.cs
#	src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestV4.cs
#	src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishBuildToMaestro.cs
#	src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishSignedAssets.cs
#	src/Microsoft.DotNet.Build.Tasks.Feed/src/common/AzureConnectionStringBuildTask.cs
#	src/Microsoft.DotNet.Build.Tasks.Feed/src/common/CreateAzureContainerIfNotExists.cs
#	src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateControlFile.cs
#	src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateLightCommandPackageDrop.cs
#	src/Microsoft.DotNet.Build.Tasks.Installers/src/GenerateMacOSDistributionFile.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/CreateTrimDependencyGroups.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/FilterUnknownPackages.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GenerateNuSpec.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GeneratePackageReport.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GenerateRuntimeDependencies.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetApplicableAssetsFromPackageReports.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetApplicableAssetsFromPackages.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetAssemblyReferences.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetInboxFrameworks.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetLastStablePackage.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetLayoutFiles.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetPackageDescription.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetPackageFromModule.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/GetSupportedPackagesFromPackageReports.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/HarvestPackage.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetPack.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/SplitReferences.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/UpdatePackageIndex.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidateFrameworkPackage.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidatePackage.cs
#	src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidationTask.cs
#	src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/ChooseBestP2PTargetFrameworkTask.cs
#	src/Microsoft.DotNet.Build.Tasks.TargetFramework/src/ChooseBestTargetFrameworksTask.cs
#	src/Microsoft.DotNet.Deployment.Tasks.Links/src/AkaMSLinksBase.cs
#	src/Microsoft.DotNet.Deployment.Tasks.Links/src/DeleteAkaMSLinks.cs
#	src/Microsoft.DotNet.GenAPI/GenAPITask.cs
#	src/Microsoft.DotNet.GenFacades/GenPartialFacadeSource.cs
#	src/Microsoft.DotNet.Helix/Sdk/BaseTask.cs
#	src/Microsoft.DotNet.Helix/Sdk/DownloadFromResultsContainer.cs
#	src/Microsoft.DotNet.Helix/Sdk/FindDotNetCliPackage.cs
#	src/Microsoft.DotNet.Helix/Sdk/SendHelixJob.cs
#	src/Microsoft.DotNet.NuGetRepack/tasks/src/NuGetVersionUpdater.cs
#	src/Microsoft.DotNet.NuGetRepack/tasks/src/ReplacePackageParts.cs
#	src/Microsoft.DotNet.NuGetRepack/tasks/src/UpdatePackageVersionTask.cs
#	src/Microsoft.DotNet.NuGetRepack/tests/VersionUpdaterTests.cs
#	src/Microsoft.DotNet.PackageTesting/GetCompatiblePackageTargetFrameworks.cs
#	src/Microsoft.DotNet.SharedFramework.Sdk/src/CreateFrameworkListFile.cs
#	src/Microsoft.DotNet.SharedFramework.Sdk/src/FileUtilities.cs
#	src/Microsoft.DotNet.SharedFramework.Sdk/src/GeneratePlatformManifestEntriesFromFileList.cs
#	src/Microsoft.DotNet.SharedFramework.Sdk/src/GeneratePlatformManifestEntriesFromTemplate.cs
#	src/Microsoft.DotNet.SharedFramework.Sdk/src/GenerateSharedFrameworkDepsFile.cs
#	src/Microsoft.DotNet.SharedFramework.Sdk/src/ValidateFileVersions.cs
#	src/Microsoft.DotNet.SignCheckTask/SignCheckTask.cs
#	src/Microsoft.DotNet.SignTool/src/SignToolTask.cs
#	src/Microsoft.DotNet.SourceBuild/tasks/src/ReadNuGetPackageInfos.cs
#	src/Microsoft.DotNet.SourceBuild/tasks/src/UsageReport/WritePackageUsageData.cs
#	src/Microsoft.DotNet.SourceBuild/tasks/src/UsageReport/WriteUsageReports.cs
#	src/Microsoft.DotNet.SourceBuild/tasks/src/WriteBuildOutputProps.cs
#	src/Microsoft.DotNet.SwaggerGenerator/Microsoft.DotNet.SwaggerGenerator.MSBuild/GenerateSwaggerCode.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/EnsureAllResourcesTranslated.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/GatherTranslatedSource.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/SortXlf.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/TransformTemplates.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/TranslateSource.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/UpdateXlf.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/XlfTask.cs
Copilot AI review requested due to automatic review settings September 8, 2026 10:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Replacing Path.GetFullPath with non-canonicalizing path resolution introduces incorrect comparisons and outputs for valid paths containing relative segments.

Review tier: Balanced
Findings: 16 Medium severity

Pre-existing issues (16)
Severity Finding
Medium severity src/​Microsoft.DotNet.SignTool/​src/​SignToolTask.cs — GetAbsolutePath only roots paths; MSBuild 18.8.2 does not canonicalize .. segments. Because… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — AbsolutePath equality compares the unnormalized stored value. Removing Path.GetFullPath means… View comment
Medium severity src/​Microsoft.DotNet.CMake.Sdk/​src/​GetCMakeArtifactsFromFileApi.cs — This replaces Path.GetFullPath with an API that roots but does not canonicalize. A valid… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Templating/​src/​GenerateFileFromTemplate.cs — This no longer preserves the documented behavior of ResolvedOutputPath: GetAbsolutePath roots… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetPack.cs — The existing public Pack(string, string, Manifest, bool) method has been replaced by this… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageIndex.cs — The PackageIndex type is public in a packable assembly, and this migration replaces its… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetUtility.cs — Changing this public helper’s parameter from string to AbsolutePath removes the old binary API.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​common/​AzureStorageUtils.cs — This public method previously accepted string; replacing that signature breaks compiled callers.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​AzureStorageExtensions.cs — Replacing the public CalculateMD5(string) extension helper with an AbsolutePath signature… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — The public Execute method’s four path parameters changed from strings to AbsolutePath, which is… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​ValidateHarvestVersionIsLatestForRelease.cs — This protected virtual signature is part of the public task’s subclassing contract; changing it… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​VersionUtility.cs — This replaces the public GetAssemblyVersion(string) API and will break compiled callers. Keep the… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageItem.cs — Changing the public SourcePath property type from string to AbsolutePath breaks both source… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageReport.cs — Changing this public method from Save(string) to Save(AbsolutePath) removes the existing… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogBuilder.cs — Replacing the public AddFile(string, ...) signature breaks existing source and compiled consumers… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogEntry.cs — Changing this public packaged API from string to AbsolutePath is source- and binary-breaking;… View comment
Suppressed comments (4)

src/Microsoft.DotNet.Build.Tasks.Templating/src/GenerateFileFromTemplate.cs:74

  • GetAbsolutePath roots the value but does not canonicalize .. segments or separators like the previous Path.GetFullPath call. ResolvedOutputPath is consumed by FileWrites and incremental build inputs/outputs, so equivalent paths can now be treated as different items. Preserve canonicalization after resolving against the project directory.
    src/Microsoft.DotNet.CMake.Sdk/src/GetCMakeArtifactsFromFileApi.cs:109
  • GetAbsolutePath does not canonicalize ... Since this value is compared with the CMake codemodel's canonical source path, a valid input such as $(MSBuildProjectDirectory)/../../native can stop matching and report that the source directory is absent. Canonicalize after project-aware resolution; the same normalization is needed at lines 138 and 191.
    src/Microsoft.DotNet.GenFacades/GenPartialFacadeSourceGenerator.cs:36
  • AbsolutePath equality uses the stored, non-canonical value. Removing Path.GetFullPath means equivalent seeds such as a/../b.dll and b.dll no longer deduplicate, so the filename-count check can incorrectly report multiple assembly versions. Canonicalize each resolved seed before Distinct().
    src/Microsoft.DotNet.SignTool/src/SignToolTask.cs:398
  • This replaced Path.GetFullPath with an API that only roots paths. A rooted ItemsToSign path containing .. now reaches Split unnormalized, which can compute an incorrect common enclosing directory. Preserve the former canonicalization after project-aware resolution.

# Conflicts:
#	src/Microsoft.DotNet.Build.Tasks.FileCatalog.Tests/CatalogTests.cs
#	src/Microsoft.DotNet.Build.Tasks.FileCatalog/CatalogBuilder.cs
#	src/Microsoft.DotNet.Build.Tasks.FileCatalog/CatalogEntry.cs
#	src/Microsoft.DotNet.Build.Tasks.FileCatalog/GenerateFileCatalog.cs
#	src/Microsoft.DotNet.Build.Tasks.Templating/src/GenerateFileFromTemplate.cs
#	src/Microsoft.DotNet.CMake.Sdk/src/GetCMakeArtifactsFromFileApi.cs
#	src/Microsoft.DotNet.XliffTasks/Model/Document.cs
#	src/Microsoft.DotNet.XliffTasks/Model/XlfDocument.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/GatherTranslatedSource.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/SortXlf.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/TransformTemplates.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/TranslateSource.cs
#	src/Microsoft.DotNet.XliffTasks/Tasks/UpdateXlf.cs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Older-host task loading and the changed optional authentication behavior remain unresolved compatibility concerns.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 1 High severity · 17 Medium severity

New issues introduced by this change (2)
Severity Finding
High severity src/​Microsoft.DotNet.SwaggerGenerator/​Microsoft.DotNet.SwaggerGenerator.MSBuild/​GenerateSwaggerCode.cs — This static IMultiThreadableTask reference is not inert on older MSBuild hosts. Build task…
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​ProductionChannelValidator.cs — The constructor still advertises token as optional, but direct two-argument callers now pass the…
Pre-existing issues (16)
Severity Finding
Medium severity src/​Microsoft.DotNet.SignTool/​src/​SignToolTask.cs — GetAbsolutePath only roots paths; MSBuild 18.8.2 does not canonicalize .. segments. Because… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — AbsolutePath equality compares the unnormalized stored value. Removing Path.GetFullPath means… View comment
Medium severity src/​Microsoft.DotNet.CMake.Sdk/​src/​GetCMakeArtifactsFromFileApi.cs — This replaces Path.GetFullPath with an API that roots but does not canonicalize. A valid… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Templating/​src/​GenerateFileFromTemplate.cs — This no longer preserves the documented behavior of ResolvedOutputPath: GetAbsolutePath roots… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetPack.cs — The existing public Pack(string, string, Manifest, bool) method has been replaced by this… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageIndex.cs — The PackageIndex type is public in a packable assembly, and this migration replaces its… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetUtility.cs — Changing this public helper’s parameter from string to AbsolutePath removes the old binary API.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​common/​AzureStorageUtils.cs — This public method previously accepted string; replacing that signature breaks compiled callers.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​AzureStorageExtensions.cs — Replacing the public CalculateMD5(string) extension helper with an AbsolutePath signature… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — The public Execute method’s four path parameters changed from strings to AbsolutePath, which is… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​ValidateHarvestVersionIsLatestForRelease.cs — This protected virtual signature is part of the public task’s subclassing contract; changing it… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​VersionUtility.cs — This replaces the public GetAssemblyVersion(string) API and will break compiled callers. Keep the… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageItem.cs — Changing the public SourcePath property type from string to AbsolutePath breaks both source… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageReport.cs — Changing this public method from Save(string) to Save(AbsolutePath) removes the existing… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogBuilder.cs — Replacing the public AddFile(string, ...) signature breaks existing source and compiled consumers… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogEntry.cs — Changing this public packaged API from string to AbsolutePath is source- and binary-breaking;… View comment

// implemented so that TaskEnvironment is injected and paths resolve correctly;
// the task simply keeps running in the task host under -mt.
#pragma warning disable MSBuildTask0013 // Interface without the attribute is deliberate; see the comment above.
public class GenerateSwaggerCode : Task, IMultiThreadableTask
_token = string.IsNullOrEmpty(token)
? Environment.GetEnvironmentVariable("SYSTEM_ACCESSTOKEN")
: token;
_token = token;
# Conflicts:
#	src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateLightCommandPackageDrop.cs
#	src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateWixBuildWixpack.cs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

UpdatePackageIndex exposes a mutable cached index to concurrent tasks, and several public signature changes break binary compatibility.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 2 High severity · 17 Medium severity

New issues introduced by this change (1)
Severity Finding
High severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​UpdatePackageIndex.cs — This task is not safe to opt into in-process concurrency yet. PackageIndex.Load caches and…
Pre-existing issues (18)
Severity Finding
High severity src/​Microsoft.DotNet.SwaggerGenerator/​Microsoft.DotNet.SwaggerGenerator.MSBuild/​GenerateSwaggerCode.cs — This static IMultiThreadableTask reference is not inert on older MSBuild hosts. Build task… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​ProductionChannelValidator.cs — The constructor still advertises token as optional, but direct two-argument callers now pass the… View comment
Medium severity src/​Microsoft.DotNet.SignTool/​src/​SignToolTask.cs — GetAbsolutePath only roots paths; MSBuild 18.8.2 does not canonicalize .. segments. Because… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — AbsolutePath equality compares the unnormalized stored value. Removing Path.GetFullPath means… View comment
Medium severity src/​Microsoft.DotNet.CMake.Sdk/​src/​GetCMakeArtifactsFromFileApi.cs — This replaces Path.GetFullPath with an API that roots but does not canonicalize. A valid… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Templating/​src/​GenerateFileFromTemplate.cs — This no longer preserves the documented behavior of ResolvedOutputPath: GetAbsolutePath roots… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetPack.cs — The existing public Pack(string, string, Manifest, bool) method has been replaced by this… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageIndex.cs — The PackageIndex type is public in a packable assembly, and this migration replaces its… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetUtility.cs — Changing this public helper’s parameter from string to AbsolutePath removes the old binary API.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​common/​AzureStorageUtils.cs — This public method previously accepted string; replacing that signature breaks compiled callers.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​AzureStorageExtensions.cs — Replacing the public CalculateMD5(string) extension helper with an AbsolutePath signature… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — The public Execute method’s four path parameters changed from strings to AbsolutePath, which is… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​ValidateHarvestVersionIsLatestForRelease.cs — This protected virtual signature is part of the public task’s subclassing contract; changing it… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​VersionUtility.cs — This replaces the public GetAssemblyVersion(string) API and will break compiled callers. Keep the… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageItem.cs — Changing the public SourcePath property type from string to AbsolutePath breaks both source… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageReport.cs — Changing this public method from Save(string) to Save(AbsolutePath) removes the existing… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogBuilder.cs — Replacing the public AddFile(string, ...) signature breaks existing source and compiled consumers… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogEntry.cs — Changing this public packaged API from string to AbsolutePath is source- and binary-breaking;… View comment
Suppressed comments (9)

src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageIndex.cs:34

  • Changing these public Load APIs from string to AbsolutePath removes the existing CLR signatures, so binaries compiled against the shipped packable task assembly will fail with MissingMethodException after an Arcade update. This conflicts with the repository's no-breaking-changes policy (Documentation/Policy/ChangesPolicy.md:1-18). Keep compatibility overloads accepting the original string types and delegate them to the new typed implementations; the same applies to this class's changed public Save, Merge, and MergeFramework* methods.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageReport.cs:32
  • Replacing this public Save(string) signature with Save(AbsolutePath) is a binary-breaking change in the shipped Packaging task assembly, contrary to Documentation/Policy/ChangesPolicy.md:1-18; Load(string) below has the same problem. Preserve the string overloads and have them delegate to the typed implementations so existing consumers continue to bind.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/PackageItem.cs:90
  • Changing the type of this public property removes its existing getter signature (string get_SourcePath()), which is binary-breaking for consumers of the packable Packaging assembly and violates Documentation/Policy/ChangesPolicy.md:1-18. Keep SourcePath as string for compatibility and carry the validated AbsolutePath in a separate internal property, or follow the documented breaking-change process.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/VersionUtility.cs:25
  • This replaces the public GetAssemblyVersion(string) CLR signature, so existing compiled consumers will fail to bind after updating the package. Preserve a string overload that delegates to the new AbsolutePath implementation, as required by the no-breaking-changes policy in Documentation/Policy/ChangesPolicy.md:1-18.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/NuGetPack.cs:281
  • Adding the absoluteNuspecPath parameter replaces the existing public Pack(string, string, Manifest, bool) method rather than extending it, which is a binary-breaking API change under Documentation/Policy/ChangesPolicy.md:1-18. Retain the old overload and delegate to the typed implementation after resolving nuspecPath through this task's TaskEnvironment.
    src/Microsoft.DotNet.Build.Tasks.Packaging/src/ValidateHarvestVersionIsLatestForRelease.cs:67
  • Changing this protected virtual method's parameter type breaks existing subclasses and removes the original CLR override slot, contrary to Documentation/Policy/ChangesPolicy.md:1-18. Keep the virtual string signature and resolve it through TaskEnvironment inside the base implementation before calling PackageReport.Load; this still gives the task an absolute path without breaking overrides.
    src/Microsoft.DotNet.GenFacades/GenPartialFacadeSourceGenerator.cs:24
  • This changes the signature of a public static entry point in a shipped assembly, removing the overload that accepts string paths and breaking existing compiled callers under Documentation/Policy/ChangesPolicy.md:1-18. Keep the original Execute(string[], string, string[], ..., string, ...) overload as a compatibility wrapper that converts to absolute paths, and move the typed implementation behind a separate overload.
    src/Microsoft.DotNet.Build.Tasks.Feed/src/AzureStorageExtensions.cs:18
  • Replacing the public string parameter with AbsolutePath removes the existing CalculateMD5(string) binary signature; the public IsFileIdenticalToBlobAsync change below does likewise. Preserve string overloads that delegate to the typed methods so consumers of this task assembly are not broken, per Documentation/Policy/ChangesPolicy.md:1-18.
    public static string CalculateMD5(AbsolutePath filename)

src/Microsoft.DotNet.Build.Tasks.Feed/src/common/AzureStorageUtils.cs:140

  • This public method's parameter-type change removes the existing CLR signature and breaks binaries compiled against the Feed task assembly, contrary to Documentation/Policy/ChangesPolicy.md:1-18. Keep an IsFileIdenticalToBlobAsync(string, string) compatibility overload that delegates to the typed implementation.
    public async Task<bool> IsFileIdenticalToBlobAsync(AbsolutePath localFileFullPath, string blobPath) =>
        await GetBlob(blobPath).IsFileIdenticalToBlobAsync(localFileFullPath);

Comment on lines +19 to +20
[MSBuildMultiThreadableTask]
public class UpdatePackageIndex : Microsoft.Build.Utilities.Task, IMultiThreadableTask
# Conflicts:
#	src/Microsoft.DotNet.Arcade.Sdk/src/DownloadFile.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/ExtractNgenMethodList.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/GenerateChecksums.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/GenerateSourcePackageSourceLinkTargetsFile.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/GetLicenseFilePath.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/InstallDotNetCore.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/LocateDotNet.cs
#	src/Microsoft.DotNet.Arcade.Sdk/src/SaveItems.cs
#	src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAndroidWorkItems.cs
#	src/Microsoft.DotNet.Helix/Sdk/CreateXHarnessAppleWorkItems.cs
#	src/Microsoft.DotNet.Helix/Sdk/InstallDotNetTool.cs
#	src/Microsoft.DotNet.Helix/Sdk/SendHelixJob.cs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Package-index source tracking loses canonicalization, allowing equivalent paths to bypass duplicate-merge protection.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Balanced
Findings: 2 High severity · 18 Medium severity

New issues introduced by this change (1)
Severity Finding
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageIndex.cs — GetAbsolutePath preserves .. segments, so storing Value here regresses the previous…
Pre-existing issues (19)
Severity Finding
High severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​UpdatePackageIndex.cs — This task is not safe to opt into in-process concurrency yet. PackageIndex.Load caches and… View comment
High severity src/​Microsoft.DotNet.SwaggerGenerator/​Microsoft.DotNet.SwaggerGenerator.MSBuild/​GenerateSwaggerCode.cs — This static IMultiThreadableTask reference is not inert on older MSBuild hosts. Build task… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​ProductionChannelValidator.cs — The constructor still advertises token as optional, but direct two-argument callers now pass the… View comment
Medium severity src/​Microsoft.DotNet.SignTool/​src/​SignToolTask.cs — GetAbsolutePath only roots paths; MSBuild 18.8.2 does not canonicalize .. segments. Because… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — AbsolutePath equality compares the unnormalized stored value. Removing Path.GetFullPath means… View comment
Medium severity src/​Microsoft.DotNet.CMake.Sdk/​src/​GetCMakeArtifactsFromFileApi.cs — This replaces Path.GetFullPath with an API that roots but does not canonicalize. A valid… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Templating/​src/​GenerateFileFromTemplate.cs — This no longer preserves the documented behavior of ResolvedOutputPath: GetAbsolutePath roots… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetPack.cs — The existing public Pack(string, string, Manifest, bool) method has been replaced by this… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageIndex.cs — The PackageIndex type is public in a packable assembly, and this migration replaces its… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​NuGetUtility.cs — Changing this public helper’s parameter from string to AbsolutePath removes the old binary API.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​common/​AzureStorageUtils.cs — This public method previously accepted string; replacing that signature breaks compiled callers.… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Feed/​src/​AzureStorageExtensions.cs — Replacing the public CalculateMD5(string) extension helper with an AbsolutePath signature… View comment
Medium severity src/​Microsoft.DotNet.GenFacades/​GenPartialFacadeSourceGenerator.cs — The public Execute method’s four path parameters changed from strings to AbsolutePath, which is… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​ValidateHarvestVersionIsLatestForRelease.cs — This protected virtual signature is part of the public task’s subclassing contract; changing it… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​VersionUtility.cs — This replaces the public GetAssemblyVersion(string) API and will break compiled callers. Keep the… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageItem.cs — Changing the public SourcePath property type from string to AbsolutePath breaks both source… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.Packaging/​src/​PackageReport.cs — Changing this public method from Save(string) to Save(AbsolutePath) removes the existing… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogBuilder.cs — Replacing the public AddFile(string, ...) signature breaks existing source and compiled consumers… View comment
Medium severity src/​Microsoft.DotNet.Build.Tasks.FileCatalog/​CatalogEntry.cs — Changing this public packaged API from string to AbsolutePath is source- and binary-breaking;… View comment

var result = s_serializer.Deserialize<PackageIndex>(jsonTextReader);
result.IndexSources.Add(Path.GetFullPath(packageIndexFile));
var result = CreateSerializer().Deserialize<PackageIndex>(jsonTextReader);
result.IndexSources.Add(packageIndexFile.Value);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants