Repository navigation
Refactor templates to use shared implementation - #14703
Conversation
…iables under templates-official
…template-refactor
e912651 to
5146457
Compare
| BuildDropPath: '$(Build.SourcesDirectory)/artifacts' | ||
|
|
||
| # 1es specific parameters | ||
| templateIs1ESManaged: '' |
There was a problem hiding this comment.
Not a fan of this name. The template (this template and ones like it) is not 1ES-managed. It's the overall pipeline that chooses to use the 1ES PT. I used an is1ESPipeline parameter for these choices in helix-machines though I'm considering removing that complately…
Have you tested using the 1ES-PT predefined variables❔ There may be no need for new parameters at all if we can leverage OneESPT and perhaps OneESPT.BuildType. From a quick look at the expanded YAML for an official run, it's clear the predefined variables are defined at the top of every job. I suspect our stage and job templates may still need parameters but am not sure. Might want to check in the 1ES Pipeline Templates (1ES PT) / Support - General Teams channel for their thoughts on predefined variable use during template expansion before going too far down this path.
(I may test things out soon too.)
There was a problem hiding this comment.
The template (this template and ones like it) is not 1ES-managed
IMO, the template is managed by 1ES because of its requirement on extends. I admit, it's a bit pedantic though and i'm happy to use whatever parameter causes less angst. i'll change it to is1ESPipeline.
I think parameters are the right implementation for the desired behavior and I don't see the need to add in 1ES variables (at this time).
This reverts commit 3f98460.
Fixes dotnet/dnceng#2168
This change refactors .NET Engineering's templates to use core templates for shared logic. Most of the notes on this change are in the included
eng/common/template-guidance.mdfile.Validation jobs:
Not sure of a great way to review these changes.
To double check: