Repository navigation
Add WiX support to OneLocBuild - #10383
Conversation
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Sample project looks good 🎉
| ) | ||
| }, | ||
| @{ | ||
| LanguageSet = "cs-CZ;de-DE;es-ES;fr-FR;it-IT;ja-JP;ko-KR;pl-PL;pt-BR;ru-RU;tr-TR;zh-CN;zh-TW" |
There was a problem hiding this comment.
Pity https://ceapex.visualstudio.com/CEINTL/_git/SoftwareLocalization?path=/src/OneBranchPackages/Localization.Languages/Localization.Languages.props lacks a language set matching this.
|
Looks like we need to add exclusions to avoid e.g. https://github.com/dotnet/aspnetcore/blob/afd459e52b8239fa819bf52bcd35c3da72042eeb/src/Installers/Windows/AspNetCoreModule-Setup/setupstrings.wxl. According to a @joeloff, we only want / need to localize the hosting bundle installers. Could you remind me of the exclusion syntax❔ Separately, what's the best way to inform the loc team that the repo already contains translations for most of the strings (the case in all repos I looked at)❔ /cc @vlada-shubina @cristianosuzuki77 |
|
@dougbu did I really say we only care about the hosting bundle? ASP.NET is building separate bundles for just the runtime as I recall, and we have the SDK/desktop/runtime bundles too |
|
Sorry @joeloff, I should have emphasized the word "bundle" rather than "hosting". That's the gist of what you said and our hosting bundle was an example. @jonfortescue the overall point here is we have WXL files that aren't worth localization. |
|
Curious: Will the |
Xharness flakiness is unfortunately just a sign of flaky on-prem devices, unless you're touching the XHarness SDK you should comfortably ignore failures and retry, letting us know if it's persistently failing (because this usually means a machine gone bad) |
|
Given everything here is passing and seems to be working, I'm merging. |
* Exclude some .wxl files from localization - preparing for dotnet/arcade#10383 merge and migration to this repo - without this, `OneLocBuild` will generate multiple unused translation files * !fixup! Correct JSON syntax
Makes the generate-locprojectjson script pick up wxl files for WiX localization. Example of the generated locproject.json here. Sample PR here.
Closes #10298.