Skip to content

Include properties needed for servicing redirect in jobs created by SendHelixJob #7074

Closed

Description

@lpatalas
  • This issue is blocking
  • This issue is causing unreasonable pain

We need to include System.PullRequest.TargetBranch pipeline variable in job properties to be able to redirect PR test jobs to servicing subscription. Currently Helix API has no way to tell if the PR was created for main or release/* branch.

This has to be done for all supported .NET versions. i.e.: 3.1, 5.0 and 6.0.

Activity

  1. self-assigned this
    on Mar 9, 2021
  2. changed the title [-]Include properties needed for servicing redirect in job created by SendHelixJob[/-] [+]Include properties needed for servicing redirect in jobs created by SendHelixJob[/+] on Mar 9, 2021
  3. lpatalas commented on Mar 11, 2021

    @lpatalas
    ContributorAuthor

    All three PRs for 3.x, 5.0 and main were merged. Next step is to trigger the subscriptions for 3.x and 5.0 branches which I will do today.

  4. lpatalas commented on Mar 15, 2021

    @lpatalas
    ContributorAuthor

    The changes in main are ready. 3.x and 5.0 are validated but didn't make it in current servicing cycle. They will wait until the next servicing cycle but the work is finished.

  5. lpatalas commented on Apr 16, 2021

    @lpatalas
    ContributorAuthor

    Helix.Sdk was updated in most of 3.x and 5.x servicing branches. Below are the repos that don't have the updated version of Helix.Sdk (2.0.0-beta.21161.1). Most of these branches does not seem to have been modified recently with the exception of dotnet/coreclr.

    Repository Branch Helix.Sdk version
    dotnet/coreclr release/3.1-crossdac 2.0.0-beta.21072.7
    dotnet/coreclr release/3.1 2.0.0-beta.21072.7
    dotnet/sdk release/3.1.3xx 2.0.0-beta.20113.5
    dotnet/sdk release/3.1.2xx 2.0.0-beta.20113.5
    dotnet/wcf release/3.1.0 2.0.0-beta.20113.5
    dotnet/corefx release/3.1-blazor 2.0.0-beta.20113.5
  6. mmitche commented on Apr 16, 2021

    @mmitche
    Member

    Removed the branches that I know do not need the update:

    Repository Branch Helix.Sdk version
    dotnet/coreclr release/3.1-crossdac 2.0.0-beta.21072.7
    dotnet/coreclr release/3.1 2.0.0-beta.21072.7
    dotnet/wcf release/3.1.0 2.0.0-beta.20113.5
  7. lpatalas commented on Apr 16, 2021

    @lpatalas
    ContributorAuthor

    The missed 3.1 branches will be updated during next servicing window. It's not clear at the moment what is the process for release/3.1-crossdac.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions