Skip to content

1ESPT template refactor dropped in-pipeline SDL runs #4627

Closed as not planned
Closed as not planned

Description

@mmitche
  • This issue is blocking
  • This issue is causing unreasonable pain

dotnet/arcade#14703 dropped the SDL runs. The call to the SDL template would have been here: https://github.com/dotnet/arcade/blob/main/eng/common/core-templates/post-build/post-build.yml#L261. This change then got backported to older branches (to templates-official). There are some gaps in 1ESPT SDL vs. Arcade's. We should fix this for now.

Activity

  1. mmitche commented on Oct 7, 2024

    @mmitche
    MemberAuthor

    @chcosta @riarenas

  2. chcosta commented on Oct 7, 2024

    @chcosta
    Member

    I thought the plan was not to ackport that because there were so many differences in the templates for prior releases and it would require essentially handcrafting the change in each branch

  3. mmitche commented on Oct 7, 2024

    @mmitche
    MemberAuthor

    We didn't backport the change directly, but some of it made its way into the official templates of older versions.

  4. mmitche commented on Oct 8, 2024

    @mmitche
    MemberAuthor

    Turns out some of the tooling doesn't do a good enough job for product signoff at this point :/

  5. markwilkie commented on Oct 8, 2024

    @markwilkie

    I thought the release process caught this? If more work needs to be done, do you think it falls to Prague?

    Also, isn't 1ES on the hook to make this happen?

  6. mmitche commented on Oct 8, 2024

    @mmitche
    MemberAuthor

    1ES is on the hook to make this happen and make it better. It's a matter of timing (since GA is so close). We'll keep on as we are today as there are some workarounds to make 1ES behave sort of how we need.

  7. transferred this issue fromdotnet/arcadeon Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions