Skip to content

[Native] Remove unused printf debugging helper - #12156

Merged
simonrozsival merged 2 commits into
mainfrom
dev/simonrozsival/remove-pd-log-location
Jul 17, 2026
Merged

simonrozsival merged 2 commits into
mainfrom
dev/simonrozsival/remove-pd-log-location

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Summary

Remove the unused pd_log_location() printf-debugging helper from both native cpp-util.hh implementations.

A repository-wide search found no callers. Because the helper is inline and unused, it currently emits no code; retaining it only leaves dead std::format-style logging source available to be copied or accidentally used later.

Changes

  • remove pd_log_location() from the shared CoreCLR/NativeAOT header;
  • remove the duplicate helper from the MonoVM header.

Validation

  • repository-wide search confirms there are no remaining declarations or callers;
  • representative Android arm64 NativeAOT, CoreCLR, and MonoVM translation units compile with the repository-generated NDK commands;
  • git diff --check.

Related to #12139.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 70f63eb7-6599-414c-a947-d860705aa0fa
Copilot AI review requested due to automatic review settings July 17, 2026 12:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unused pd_log_location() inline “printf debugging” helper from the two native cpp-util.hh header variants (shared CoreCLR/NativeAOT and MonoVM), reducing dead logging code that could inadvertently be reused later.

Changes:

  • Deleted pd_log_location() from src/native/common/include/shared/cpp-util.hh.
  • Deleted the duplicate pd_log_location() from src/native/mono/shared/cpp-util.hh.
  • Verified there are no remaining declarations/callers in the repo (no references found).
Show a summary per file
File Description
src/native/mono/shared/cpp-util.hh Removes the unused inline pd_log_location() helper from the MonoVM header.
src/native/common/include/shared/cpp-util.hh Removes the unused inline pd_log_location() helper from the shared CoreCLR/NativeAOT header.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

@simonrozsival simonrozsival added drop-libcpp Work to remove the libc++ dependency from Android NativeAOT ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable). labels Jul 17, 2026
@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) July 17, 2026 17:37
@simonrozsival
simonrozsival disabled auto-merge July 17, 2026 20:22
@simonrozsival
simonrozsival merged commit 685abe3 into main Jul 17, 2026
41 of 44 checks passed
@simonrozsival
simonrozsival deleted the dev/simonrozsival/remove-pd-log-location branch July 17, 2026 20:22
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

drop-libcpp Work to remove the libc++ dependency from Android NativeAOT ready-to-review This PR is ready to review/merge, I think any CI failures are just flaky (ignorable).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants