Repository navigation
[Native] Remove unused printf debugging helper - #12156
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 70f63eb7-6599-414c-a947-d860705aa0fa
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the unused pd_log_location() inline “printf debugging” helper from the two native cpp-util.hh header variants (shared CoreCLR/NativeAOT and MonoVM), reducing dead logging code that could inadvertently be reused later.
Changes:
- Deleted
pd_log_location()fromsrc/native/common/include/shared/cpp-util.hh. - Deleted the duplicate
pd_log_location()fromsrc/native/mono/shared/cpp-util.hh. - Verified there are no remaining declarations/callers in the repo (no references found).
Show a summary per file
| File | Description |
|---|---|
| src/native/mono/shared/cpp-util.hh | Removes the unused inline pd_log_location() helper from the MonoVM header. |
| src/native/common/include/shared/cpp-util.hh | Removes the unused inline pd_log_location() helper from the shared CoreCLR/NativeAOT header. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
jonathanpeppers
approved these changes
Jul 17, 2026
jonathanpeppers
enabled auto-merge (squash)
July 17, 2026 17:37
simonrozsival
disabled auto-merge
July 17, 2026 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused
pd_log_location()printf-debugging helper from both nativecpp-util.hhimplementations.A repository-wide search found no callers. Because the helper is inline and unused, it currently emits no code; retaining it only leaves dead
std::format-style logging source available to be copied or accidentally used later.Changes
pd_log_location()from the shared CoreCLR/NativeAOT header;Validation
git diff --check.Related to #12139.