You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove _RemoveAppAssemblyFromTrimmerRoots workaround once SDK contains dotnet/runtime#125673 #11146
src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.TypeMap.Trimmable.CoreCLR.targets contains a temporary _RemoveAppAssemblyFromTrimmerRoots target (added in #11144) that removes @(IntermediateAssembly) from @(TrimmerRootAssembly) to avoid IL1034 during trimmable typemap builds.
The upstream fix in dotnet/runtime#125673 makes this unnecessary: once the consumed .NET SDK's Microsoft.NET.ILLink.targets contains the '$(OutputType)' != 'Library' condition on the TrimmerRootAssembly Include, the item is never added for Android projects (which force OutputType=Library) in the first place.
Action items
Verify the SDK flow-in has landed (check Microsoft.NET.ILLink.targets in the bundled SDK for the new condition).
Delete the _RemoveAppAssemblyFromTrimmerRoots target and its comment from Microsoft.Android.Sdk.TypeMap.Trimmable.CoreCLR.targets.
Run tests/Microsoft.Android.Sdk.TrimmableTypeMap.Tests and a CoreCLRTrimmable Mono.Android.NET-Tests device run to confirm trimming still works without the workaround.
Activity
Filter Remove on RootMode=EntryPoint + link upstream fix
[TrimmableTypeMap] Fix IL1034 by excluding app assembly from trimmer …
Fix TrimmerRootAssembly for Android apps after dotnet/runtime#125673
Fix TrimmerRootAssembly for Android apps after dotnet/runtime#125673
Bump to dotnet/dotnet@2e6efe3a93 11.0.100-preview.5.26226.111 (dotnet…
Bump to dotnet/dotnet@48bd87d899 11.0.100-preview.4.26224.122 (#11229)