ChannelDbConnectionPool replace connection - #4429

Merged

mdaigle merged 47 commits into

mainfrom

dev/mdaigle/replace-conn-2

Aug 4, 2026

Commits on Jul 13, 2026

Add connection-creation rate limiting to ChannelDbConnectionPool
mdaigle
committed
d3e2fe7

Commits on Jul 14, 2026

Narrow pool rate limiter to ConcurrencyLimiter

mdaigle
and
Copilot
committed
4396432
Replace rate-limit TODOs with rationale comment

mdaigle
and
Copilot
committed
86b4b2a
Remove rate-limit TODOs from AttemptAcquire call

mdaigle
and
Copilot
committed
144a324
Merge remote-tracking branch 'origin/main' into dev/mdaigle/pool-channel-rate-limiting
mdaigle
committed
029ce7e
Inline leaseAcquired into lease.IsAcquired checks

mdaigle
and
Copilot
committed
662b36d
Add test that successful create releases its rate-limiter lease

mdaigle
and
Copilot
committed
87c8631
Add test for lease-release wake path (FR-004)

mdaigle
and
Copilot
committed
19948c2
Address Copilot review: OCE handling, redundant wake, docs, test disposal

mdaigle
and
Copilot
committed
0d60cd4

Commits on Jul 15, 2026

Remove instance-level ForceNewConnection property. Replace with explicit method parameters.
mdaigle
committed
9b91a45
Fix initialization. Add doc comments.
mdaigle
committed
08d24b3
Remove unnecessary internal API surface.
mdaigle
committed
08eff42
Expose param.
mdaigle
committed
e350b42
Address broken test and copilot comments.
mdaigle
committed
e2e1a72
WIP
mdaigle
committed
63edefe
Add unit tests.
mdaigle
committed
949d9b2
Wording
mdaigle
committed
d684191
improve error handling
mdaigle
committed
23cfa38
Address copilot comments.
mdaigle
committed
ae75925
Fix malformed XML doc comment in TryOpenInner remarks

mdaigle
and
Copilot
committed
b266402
Prefer reusing an idle connection in ChannelDbConnectionPool.ReplaceConnection

mdaigle
and
Copilot
committed
88aaffd
Use named forceNewConnection arguments at literal call sites

mdaigle
and
Copilot
committed
19933e7
Return reused connection to the pool on activation failure via PrepareConnection

mdaigle
and
Copilot
committed
ea77190
Condense block comments in ReplaceConnection

mdaigle
and
Copilot
committed
e573441
Document ReplaceConnection design rationale in one header block

mdaigle
and
Copilot
committed
594231c
Merge remote-tracking branch 'origin/main' into dev/mdaigle/pool-channel-rate-limiting

mdaigle
and
Copilot
committed
36e0a51
Merge branch 'dev/mdaigle/pool-channel-rate-limiting' into dev/mdaigle/replace-conn-2

mdaigle
and
Copilot
committed
f7f7f63
Restore named forceNewConnection arguments at test call sites

mdaigle
and
Copilot
committed
69b08b5
clean up comments
mdaigle
committed
fbf37d7
Merge branch 'dev/mdaigle/replace-conn-2' of https://github.com/dotnet/SqlClient into dev/mdaigle/replace-conn-2
mdaigle
committed
0d19e4e

Commits on Jul 16, 2026

Commits on Jul 27, 2026

Merge remote-tracking branch 'origin/main' into dev/mdaigle/replace-conn-2

mdaigle
and
Copilot
committed
418bf53
Address Copilot review feedback on ReplaceConnection

mdaigle
and
Copilot
committed
5ca5fc8

Commits on Jul 28, 2026

Throw localized message when pool connection replacement fails

mdaigle
and
Copilot
committed
ef4754f
Explain why replacement bypasses the connection-creation rate limiter

mdaigle
and
Copilot
committed
c50865c
Inject FakeTimeProvider in new pool tests to prevent background races

mdaigle
and
Copilot
committed
36c309b
Merge origin/main into dev/mdaigle/replace-conn-2

mdaigle
and
Copilot
committed
7b9e36b
Enter blocking-period error state on replacement open failure

mdaigle
and
Copilot
committed
8736037

Commits on Jul 29, 2026

Address Paul's review feedback

mdaigle
and
Copilot
committed
1f1e766
Use a single tunable factory instance member in the replace tests

mdaigle
and
Copilot
committed
7049271

Commits on Jul 30, 2026

Fix flaky blocking-period assertions in replace tests

mdaigle
and
Copilot
committed
f17552f
Harden remaining blocking-period tests against Azure endpoint poisoning

mdaigle
and
Copilot
committed
f4fab68
Potential fix for pull request finding

mdaigle
and
Copilot
authored
65da630
Merge origin/main into dev/mdaigle/replace-conn-2

mdaigle
and
Copilot
committed
553330b