Skip to content

Revert "Test | Expose internal types to ManualTests" - #3268

Merged
cheenamalhotra merged 1 commit into
mainfrom
revert-3239-dev/mdaigle/expose-internals-to-tests
Apr 10, 2025
Merged

Revert "Test | Expose internal types to ManualTests"#3268
cheenamalhotra merged 1 commit into
mainfrom
revert-3239-dev/mdaigle/expose-internals-to-tests

Conversation

@mdaigle

@mdaigle mdaigle commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Reverts #3239

This change was causing confusion because it's only a partial solution and only works in Visual Studio.
Visual Studio build uses implementation assemblies, which contain internal types.
MSBuild uses the reference assemblies, which don't contain internal types.

We can reapply this change when we've updated our reference assemblies to include internal types.

@codecov

codecov Bot commented Apr 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.03%. Comparing base (61e2317) to head (2383f9f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
+ Coverage   72.81%   73.03%   +0.22%     
==========================================
  Files         297      296       -1     
  Lines       59661    57254    -2407     
==========================================
- Hits        43440    41817    -1623     
+ Misses      16221    15437     -784     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.30% <ø> (+0.11%) ⬆️
netfx 71.43% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotra
cheenamalhotra merged commit f6c4a0a into main Apr 10, 2025
@cheenamalhotra
cheenamalhotra deleted the revert-3239-dev/mdaigle/expose-internals-to-tests branch April 10, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants