Move into Shared SqlMetaDataFactory.cs - #1315
Merged
cheenamalhotra merged 6 commits intoOct 18, 2021
Merged
Conversation
… update references in csprojs
…0090, and IDE0051
Kaur-Parminder
approved these changes
Oct 5, 2021
DavoudEshtehari
added
the
Code Health 💊
Contributor
|
Looks like the netfx file is still there. |
johnnypham
approved these changes
Oct 6, 2021
lcheunglci
force-pushed
the
MergeShared-SqlMetadataFactory
branch
from
October 16, 2021 04:16
8bb1f4d to
163b837
Compare
cheenamalhotra
requested changes
Oct 18, 2021
cheenamalhotra
left a comment
cheenamalhotra
left a comment
Member
There was a problem hiding this comment.
Linux builds are failing, there seems to be an issue with conflict resolution.
Member
|
/azp run CI-Ub16-SQL17L-TR, CI-Ub16-AzureSQLDB |
|
Azure Pipelines successfully started running 2 pipeline(s). |
…th the file name of SqlMetadataFactory.cs
Contributor
Author
|
Looks like a case sensitivity issue with the csproj, I've updated the netcore csproj to reference the proper casing for it in my last commit. Thanks! |
cheenamalhotra
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1261 . Moved the netcore version into shared src and updated the csproj references