[3.0] Improve handling of affixed names when singularizing (OES/SGIS issue) and expose NameAffix API - #2535
Merged
Exanite merged 13 commits intoJan 24, 2026
Conversation
… prefix; Rewrite StripAffixes to not allocate; Update PrettifyNames to use new GetAffixes method
Exanite
force-pushed
the
fix/vendor-suffix-singularize-interaction
branch
from
January 13, 2026 08:14
6b7c293 to
589792e
Compare
… the AddNameAffix method instead of AddNameSuffix/Prefix separately
Exanite
commented
Jan 15, 2026
Exanite
marked this pull request as ready for review
January 15, 2026 01:10
curin
approved these changes
Jan 20, 2026
Exanite
enabled auto-merge
January 22, 2026 13:03
Exanite
disabled auto-merge
January 24, 2026 03:20
Exanite
enabled auto-merge (squash)
January 24, 2026 16:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This fixes the interaction between Khronos vendor suffixes and the Singularize method, which led to cases like the following:
In order to fix this, this also exposes the NameAffix API, allowing mods to read NameAffix attributes and process the name without the affixes attached.
Related issues, Discord discussions, or proposals
Original Discord discussion: https://discord.com/channels/521092042781229087/1376331581198827520/1456785841753035005
Further Comments
Todo list:
OESand similar from being singularizing intoOinArrayParameterTransformer.TransformArrayParameterRewriter.glFeedbackBufferxOESTransformArrayParameterRewritercan singularize the base name instead of the full name.OES(incorrect version isOOES)SGIS(incorrect version isSgiSGIS)NameAffixdata.AddNameAffixAPI to use the newNameAffixTypeenum for consistency and simplicity