Skip to content

Evaluate Apple Silicon for CI - #1693

Merged
Perksey merged 31 commits into
mainfrom
hotfix/apple-silicon-xlarge-runner
Oct 10, 2023
Merged

Evaluate Apple Silicon for CI#1693
Perksey merged 31 commits into
mainfrom
hotfix/apple-silicon-xlarge-runner

Conversation

@Perksey

@Perksey Perksey commented Oct 2, 2023

Copy link
Copy Markdown
Member

No description provided.

Comment thread .github/workflows/build.yml Outdated
@Perksey

Perksey commented Oct 6, 2023

Copy link
Copy Markdown
Member Author

Pinged (pung?) a message to Chris S to see whether we can easily get access to some chonky Windows runners, but it really sucks that compiling Android on Apple Silicon doesn't work...

Comment thread build/nuke/Build.Support.cs Outdated
@Perksey

Perksey commented Oct 9, 2023

Copy link
Copy Markdown
Member Author

Ready for review.

@Perksey
Perksey marked this pull request as ready for review October 9, 2023 22:01
@Perksey
Perksey requested review from a team and HurricanKai as code owners October 9, 2023 22:01

@Beyley Beyley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id like if we still ran the Test step at least on windows as well, but that can be done in a later PR at some point, but im happy with this change

@Perksey
Perksey merged commit 9014e3b into main Oct 10, 2023
@Perksey
Perksey deleted the hotfix/apple-silicon-xlarge-runner branch October 10, 2023 00:53
Perksey added a commit that referenced this pull request Nov 20, 2023
* Evaluate Apple Silicon for CI

* Let's see what happens if we don't install old .NET versions

* sus error message on .NET 6

* BinaryFormatter 🤮🤮🤮

* Work around some deficiencies in the RC1 SDK (dotnet/sdk#35811)

* oops

* github.dev find+replace does not work

* Maths unit tests are now .NET 8

* Vulkan unit tests are now .NET 8

* Ok let's just disable tests for now

* Don't forget the public API!

* Attempt to fix android, as well as cache to make faster maybe

* Install Android platforms

* Reenable .NET 6?

* Install workloads for .NET 6 and .NET 8

* Comical hack

* ANNIHILATE .NET 8

* Install Android 31

* Maybe the tests are fine on .NET 6?

* they were not fine

* Forgo Apple Silicon for now

* Apparently caching is slower than JUST DOING IT

* Fix a very sus unit test failure

* Just testing something...

* Update build.yml

* attempt 2

* Tinker with Apple Silicon again

* Detailed verbosity, will probably regret this

* Update .NET 6

* Update build/nuke/Build.Support.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants