Skip to content

Fix version height parity for filtered paths - #1489

Merged
AArnott merged 2 commits into
v3.10from
fix/1488-version-height-parity
Aug 28, 2026
Merged

AArnott merged 2 commits into
v3.10from
fix/1488-version-height-parity

Conversation

@AArnott

@AArnott AArnott commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • count deletions of included files when pathFilters contains only exclusions
  • align managed and LibGit2 height calculations for mode changes, file/directory replacements, literal path-filter metacharacters, and case-insensitive repositories
  • add regression coverage that runs against both Git engines

Fixes #1488

Tests

  • dotnet test --project test\Nerdbank.GitVersioning.Tests\Nerdbank.GitVersioning.Tests.csproj --framework net10.0 -- --filter-class VersionOracleManagedTests --filter-class VersionOracleLibGit2Tests --filter-not-trait "TestCategory=FailsInCloudTest"

AArnott and others added 2 commits August 28, 2026 09:37
Treat paths as included by default when path filters contain only exclusions, and recurse through deleted directories when evaluating managed Git changes.

Fixes #1488

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Count mode-only changes and file-directory replacements in the managed engine. Apply literal and case-aware FilterPath semantics to LibGit2 include filters, with cross-engine regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@AArnott AArnott added this to the v3.10 milestone Aug 28, 2026
@AArnott
AArnott enabled auto-merge August 28, 2026 16:28
@AArnott
AArnott merged commit dea9a6c into v3.10 Aug 28, 2026
12 checks passed
@AArnott
AArnott deleted the fix/1488-version-height-parity branch August 28, 2026 16:44
This was referenced Aug 28, 2026
craigktreasure pushed a commit to craigktreasure/Treasure.Utils that referenced this pull request Aug 29, 2026
Updated [nbgv](https://github.com/dotnet/Nerdbank.GitVersioning) from
3.10.91 to 3.10.94.

<details>
<summary>Release notes</summary>

_Sourced from [nbgv's
releases](https://github.com/dotnet/Nerdbank.GitVersioning/releases)._

## 3.10.94

## What's Changed
* Fix version height parity for filtered paths by @​AArnott in
dotnet/Nerdbank.GitVersioning#1489


**Full Changelog**:
dotnet/Nerdbank.GitVersioning@v3.10.91...v3.10.94

Commits viewable in [compare
view](dotnet/Nerdbank.GitVersioning@v3.10.91...v3.10.94).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=nbgv&package-manager=nuget&previous-version=3.10.91&new-version=3.10.94)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant